From nobody Fri Mar 29 14:21:04 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=nutanix.com Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1642068435707163.8471612761457; Thu, 13 Jan 2022 02:07:15 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-418-bkIv7qS8Ps6qdLjBDqOckA-1; Thu, 13 Jan 2022 05:07:12 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AF5E51006AA9; Thu, 13 Jan 2022 10:07:07 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8CBAE60C3E; Thu, 13 Jan 2022 10:07:07 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 5886E4A705; Thu, 13 Jan 2022 10:07:07 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 20D8efNA023013 for ; Thu, 13 Jan 2022 03:40:41 -0500 Received: by smtp.corp.redhat.com (Postfix) id 565132027EB5; Thu, 13 Jan 2022 08:40:41 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast09.extmail.prod.ext.rdu2.redhat.com [10.11.55.25]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 512C8201AC7F for ; Thu, 13 Jan 2022 08:40:38 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2D87A2B7603F for ; Thu, 13 Jan 2022 08:40:38 +0000 (UTC) Received: from mx0a-002c1b01.pphosted.com (mx0a-002c1b01.pphosted.com [148.163.151.68]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-438-D9okpZVoO1iYRDgVrf2gjA-1; Thu, 13 Jan 2022 03:40:36 -0500 Received: from pps.filterd (m0127838.ppops.net [127.0.0.1]) by mx0a-002c1b01.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 20D5SulS018612 for ; Thu, 13 Jan 2022 00:40:35 -0800 Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2176.outbound.protection.outlook.com [104.47.57.176]) by mx0a-002c1b01.pphosted.com (PPS) with ESMTPS id 3dhdfakxsf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 13 Jan 2022 00:40:35 -0800 Received: from CY4PR0201MB3460.namprd02.prod.outlook.com (2603:10b6:910:91::14) by BL0PR02MB5651.namprd02.prod.outlook.com (2603:10b6:208:85::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.10; Thu, 13 Jan 2022 08:40:32 +0000 Received: from CY4PR0201MB3460.namprd02.prod.outlook.com ([fe80::9c6c:b86b:be1:d583]) by CY4PR0201MB3460.namprd02.prod.outlook.com ([fe80::9c6c:b86b:be1:d583%5]) with mapi id 15.20.4888.011; Thu, 13 Jan 2022 08:40:32 +0000 X-MC-Unique: bkIv7qS8Ps6qdLjBDqOckA-1 X-MC-Unique: D9okpZVoO1iYRDgVrf2gjA-1 From: Ivan Teterevkov To: libvir-list@redhat.com Subject: [PATCH] rpc: Emit a warning when applying RPC throttling Date: Thu, 13 Jan 2022 08:40:22 +0000 Message-Id: <20220113084022.56967-1-ivan.teterevkov@nutanix.com> X-ClientProxiedBy: SJ0PR03CA0217.namprd03.prod.outlook.com (2603:10b6:a03:39f::12) To CY4PR0201MB3460.namprd02.prod.outlook.com (2603:10b6:910:91::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5d7001db-2104-496d-2c89-08d9d6705c42 X-MS-TrafficTypeDiagnostic: BL0PR02MB5651:EE_ X-Microsoft-Antispam-PRVS: x-proofpoint-crosstenant: true X-MS-Oob-TLC-OOBClassifiers: OLM:4502 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0 X-Microsoft-Antispam-Message-Info: 66xt4h38Wb76akzUk48NgO1sNODJ3V9fV9QgLJ1f/cJhPDzs3N9Apw7ilfKy3sn0/j3uBW4bLp7R8nNEgE7a5Jdj/W1oRBz9mxzZbKh2Rwr9RMcIF/++mPkxDbBjG30Gr5CimE43aaB7U9Xh1o9WeIZN1UlHla2T1V6lmpCIfg6xgmwJXUtir88MXC+0rKHsdD2Y+ch4hxtW/Wl8H5bmoYwYb8e5FhVfZCuMI8vHLAqukam76ME9sMpF0v3EjJkFp7LDl35EYF3wFhvi1os+BIItOkaZEiM+7SvRoQxFH/IwvVyksljD9nDvQqyHEtuy7DXNq2YIm/s3ijzHYLk83b2Moe7B+ZkMHnfrBCuTb7l2caHXk1luSte5wRNOla2kH9KNog5CwCgLAmtTlRR1I5kpqs4VWTJazjEhAKqe3mih0LdOAs+12xIkjlmQxrTo4p6d891jLQXbe71KgC184i/Ju5wRLcpHW29PVuft0dNXSkYpfXXLAup9BsBszxOxOzSx/EAn+gZVlEJWDZ6WYfs+IiS02sE6GEnaaG0qwsLBQGGAP08DZbLa48n0mufaRyRoatSAYDRAd7Ik3avFhF7C8ecVkNJVVvKTK31uy7Knhnh7AwuK9RXXp0lPEpti38TqvbjuYQLDYgQik0341r6tmZxEYmFLh83aN9Kboqu8LH2E2J/AJ99/NLQs8WwpoedcVhrQM/CMZDSOlYm1Cw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY4PR0201MB3460.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(5660300002)(6916009)(2906002)(66476007)(66556008)(38350700002)(44832011)(38100700002)(8936002)(66946007)(6506007)(508600001)(8676002)(1076003)(2616005)(83380400001)(6512007)(36756003)(26005)(107886003)(316002)(86362001)(52116002)(186003)(4326008)(6666004)(6486002); DIR:OUT; SFP:1102 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?8KsKVLO1Oix4nT54fhEWX78LmjTJuoXAgJt4TISV28JFL4+RN287s7sSCu85?= =?us-ascii?Q?OgDljZ929pUydcvsFgrbnBW1vANMvJUGi4zJxpyTx3xo9Ix6uFcqzF4OCNt8?= =?us-ascii?Q?pdmRnvFKZoQLYkA07lpTfes3VrJnct8bMpVrw22KVJi7ggOAkJIybJ4jXl+6?= =?us-ascii?Q?ohppyZ6pil/3dZ91hJJsumAdUDnBSFBd9eXP8sGbPq/n5kvebkIOSJeTTC4M?= =?us-ascii?Q?7Nh1cLhhkCmkYSYRZiMle0uFtFeIOE3c73RY4dku2oZr0Mf0bRt7W6gxY6v5?= =?us-ascii?Q?3940ZIRYoxAgiKRnel3QeRFscAIzmBqJyY0TEvPiuq2iTCZijfBBIeypv6Fp?= =?us-ascii?Q?xgIG+JrUVE1wj53Q5ZX52JIn2S1b3iYqlU5WuIseuLXcQmuBnOLwxKEtc1xB?= =?us-ascii?Q?7Za+h0VMNhfRSuLi+G4mw3NA1qzcpk/m2KfMpXll1DvkAcgJdUqbEjufh26q?= =?us-ascii?Q?iyYPhkmxoSJ+M5SRcO8wf+RwMuhBG2v6LUlaIKns5e260gSDLidpMA+KuRUj?= =?us-ascii?Q?Y1+2+9PiYbvxB9yyttFwkZ6A8MupRdPUSWWQ752bzCbPKJGNDd5T+plv09jh?= =?us-ascii?Q?LhsChfaD5GbuyGrdH0ThxZXYxLOzvjrqtZW77UHD5amqv3w8daA1IWGPy7QR?= =?us-ascii?Q?rVpCPEzChaZy5HZmuBVflDw6Jsal5y1qN2rlM1hqF/zaGXHZJjKcpW7UWGY4?= =?us-ascii?Q?FSeO4VQtT8SkdjzeQX5xgfonZb3XQvvb8+suZO7D/L8dsOpGlML4HnZxJYp+?= =?us-ascii?Q?whgMJyvum1xMX5sb9BrVgF82Ab5XtB96ft/ZBC9vZ9JdRLr7Qcc3J8IECAkL?= =?us-ascii?Q?tiM1N7E+WM8VXsnUw6sMbOuWbWqlJGvrQhGdmcdkXF5TSHy7+ChXvD/y2pr2?= =?us-ascii?Q?Bx4GLF8XKCZ27ZhtViIBUTdn6SEurbA5wNhT309L6ztjtOC6Ruhb8QfVL0p2?= =?us-ascii?Q?pH2QKBsnRxBysEWEtUvPTf9j2nDQD1VpRQcN3F58fQd+yKgX5pUnjQ4USbeQ?= =?us-ascii?Q?GWFX1m901GMXuTOKdbkEv61bhp/bPG/xQOyz7xV6UcQ74ZJKYsBW2kztr4eE?= =?us-ascii?Q?kLE+Uk/DJafRSaaJWQmwRIsAjhgLxH9VQthoDwaeEsUgMp1Z9fd+pOs54Ygf?= =?us-ascii?Q?xzcJCLjWz01aCK+o9Bo4EBnesnYLtXjNgkcQMfEkwxWAn0gNzC6SRDymJEp+?= =?us-ascii?Q?Qmi37R9b6p1Xr7xfWc4idjr0bKaE8pfcoeKTvbkrItt5dHYO7SEshto97/Av?= =?us-ascii?Q?UQgRkLVP1ikFdZUz3LNbbREEurSq16M2GMWPDht816qEr91Tl7N0wDE0gyxI?= =?us-ascii?Q?9HskVODIiaeo+Tu1whkIH9tPJMROIUgROuj1LIUMdzP4xku4Db+1gsBniNmD?= =?us-ascii?Q?y8SSuL/zZAGk5/BcpI68Xwx6WZT/1oTaiW8Kbhj021rBaxNcCgNUk3Q3OKfC?= =?us-ascii?Q?/4kA9mGCzPa1jjfF0eLnZyBgs79/gPOnKqslKM/tl+6gobn8ZKTGT4xgtiVT?= =?us-ascii?Q?2NEZu7yKseKxaqCNlMbUm+iaw5cfBq1dIFSbgWz1NL+Ck7QY3XlFufxXtTuD?= =?us-ascii?Q?RI1W9FJtQRcbKbEVzR8P5EmnKSjuf0jQIxTOphnx2c2QcRQKz4T7DbG6sj2M?= =?us-ascii?Q?HwVGQiRN2aORESaShn4DjuhN5zsjlYfMKvhVi5tq7qtTGEsglvlExVl7waIo?= =?us-ascii?Q?ABly7RhtUzm58GSXKtmSiDoPkuU=3D?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5d7001db-2104-496d-2c89-08d9d6705c42 X-MS-Exchange-CrossTenant-AuthSource: CY4PR0201MB3460.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jan 2022 08:40:32.4657 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6Y19QXW3b7GpKIYhxLDhddnOV6/eH6PeXekPrZDYrWx9vQIVZvUBPrRKszbOn93tGOeVY3cbKbXhlq7x0ZVHSh7S87qUXDGP7WCDJ6CNAtk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR02MB5651 X-Proofpoint-ORIG-GUID: Uzourvjlx7hAHigTlD0qzy1ctZaYTd9J X-Proofpoint-GUID: Uzourvjlx7hAHigTlD0qzy1ctZaYTd9J X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205, Aquarius:18.0.790, Hydra:6.0.425, FMLib:17.11.62.513 definitions=2022-01-13_02,2022-01-11_01,2021-12-02_01 X-Proofpoint-Spam-Reason: safe X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: libvir-list@redhat.com X-Mailman-Approved-At: Thu, 13 Jan 2022 04:58:07 -0500 Cc: Ivan Teterevkov X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1642068436511100001 Content-Type: text/plain; charset="utf-8" Whenever the number of outstanding requests being served reaches max_client_requests, the RPC server applies RX throttling and temporarily stops receiving incoming data. Consequently, it stops receiving the keep-alive responses from the client and eventually may cause a connection timeout on the server-side. This patch emits a warning message in such cases so that the users may root-cause the connection timeout and reconfigure max_client_requests depending on their application. Signed-off-by: Ivan Teterevkov --- src/rpc/virnetserverclient.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/rpc/virnetserverclient.c b/src/rpc/virnetserverclient.c index 7050430e17..9d86e1ba3e 100644 --- a/src/rpc/virnetserverclient.c +++ b/src/rpc/virnetserverclient.c @@ -1293,6 +1293,10 @@ static virNetMessage *virNetServerClientDispatchRead= (virNetServerClient *client) client->rx->buffer =3D g_new0(char, client->rx->bufferLeng= th); client->nrequests++; } + } else { + VIR_WARN("Applying RPC throttling, consider increasing " + "max_client_requests (client->nrequests_max=3D%zu)", + client->nrequests_max); } virNetServerClientUpdateEvent(client); =20 --=20 2.35.0-rc0