From nobody Fri Dec 19 18:44:27 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=nutanix.com Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1642059292005315.7829356443758; Wed, 12 Jan 2022 23:34:52 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-536-t29ycVSzOQ2i7adLyVD-Qw-1; Thu, 13 Jan 2022 02:34:49 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A3B791006AA9; Thu, 13 Jan 2022 07:34:44 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 733D21059109; Thu, 13 Jan 2022 07:34:44 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 3B4734CA9B; Thu, 13 Jan 2022 07:34:44 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 20D7YANd028772 for ; Thu, 13 Jan 2022 02:34:10 -0500 Received: by smtp.corp.redhat.com (Postfix) id A8B791120ABB; Thu, 13 Jan 2022 07:34:10 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast07.extmail.prod.ext.rdu2.redhat.com [10.11.55.23]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A349E1121335 for ; Thu, 13 Jan 2022 07:34:07 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id AB7E23C198A6 for ; Thu, 13 Jan 2022 07:34:07 +0000 (UTC) Received: from mx0b-002c1b01.pphosted.com (mx0b-002c1b01.pphosted.com [148.163.155.12]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-38-V1NkJrb6OxenQOxxDS2SPw-1; Thu, 13 Jan 2022 02:34:04 -0500 Received: from pps.filterd (m0127841.ppops.net [127.0.0.1]) by mx0b-002c1b01.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 20D2iDWj028232; Wed, 12 Jan 2022 23:34:03 -0800 Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2109.outbound.protection.outlook.com [104.47.58.109]) by mx0b-002c1b01.pphosted.com (PPS) with ESMTPS id 3dhby2c2bn-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 12 Jan 2022 23:34:02 -0800 Received: from SJ0PR02MB7775.namprd02.prod.outlook.com (2603:10b6:a03:326::12) by DM8PR02MB8171.namprd02.prod.outlook.com (2603:10b6:8:1c::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.9; Thu, 13 Jan 2022 07:34:01 +0000 Received: from SJ0PR02MB7775.namprd02.prod.outlook.com ([fe80::b8d0:a557:5500:8bd1]) by SJ0PR02MB7775.namprd02.prod.outlook.com ([fe80::b8d0:a557:5500:8bd1%7]) with mapi id 15.20.4888.011; Thu, 13 Jan 2022 07:34:01 +0000 X-MC-Unique: t29ycVSzOQ2i7adLyVD-Qw-1 X-MC-Unique: V1NkJrb6OxenQOxxDS2SPw-1 From: Divya Garg To: libvir-list@redhat.com Subject: [PATCH 1/2 for 8.0] Add the port allocation logic for isa-serial devices. Date: Wed, 12 Jan 2022 23:33:40 -0800 Message-Id: <20220113073341.999064-2-divya.garg@nutanix.com> In-Reply-To: <20220113073341.999064-1-divya.garg@nutanix.com> References: <20220113073341.999064-1-divya.garg@nutanix.com> X-ClientProxiedBy: BYAPR05CA0078.namprd05.prod.outlook.com (2603:10b6:a03:e0::19) To SJ0PR02MB7775.namprd02.prod.outlook.com (2603:10b6:a03:326::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 09db0f72-6bde-40e1-8556-08d9d6671161 X-MS-TrafficTypeDiagnostic: DM8PR02MB8171:EE_ X-Microsoft-Antispam-PRVS: x-proofpoint-crosstenant: true X-MS-Oob-TLC-OOBClassifiers: OLM:849 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0 X-Microsoft-Antispam-Message-Info: sJiH5EBNOAEGd1FvvWfezd/OnEwVyopQ+pc+LWlw5W1Trwhh6rltYG7ZVhroYLSwe8LCqpiu9O9Rg6kB46NuEYmNJMIPTP0SAQNuIn3if9SxQc/3eE7++DA4FIW7GTIlxwASxhvzHxv/sEVvkTG+YCxhlxeWcYVBQO9BKCbadB904vcStYFMVl3bOJK4fQu3Zm6jIfvqXjzpM/G5rwWadEzSJfFtn6K39Fg7P9hIORu4ETyJ3JM3MgR6mSQG7DAvYCjcAlUBX4bk6a4L8sxehHGj2pHbbFU+/XXilDh9VpZ6+mUiKhb6RRPnUER8OBlBYVqp8wIJSOSselCFhmHsWM47kku8dI85i0/0O+75wHLlzDFYNG2ZjVCiR4Y8VvY2m5xRtJWzG7b5gef+x54BCNoLn0Dd+HbYCTY2txfmqAPFGIjYHN3JYKcE7v9eyZKoubktA6qe3JNcM3XmUD1OMvWCGhJGwlfme1/kFz50bR/mAyJjUyCn+4+WV6Gtgjfs51IlugOYgkwATgpoHJsNVwR/EH8miho6xgulyNEXD/eNa6nDO7P906JapAHwEy+yC6CX2ERl5+jlBoUt0r3LHyux+rIY9gW1H/y6kEXK/ro8Ktvo4k54tv4G5LKWT+/kfNgiiT9SXnsSI7Y22MfLwNw7YbaJQY7HrY8qelDDMFB3I2/VBC9aEzd3HVacOgJntmHRLoauvenOqA6+e9XTXQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR02MB7775.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(8676002)(6486002)(2906002)(6512007)(8936002)(5660300002)(1076003)(36756003)(508600001)(2616005)(66556008)(4326008)(107886003)(86362001)(83380400001)(38100700002)(52116002)(38350700002)(186003)(26005)(6916009)(44832011)(6506007)(6666004)(66476007)(66946007)(316002); DIR:OUT; SFP:1102 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?BxgYNzw6lSRldZ3LKKg93Brt4b/6krFiaN62VjFwRLbBQtNgvklGaN7Eg0Kq?= =?us-ascii?Q?nKqMbwUrzBRAqx/jrToXN1Ec4WYrrjUHeq6aJ0f8Iy8u7klC/JmD0FRLup8o?= =?us-ascii?Q?XuW7xsUVJnBz1FLxMCl8qESY4b8psswG9a+sXEDN8kT6iGyVzw4DImSUuaIv?= =?us-ascii?Q?yfWwnErXDISM2hFfgJSLz6OxLljSKXuNmIhVeRrVI/eCS1nWR8xjDOGniCl3?= =?us-ascii?Q?rED4NhrlPkahz8w3Q4bXeqPqyLHmZwB5+R3bDZYrpz1wnk76C6PSQjTqA+Nl?= =?us-ascii?Q?/mjx9rjTeI+nE0Bj7+v5Y4TwHXRgwCxltfcklPT8jZv9hIUyvx2jBHARe7Pf?= =?us-ascii?Q?/W23bqCh5Sc1o092JQqR7tn5udodtzeMc+o+J9Zcqt7Fn2pY8pkep5WwuNSN?= =?us-ascii?Q?nMnIiGjbfrQVECQNAXCrXRtqdQOgikNLuJcSOBV3hhSa/xOb3iE+Bvazz62l?= =?us-ascii?Q?3PnHYqX9pTV0yZFfuCLK6DnVMjDJAJZSDqNJOq+46zJD+SvAubn+84/goU2v?= =?us-ascii?Q?sK8+RH/8FXez24ZO6SlEBd5xAolA2DeVNw/s1V3c5Ak2jrljLsv6bVwpfOLB?= =?us-ascii?Q?S6BmRwarcnHqVuxkMCD7PyLbuY7vOQ7DA6MZxiVycz356PE496ttJGKO3ELI?= =?us-ascii?Q?tBbX1ec5Kf6/XyIVz0SzcDlV7H8JjhltNGl7t1pfGX3t8OnNMWboAc8q3ZrS?= =?us-ascii?Q?8IALew0T9rbibKHx1nY/2GxxtqcaOsteHJ6GfIOZFcIf0fHXYPmERIpy1Cyt?= =?us-ascii?Q?/rtq+fGHJZ5CN16zP5fDXUcm3ey0ayua5cQu8i1EBg94OsZ5hgtPHNCSQVj6?= =?us-ascii?Q?oShhEfOEaX4rSZbY57qa06mwWlL5zvJwnEcFfItt4qq/liS9eABhmMPWty7R?= =?us-ascii?Q?xDtYifhFex7zUYdvIlFhgb2KT6BE0Vr019uTYdCA8lmi2CuttDh8AmnVZvXb?= =?us-ascii?Q?IVqZuxLSQUxB2l/OEY6c5JrehGHOnvRYHts0KX5XgVCWDs15ECEXUMPviEN2?= =?us-ascii?Q?h2sCqCyAchp/m789dYl5Hw+NNHETC7yYwJBJBfC2ONLVMflXb0P7Xf3CXK5i?= =?us-ascii?Q?L2sVpu3jYU38TQJ9URtq9QkFD9QsvBSuUrHF9HGUqkX3Y+tk8o7YxSlBWQJS?= =?us-ascii?Q?5atjxHTJYEct5nwD1RNsl4CplUxOGMRSPGRGnALHcfZ3sNjVMMIwY7BzPRV6?= =?us-ascii?Q?KmpaJI0O16gECL0HfM4bJyiEPk/nKw8xPYdMQkHKJBMh59lgy5SrrjN+C5em?= =?us-ascii?Q?pNJ+A7j/HVn8EflAdtj0YqmvLUaKlUg0+IeiCdMT2UoxPs2HNEazedOOlviH?= =?us-ascii?Q?s15k9ToINiyaXDD5KEx+MU5Jk8syuyhQFiPTZzT0rF1Opql8K8y1p5Cj5nux?= =?us-ascii?Q?abwwkZg8qKOStK784UbszDXO4n7pqokWmr0hjpFvPn0TbPafaY3KV6ICQbi6?= =?us-ascii?Q?FSA/0hAu82FJGDmG77KSKc0VPrwWzt3YaGX3LGhfuJiVwJowaQkSZhSXGsN1?= =?us-ascii?Q?//tOW1zRbI4eWZYBuQxCl1X4DnOvwxtTGi2/XfdEe/mTt0zeWOPrYkZWwtz+?= =?us-ascii?Q?2dIiS3sRoiFf6HsmtS/JhK1TUJLy3dc6LvrCxk0RY4lR0bB3UQDWZNRD5VbG?= =?us-ascii?Q?i7WUlAqORs6qdBpMahFgUkQ=3D?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 09db0f72-6bde-40e1-8556-08d9d6671161 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR02MB7775.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jan 2022 07:34:01.2777 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rMBybzdO16Gm1EFZTpmXawV18FIK/KUuLp3AJDG6yJLAWE/AGp3tcSqGuDiZpSDlkc/Ufk6/q03aYyvHm81mWg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR02MB8171 X-Proofpoint-ORIG-GUID: AlG1vUNCiFmVYcHwb6x6KS_uds_KmpmC X-Proofpoint-GUID: AlG1vUNCiFmVYcHwb6x6KS_uds_KmpmC X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205, Aquarius:18.0.790, Hydra:6.0.425, FMLib:17.11.62.513 definitions=2022-01-13_02,2022-01-11_01,2021-12-02_01 X-Proofpoint-Spam-Reason: safe X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-loop: libvir-list@redhat.com Cc: pkrempa@redhat.com, prerna.saxena@nutanix.com, john.levon@nutanix.com, ani@anisinha.ca, Divya Garg X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1642059292852100001 Content-Type: text/plain; charset="utf-8" This commit takes care of following cases: -> Check availability of requested ports. ->The total number of requested ports should not be more than VIR_MAX_ISA_SERIAL_PORTS. ->The ports requested should be less than VIR_MAX_ISA_SERIAL_PORTS. ->VIR_MAX_ISA_SERIAL_PORTS should correspond to MAX_ISA_SERIAL_PORTS specified in qemu code commit def337ffda34d331404bd7f1a42726b71500df22. -> Prevent duplicate device assignments to the same port. -> In case no ports are provided in the XML, this patch scans the list of u= nused isa-serial indices to automatically assign available ports for this VM. Signed-off-by: Divya Garg --- src/conf/domain_conf.c | 61 ++++++++++++++++--- src/conf/domain_conf.h | 6 ++ ...g-console-compat-2-live+console-virtio.xml | 4 +- .../qemuhotplug-console-compat-2-live.xml | 4 +- .../serial-tcp-tlsx509-chardev-notls.xml | 2 +- .../serial-tcp-tlsx509-chardev-verify.xml | 2 +- .../serial-tcp-tlsx509-chardev.xml | 2 +- .../serial-tcp-tlsx509-secret-chardev.xml | 2 +- .../serial-tcp-tlsx509-chardev.xml | 2 +- 9 files changed, 68 insertions(+), 17 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 5691b8d2d5..e468e98045 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -5330,6 +5330,56 @@ virDomainHostdevDefPostParse(virDomainHostdevDef *de= v, } =20 =20 +static int +virDomainChrIsaSerialDefPostParse(virDomainDef *def) +{ + size_t i, j; + size_t isa_serial_count =3D 0; + bool used_serial_port[VIR_MAX_ISA_SERIAL_PORTS] =3D {false}; + + /* Perform all the required checks. */ + for (i =3D 0; i < def->nserials; i++) { + + if (def->serials[i]->targetType !=3D + VIR_DOMAIN_CHR_SERIAL_TARGET_MODEL_ISA_SERIAL) + continue; + + if (isa_serial_count++ >=3D VIR_MAX_ISA_SERIAL_PORTS || + def->serials[i]->target.port >=3D VIR_MAX_ISA_SERIAL_PORTS) { + virReportError(VIR_ERR_INTERNAL_ERROR, + _("Maximum supported number of ISA serial ports= is '%d'."), VIR_MAX_ISA_SERIAL_PORTS); + return -1; + } + + if (def->serials[i]->target.port !=3D -1) { + if (used_serial_port[def->serials[i]->target.port]) { + virReportError(VIR_ERR_INTERNAL_ERROR, + _("target port '%d' already allocated."), d= ef->serials[i]->target.port); + return -1; + } + used_serial_port[def->serials[i]->target.port] =3D true; + } + } + + /* Assign the ports to the devices. */ + for (i =3D 0; i < def->nserials; i++) { + + if (def->serials[i]->targetType !=3D + VIR_DOMAIN_CHR_SERIAL_TARGET_MODEL_ISA_SERIAL || + def->serials[i]->target.port !=3D -1) + continue; + + for (j =3D 0; j < VIR_MAX_ISA_SERIAL_PORTS; j++) { + if (!used_serial_port[j]) { + def->serials[i]->target.port =3D j; + used_serial_port[j] =3D true; + break; + } + } + } + return 0; +} + static void virDomainChrDefPostParse(virDomainChrDef *chr, const virDomainDef *def) @@ -6197,6 +6247,9 @@ virDomainDefPostParse(virDomainDef *def, goto cleanup; } =20 + if (virDomainChrIsaSerialDefPostParse(def) < 0) + return -1; + /* iterate the devices */ ret =3D virDomainDeviceInfoIterateFlags(def, virDomainDefPostParseDeviceItera= tor, @@ -19929,14 +19982,6 @@ virDomainDefParseXML(xmlXPathContextPtr ctxt, if (!chr) return NULL; =20 - if (chr->target.port =3D=3D -1) { - int maxport =3D -1; - for (j =3D 0; j < i; j++) { - if (def->serials[j]->target.port > maxport) - maxport =3D def->serials[j]->target.port; - } - chr->target.port =3D maxport + 1; - } def->serials[def->nserials++] =3D chr; } VIR_FREE(nodes); diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index 144ba4dd12..a8f41dc8c2 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -1187,6 +1187,12 @@ typedef enum { VIR_DOMAIN_CHR_CONSOLE_TARGET_TYPE_LAST } virDomainChrConsoleTargetType; =20 +/* + * The value of VIR_MAX_ISA_SERIAL_PORTS corresponds to MAX_ISA_SERIAL_POR= TS + * set in qemu code base. + */ +#define VIR_MAX_ISA_SERIAL_PORTS 4 + typedef enum { VIR_DOMAIN_CHR_SERIAL_TARGET_MODEL_NONE =3D 0, VIR_DOMAIN_CHR_SERIAL_TARGET_MODEL_ISA_SERIAL, diff --git a/tests/qemuhotplugtestdomains/qemuhotplug-console-compat-2-live= +console-virtio.xml b/tests/qemuhotplugtestdomains/qemuhotplug-console-comp= at-2-live+console-virtio.xml index 38311b188c..72516555a0 100644 --- a/tests/qemuhotplugtestdomains/qemuhotplug-console-compat-2-live+consol= e-virtio.xml +++ b/tests/qemuhotplugtestdomains/qemuhotplug-console-compat-2-live+consol= e-virtio.xml @@ -74,7 +74,7 @@ - + @@ -82,7 +82,7 @@ - + diff --git a/tests/qemuhotplugtestdomains/qemuhotplug-console-compat-2-live= .xml b/tests/qemuhotplugtestdomains/qemuhotplug-console-compat-2-live.xml index 3fe205430c..6197a2bfe3 100644 --- a/tests/qemuhotplugtestdomains/qemuhotplug-console-compat-2-live.xml +++ b/tests/qemuhotplugtestdomains/qemuhotplug-console-compat-2-live.xml @@ -74,7 +74,7 @@ - + @@ -82,7 +82,7 @@ - + diff --git a/tests/qemuxml2argvdata/serial-tcp-tlsx509-chardev-notls.xml b/= tests/qemuxml2argvdata/serial-tcp-tlsx509-chardev-notls.xml index f27b119270..16734d9cce 100644 --- a/tests/qemuxml2argvdata/serial-tcp-tlsx509-chardev-notls.xml +++ b/tests/qemuxml2argvdata/serial-tcp-tlsx509-chardev-notls.xml @@ -37,7 +37,7 @@ - + diff --git a/tests/qemuxml2argvdata/serial-tcp-tlsx509-chardev-verify.xml b= /tests/qemuxml2argvdata/serial-tcp-tlsx509-chardev-verify.xml index be58ccc1da..15ce29c67d 100644 --- a/tests/qemuxml2argvdata/serial-tcp-tlsx509-chardev-verify.xml +++ b/tests/qemuxml2argvdata/serial-tcp-tlsx509-chardev-verify.xml @@ -29,7 +29,7 @@ - + diff --git a/tests/qemuxml2argvdata/serial-tcp-tlsx509-chardev.xml b/tests/= qemuxml2argvdata/serial-tcp-tlsx509-chardev.xml index be58ccc1da..15ce29c67d 100644 --- a/tests/qemuxml2argvdata/serial-tcp-tlsx509-chardev.xml +++ b/tests/qemuxml2argvdata/serial-tcp-tlsx509-chardev.xml @@ -29,7 +29,7 @@ - + diff --git a/tests/qemuxml2argvdata/serial-tcp-tlsx509-secret-chardev.xml b= /tests/qemuxml2argvdata/serial-tcp-tlsx509-secret-chardev.xml index 8e44dea365..8bb7cbefae 100644 --- a/tests/qemuxml2argvdata/serial-tcp-tlsx509-secret-chardev.xml +++ b/tests/qemuxml2argvdata/serial-tcp-tlsx509-secret-chardev.xml @@ -34,7 +34,7 @@ - + diff --git a/tests/qemuxml2xmloutdata/serial-tcp-tlsx509-chardev.xml b/test= s/qemuxml2xmloutdata/serial-tcp-tlsx509-chardev.xml index aefd3513ce..4cdefed63d 100644 --- a/tests/qemuxml2xmloutdata/serial-tcp-tlsx509-chardev.xml +++ b/tests/qemuxml2xmloutdata/serial-tcp-tlsx509-chardev.xml @@ -37,7 +37,7 @@ - + --=20 2.25.1