[libvirt PATCH 00/14] Random fixes and improvements

Tim Wiederhake posted 14 patches 2 weeks, 1 day ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20220112131015.100288-1-twiederh@redhat.com
docs/coding-style.rst        |   5 +
src/conf/interface_conf.c    | 357 ++++++++++++-----------------------
src/qemu/qemu_capabilities.c |   4 +-
3 files changed, 128 insertions(+), 238 deletions(-)

[libvirt PATCH 00/14] Random fixes and improvements

Posted by Tim Wiederhake 2 weeks, 1 day ago
A collection of drive-by fixes and improvements that quickly derailed
into the g_auto-ification of src/conf/interface_conf.c.

Tim Wiederhake (14):
  docs: coding-style: Clarify on virXXXPtr types
  virQEMUCapsSEVInfoCopy: Remove superfluous g_auto usage
  virInterfaceDefDevFormat: Add missing error handling
  conf: interface: Preparation for g_auto
  conf: interface: Use g_auto
  conf: interface: Remove ret and goto
  virInterfaceDefParseXML: Inline trivial virInterfaceDefParseName
  virInterfaceDefParseIP: Simplify and cleanup
  virInterfaceDefParseDhcp: Simplify and cleanup
  virInterfaceDefParseProtoIPv4: Simplify and cleanup
  virInterfaceDefParseProtoIPv6: Simplify and cleanup
  virInterfaceDefParseIfAdressing: Simplify and cleanup
  virInterfaceDefParseXML: Simplify and cleanup
  virInterfaceDefParse: Simplify and cleanup

 docs/coding-style.rst        |   5 +
 src/conf/interface_conf.c    | 357 ++++++++++++-----------------------
 src/qemu/qemu_capabilities.c |   4 +-
 3 files changed, 128 insertions(+), 238 deletions(-)

-- 
2.31.1


Re: [libvirt PATCH 00/14] Random fixes and improvements

Posted by Michal Prívozník 2 weeks, 1 day ago
On 1/12/22 14:10, Tim Wiederhake wrote:
> A collection of drive-by fixes and improvements that quickly derailed
> into the g_auto-ification of src/conf/interface_conf.c.
> 
> Tim Wiederhake (14):
>   docs: coding-style: Clarify on virXXXPtr types
>   virQEMUCapsSEVInfoCopy: Remove superfluous g_auto usage
>   virInterfaceDefDevFormat: Add missing error handling
>   conf: interface: Preparation for g_auto
>   conf: interface: Use g_auto
>   conf: interface: Remove ret and goto
>   virInterfaceDefParseXML: Inline trivial virInterfaceDefParseName
>   virInterfaceDefParseIP: Simplify and cleanup
>   virInterfaceDefParseDhcp: Simplify and cleanup
>   virInterfaceDefParseProtoIPv4: Simplify and cleanup
>   virInterfaceDefParseProtoIPv6: Simplify and cleanup
>   virInterfaceDefParseIfAdressing: Simplify and cleanup
>   virInterfaceDefParseXML: Simplify and cleanup
>   virInterfaceDefParse: Simplify and cleanup
> 
>  docs/coding-style.rst        |   5 +
>  src/conf/interface_conf.c    | 357 ++++++++++++-----------------------
>  src/qemu/qemu_capabilities.c |   4 +-
>  3 files changed, 128 insertions(+), 238 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal

Re: [libvirt PATCH 00/14] Random fixes and improvements

Posted by Tim Wiederhake 2 weeks ago
On Wed, 2022-01-12 at 15:36 +0100, Michal Prívozník wrote:
> On 1/12/22 14:10, Tim Wiederhake wrote:
> > A collection of drive-by fixes and improvements that quickly
> > derailed
> > into the g_auto-ification of src/conf/interface_conf.c.
> > 
> > Tim Wiederhake (14):
> >   docs: coding-style: Clarify on virXXXPtr types
> >   virQEMUCapsSEVInfoCopy: Remove superfluous g_auto usage
> >   virInterfaceDefDevFormat: Add missing error handling
> >   conf: interface: Preparation for g_auto
> >   conf: interface: Use g_auto
> >   conf: interface: Remove ret and goto
> >   virInterfaceDefParseXML: Inline trivial virInterfaceDefParseName
> >   virInterfaceDefParseIP: Simplify and cleanup
> >   virInterfaceDefParseDhcp: Simplify and cleanup
> >   virInterfaceDefParseProtoIPv4: Simplify and cleanup
> >   virInterfaceDefParseProtoIPv6: Simplify and cleanup
> >   virInterfaceDefParseIfAdressing: Simplify and cleanup
> >   virInterfaceDefParseXML: Simplify and cleanup
> >   virInterfaceDefParse: Simplify and cleanup
> > 
> >  docs/coding-style.rst        |   5 +
> >  src/conf/interface_conf.c    | 357 ++++++++++++-------------------
> > ----
> >  src/qemu/qemu_capabilities.c |   4 +-
> >  3 files changed, 128 insertions(+), 238 deletions(-)
> > 
> 
> Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
> 
> Michal
> 
Thanks! I will drop patches 1 and 2 from the series for now: I want to
rewrite #2 entirely and have additional changes for #1.

Tim