From nobody Tue Feb 10 19:15:08 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1641064088; cv=none; d=zohomail.com; s=zohoarc; b=URuHT5Cdd1ZwQyWUYBgiXaiZplkqe9z10h6BXXWvMwA4C9IkhhfRc71sNbkPlpzx0TNLYEIdwxKV9dfbRF1ZaXLW5JMyOz2STRe6ljxLCh6o4fo8XBpjrc1yubx5OGkBuulXp8yZ280yfC0rJZm2s/8simXjk0OYLfZFFD3zjZE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1641064088; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=mMyLNWS7GgjiLYaFWOAgcCLIyRANpiBPkl+oAwkwTpg=; b=MeHoAUdwKGKOXOCSbHCHRcu1xF9bW5ScQ8U1nFgd4VScFSDFwLKkuPfl+hbktQv212zcztsG/NHZAvSYnhF9OmC4FNu/A1+F0VJymErfiEp2fcPCy0RXEsFrWBKoyZ7vmE4m5kEYgn3tuGf6nwWQoNZjvY8hTZiT2Hj+M93FgyE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1641064088246100.30763676964045; Sat, 1 Jan 2022 11:08:08 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-187-WFStNry0MXeR6ONNxW3_-g-1; Sat, 01 Jan 2022 14:08:06 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DBA132F24; Sat, 1 Jan 2022 19:08:00 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BB085604CC; Sat, 1 Jan 2022 19:08:00 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 75C884CA93; Sat, 1 Jan 2022 19:08:00 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 201J7cqk014009 for ; Sat, 1 Jan 2022 14:07:38 -0500 Received: by smtp.corp.redhat.com (Postfix) id D499760C17; Sat, 1 Jan 2022 19:07:38 +0000 (UTC) Received: from kinshicho.usersys.redhat.com (unknown [10.40.192.34]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E5C5660C81 for ; Sat, 1 Jan 2022 19:07:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1641064087; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=mMyLNWS7GgjiLYaFWOAgcCLIyRANpiBPkl+oAwkwTpg=; b=V3leeNzb9X2wR2FZBiI9sVjorH5VQwowfgWa6/pWRum7mcZMyppNe6C8x8ssydUGWRsV0n +HxBIdmzPQhobaMVZ75t69Wa+Qdb2/D+ZUlpqdjgBKHVcnPze48Bwkt8VxNUvSWsJt0tlm 3Z65R4wytkEhzQRofoaXADagCjBL7JA= X-MC-Unique: WFStNry0MXeR6ONNxW3_-g-1 From: Andrea Bolognani To: libvir-list@redhat.com Subject: [libvirt PATCH 1/3] tests: virtimetest: Move comment Date: Sat, 1 Jan 2022 20:07:24 +0100 Message-Id: <20220101190726.30178-2-abologna@redhat.com> In-Reply-To: <20220101190726.30178-1-abologna@redhat.com> References: <20220101190726.30178-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1641064090249000001 Content-Type: text/plain; charset="utf-8" Will keep things reasonable as we perform further code movements. Signed-off-by: Andrea Bolognani --- tests/virtimetest.c | 23 +++++++++++------------ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/tests/virtimetest.c b/tests/virtimetest.c index 5736245722..fffd189612 100644 --- a/tests/virtimetest.c +++ b/tests/virtimetest.c @@ -197,19 +197,18 @@ mymain(void) TEST_LOCALOFFSET("VIR-12:00VID-13:00,1/00:00:00,364/23:59:59", ((13 * 60) + 0) * 60); =20 + /* experiments have shown that the following tests will fail + * during certain hours of Dec 31 or Jan 1 (depending on the + * TZ setting in the shell running the test, but in general + * for a period that apparently starts at 00:00:00 UTC Jan 1 + * and continues for 1 - 2 hours). We've determined this is + * due to our inability to specify a timezone with DST on/off + * settings that make it truly *always* on DST - i.e. it is a + * failing of the test data, *not* of the function we are + * testing. So to test as much as possible, we still run these + * tests, except on Dec 31 and Jan 1. + */ if (!isNearYearEnd()) { - /* experiments have shown that the following tests will fail - * during certain hours of Dec 31 or Jan 1 (depending on the - * TZ setting in the shell running the test, but in general - * for a period that apparently starts at 00:00:00 UTC Jan 1 - * and continues for 1 - 2 hours). We've determined this is - * due to our inability to specify a timezone with DST on/off - * settings that make it truly *always* on DST - i.e. it is a - * failing of the test data, *not* of the function we are - * testing. So to test as much as possible, we still run these - * tests, except on Dec 31 and Jan 1. - */ - TEST_LOCALOFFSET("VIR02:45VID00:45,1/00:00:00,364/23:59:59", -45 * 60); TEST_LOCALOFFSET("VIR05:00VID04:00,1/00:00:00,364/23:59:59", --=20 2.31.1