[libvirt PATCH] spec: Demote netcat to Recommends

Andrea Bolognani posted 1 patch 2 years, 3 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20211224102358.288122-1-abologna@redhat.com
libvirt.spec.in | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
[libvirt PATCH] spec: Demote netcat to Recommends
Posted by Andrea Bolognani 2 years, 3 months ago
It is only needed if compatibility with clients using libvirt
6.9.0 is required, and can be uninstalled otherwise.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 libvirt.spec.in | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/libvirt.spec.in b/libvirt.spec.in
index 7bd74da2c9..0180b4200c 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -402,8 +402,12 @@ Summary: Server side daemon and supporting files for libvirt library
 # The client side, i.e. shared libs are in a subpackage
 Requires: %{name}-libs = %{version}-%{release}
 
-# (client invokes 'nc' against the UNIX socket on the server)
-Requires: /usr/bin/nc
+# netcat is needed on the server side so that clients that have
+# libvirt < 6.9.0 can connect, but newer versions will prefer
+# virt-ssh-helper. Making this a Recommends means that it gets
+# installed by default, but can still be removed if compatibility
+# with old clients is not required
+Recommends: /usr/bin/nc
 
 # for modprobe of pci devices
 Requires: module-init-tools
-- 
2.31.1

Re: [libvirt PATCH] spec: Demote netcat to Recommends
Posted by Martin Kletzander 2 years, 3 months ago
On Fri, Dec 24, 2021 at 11:23:58AM +0100, Andrea Bolognani wrote:
>It is only needed if compatibility with clients using libvirt
>6.9.0 is required, and can be uninstalled otherwise.
>
>Signed-off-by: Andrea Bolognani <abologna@redhat.com>

Reviewed-by: Martin Kletzander <mkletzan@redhat.com>

>---
> libvirt.spec.in | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
>diff --git a/libvirt.spec.in b/libvirt.spec.in
>index 7bd74da2c9..0180b4200c 100644
>--- a/libvirt.spec.in
>+++ b/libvirt.spec.in
>@@ -402,8 +402,12 @@ Summary: Server side daemon and supporting files for libvirt library
> # The client side, i.e. shared libs are in a subpackage
> Requires: %{name}-libs = %{version}-%{release}
>
>-# (client invokes 'nc' against the UNIX socket on the server)
>-Requires: /usr/bin/nc
>+# netcat is needed on the server side so that clients that have
>+# libvirt < 6.9.0 can connect, but newer versions will prefer
>+# virt-ssh-helper. Making this a Recommends means that it gets
>+# installed by default, but can still be removed if compatibility
>+# with old clients is not required
>+Recommends: /usr/bin/nc
>
> # for modprobe of pci devices
> Requires: module-init-tools
>-- 
>2.31.1
>