From nobody Mon May 6 16:45:15 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1639182487; cv=none; d=zohomail.com; s=zohoarc; b=b4A8TIHRtHyUKHT7wPg82lRbvQkqSBtlfCd7u5q30aNhZ0hKRUSeg9lMPx5q/iVi9+t5v9KKN6MGFC+rNfK0FdHhhxTR5aSZ8OY77l4KcjvgqFGKCV0BBrMFyB6omzneA2TUaSQz1V00yF4TiNjueJ1tfLQTaaa6ibHGHZdFapc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1639182487; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=nyz50Cjb6YcjdmSJwJHI1awPJKbek7fQJZZWA6f2Csg=; b=gT19YQO2j1hLiIJmiJhsQ01sGCjHu5Sc1kYm7DE6bKp6wAsKXnmofWvss9l9KuZtUUrx3D8IKy2g+r5C/E6K4j7iPHcD0b5nV03wImymcjf/Ul/dLn3LGkY+YVDlWZ/SGFFH9s/Z0pR31ELpEEW9UOthkUR212gONuTxNabh3Qc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1639182487481100.53261935151613; Fri, 10 Dec 2021 16:28:07 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-200-9sKnDZWfNAu5HjJ7afB5SA-1; Fri, 10 Dec 2021 19:28:05 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 03A561808320; Sat, 11 Dec 2021 00:28:00 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 38E4110016FE; Sat, 11 Dec 2021 00:27:56 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 007A51809C88; Sat, 11 Dec 2021 00:27:50 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1BB0RQTE025051 for ; Fri, 10 Dec 2021 19:27:26 -0500 Received: by smtp.corp.redhat.com (Postfix) id A882110016FE; Sat, 11 Dec 2021 00:27:26 +0000 (UTC) Received: from kinshicho.usersys.redhat.com (unknown [10.40.192.13]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F2E9810074FD for ; Sat, 11 Dec 2021 00:27:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1639182486; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=nyz50Cjb6YcjdmSJwJHI1awPJKbek7fQJZZWA6f2Csg=; b=N1L2ZpxpE4BzPK9cn8C2/IMrs2PoScZtzmTm1/Ol1rNp6OpO5bkmn9G/tcBIHdH1D+L6Nx +rHRqeacAysJBJnJApECVS2Bhj3y4e7PyUDVF9TNZ8Ihu7b+ufuGFbBZ0ny2QYsFExkfM4 CUdeJul5U83/vpfwqZ7y1S6bIfV6h/w= X-MC-Unique: 9sKnDZWfNAu5HjJ7afB5SA-1 From: Andrea Bolognani To: libvir-list@redhat.com Subject: [libvirt PATCH] nss: Use shared_library() for nss_libvirt_lib Date: Sat, 11 Dec 2021 01:27:20 +0100 Message-Id: <20211211002720.18735-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1639182488538100001 Content-Type: text/plain; charset="utf-8" shared_module() is intended for shared objects that are loaded at runtime using dlopen() whereas NSS plugins need to be full-fledged shared libraries with, among other things, a proper SONAME. Meson seems to have become more strict about this recently, because libnss_libvirt.so.2 gets a SONAME when I build it with Meson 0.59.4 on Fedora 34 but doesn't when I use Meson 0.60.2 on Debian testing instead. Either way, shared_library() was always the right function to use for NSS plugins. Fixes: 36780c931900555706fd6db9fc2ce2b4cabf9045 Signed-off-by: Andrea Bolognani Reviewed-by: Michal Privoznik --- tools/nss/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/nss/meson.build b/tools/nss/meson.build index 198936f3d4..f77309ebca 100644 --- a/tools/nss/meson.build +++ b/tools/nss/meson.build @@ -59,7 +59,7 @@ nss_libvirt_guest_syms =3D '@0@@1@'.format( meson.current_source_dir() / nss_guest_sym_file, ) =20 -nss_libvirt_lib =3D shared_module( +nss_libvirt_lib =3D shared_library( 'nss_libvirt', name_prefix: nss_prefix, name_suffix: 'so.@0@'.format(nss_so_ver), --=20 2.31.1