From nobody Sun May 5 19:34:35 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=nutanix.com Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1638886429062466.80087435779876; Tue, 7 Dec 2021 06:13:49 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-274-EffVW9GHPqiqx5vxB50KZQ-1; Tue, 07 Dec 2021 09:13:46 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 764D9801B35; Tue, 7 Dec 2021 14:13:41 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 379031002390; Tue, 7 Dec 2021 14:13:40 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id DCA914BB7B; Tue, 7 Dec 2021 14:13:36 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1B7DYKlQ011362 for ; Tue, 7 Dec 2021 08:34:20 -0500 Received: by smtp.corp.redhat.com (Postfix) id 47376C08096; Tue, 7 Dec 2021 13:34:20 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast01.extmail.prod.ext.rdu2.redhat.com [10.11.55.17]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4179BC15E74 for ; Tue, 7 Dec 2021 13:34:20 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 23786857FAD for ; Tue, 7 Dec 2021 13:34:20 +0000 (UTC) Received: from mx0b-002c1b01.pphosted.com (mx0b-002c1b01.pphosted.com [148.163.155.12]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-384-daRk4xgAMZuQGoSErIjhlQ-1; Tue, 07 Dec 2021 08:34:18 -0500 Received: from pps.filterd (m0127843.ppops.net [127.0.0.1]) by mx0b-002c1b01.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 1B7Awcvk006842 for ; Tue, 7 Dec 2021 05:34:18 -0800 Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2105.outbound.protection.outlook.com [104.47.70.105]) by mx0b-002c1b01.pphosted.com (PPS) with ESMTPS id 3csxck15em-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 07 Dec 2021 05:34:17 -0800 Received: from SJ0PR02MB8564.namprd02.prod.outlook.com (2603:10b6:a03:3f6::16) by BY5PR02MB6179.namprd02.prod.outlook.com (2603:10b6:a03:1fa::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.11; Tue, 7 Dec 2021 13:34:16 +0000 Received: from SJ0PR02MB8564.namprd02.prod.outlook.com ([fe80::5916:1188:53ed:2065]) by SJ0PR02MB8564.namprd02.prod.outlook.com ([fe80::5916:1188:53ed:2065%2]) with mapi id 15.20.4755.022; Tue, 7 Dec 2021 13:34:16 +0000 Received: from nutanix-AHV.eng.nutanix.com (192.146.154.240) by SJ0PR05CA0061.namprd05.prod.outlook.com (2603:10b6:a03:332::6) with Microsoft SMTP Server (version=TLS1_2, cipher=) via Frontend Transport; Tue, 7 Dec 2021 13:34:15 +0000 X-MC-Unique: EffVW9GHPqiqx5vxB50KZQ-1 X-MC-Unique: daRk4xgAMZuQGoSErIjhlQ-1 From: Rohit Kumar To: libvir-list@redhat.com Subject: [PATCH] Add VM info to improve error log message for qemu monitor Date: Tue, 7 Dec 2021 05:34:00 -0800 Message-Id: <20211207133400.273903-1-rohit.kumar3@nutanix.com> X-ClientProxiedBy: SJ0PR05CA0061.namprd05.prod.outlook.com (2603:10b6:a03:332::6) To SJ0PR02MB8564.namprd02.prod.outlook.com (2603:10b6:a03:3f6::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f2062e94-050c-4ac8-86ba-08d9b9864369 X-MS-TrafficTypeDiagnostic: BY5PR02MB6179:EE_ X-Microsoft-Antispam-PRVS: x-proofpoint-crosstenant: true X-MS-Oob-TLC-OOBClassifiers: OLM:597 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0 X-Microsoft-Antispam-Message-Info: 2tBs9+nIDpfnZZy1+FtZrnlYc4k641Nt7aZMTqSxHPpEcpsFmHvQayTbuvuZ+fUZWkbMdEzo1X9CrfMEqgZHowU51btruGi9J6DbB2A/Q91favePdKiGFQbijOhVEhuW983ZUQqrClL7BePJPZuoJnqR00UwK4ReMNuFZf0CDmVMdfKGqJMc7cAl357nNN2nwlH50nm0VmR09Qj2rF84rpNaHMZf0o9Q7G8MpWHuVavLSEjwsifsk/JTrys7EXwX+LDq9r85Uvyk6F/4bcs2icwOyDMOfzapwBw8ZZBklP4sDrRvgUWgpu48ENPITGJPjpxLEZvbM9WA30bl+S/zfFKucztOYwabYsfeKOaz4PCpSRkKSMlqos5Wau/eSR2IlGdppwSJSN9Kni187zAyIa5KSUOFLG8SA/cBFxw3My6SvLGN5GFiGcSFxzoC+QR6wPk9W9qCNffvvqe1ekIljuimar5Deast/epyihu+I8BBed+q1VtlX45mrvx3fhiLx5TSlAERbpnle1y3nm7bjDLsNEAI6BDl/yuAaFqL+OiM+X++Y2+mHPRgavcLmU1lyAvS50OqiBQE5zIxmPfZVOGPNZEsUe2KlFNlIrXHPK5Xd7RjTEhZ7gJvJJBGo1V2DCxQFyY+r5/wMBBJED6tVEDSfFfiN6T16gySk01/TnldgINVwDLiUJ1yDtVP0hZEIINXiYEjoLQb7rFeW0Xxqg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR02MB8564.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(36756003)(8936002)(186003)(2906002)(508600001)(66476007)(8676002)(1076003)(38350700002)(956004)(2616005)(15650500001)(38100700002)(6916009)(6486002)(6666004)(66556008)(66946007)(83380400001)(52116002)(5660300002)(26005)(316002)(86362001)(4326008)(7696005)(107886003); DIR:OUT; SFP:1102 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ngJhQX+EQSc3nrY//uJ5RB0xaEGyhx5L03l+99nGsI7ixwOid6PlRwPzV4rK?= =?us-ascii?Q?u2NfzfF1ITXoEfA8DDOY4uL0lAgoed94UZiNwqF55oCw4dXTo4EC4lbBPfMX?= =?us-ascii?Q?E5pjwFvWh04r/AzL42vjVj559De/v35Ij4WZXjnUWOLC1VISaEsbMocS8ASR?= =?us-ascii?Q?aCyuJt9tuaLt62q7TSJaplaD2Fe5CPl3DwOM0QMvRjS2AdikLMyQwq1GhjjX?= =?us-ascii?Q?tAXhmBDiSKhDC0sdq4GUNUQaNsXQVhpBHD732x9eqR8gk58QsLmS9zO7t/P5?= =?us-ascii?Q?QA+ZVKrvApetAzx+Lw2lJxIHjcnO3j57+2cUjFNqekkpi+642yFQ933Xvpr/?= =?us-ascii?Q?Ur0yArVWAPbG1vmVqipNr+lsILOT0hCbly/cDfbKB9j+TEIdPpLbT/mEm8zS?= =?us-ascii?Q?bt1wvYMBlfTwU5LPlU79S01RNzBJc7Glg9kuYv055vKm+lbyr4h36n7eEi4B?= =?us-ascii?Q?ZLeFI9bhQKG+c9uK52OAA+z9HmIsT29CjKw5x7EPRHpAV1V/PVIj+uag7aNp?= =?us-ascii?Q?bAnOX58P9zwi4SssTEuov/+cpojdhvSQa2Ta4Brb+dnsalvV0FEu4p8hBIHU?= =?us-ascii?Q?MWl/mPL+nZorQpC+dqz9pwzR5z4SiYYi/FxKUnpbFUZLmjGF+uJ146QQ1HGo?= =?us-ascii?Q?6FvReo7HJNqQBjrSdn1mw866O8/Ub6oQi4PWLQ9BRbBgglizKGm2LwqZq4Q1?= =?us-ascii?Q?foLz8Ki7IVJsXLGPTgZu+9Pkk85fXQ6vUzCWDicwg5Aeq+qW4/nJm5F3V+gj?= =?us-ascii?Q?CHE0pNVp2Eo0+3ti2e3b6dFitZdIq4OLHfoQmzENB9dZZSJZaTBHqooqrNB0?= =?us-ascii?Q?99WTS39PHQuFJUM5JwOD56kM8fOH792lDnpxQu7lj1y3yMWPdVNsiqJEfQ8A?= =?us-ascii?Q?M5Foovh4BOxRLUTQjKlqzL+uufc+me4MHH/SJaqlt8e/T1sdIQ825Qd4+KJH?= =?us-ascii?Q?oKzm8Aq2bnNrsrvvU5XUbuGQdtM2luGQs0Yz85bpkPIZGJmAv9jWWOIKS3/e?= =?us-ascii?Q?z4SXeip9s+JoDNMIixeguPr4162rRIq5si9eDMNwbGo9oL1PlgBhMu+UGnCn?= =?us-ascii?Q?NuLZc+0H7G4s/avcpxtxtp3lxajvf1Sk+2DKqWN18eSXpJsHqWuHA5SVtgNY?= =?us-ascii?Q?6h9IJkpoFu+UTBUwrgP9LmQgmpGKyZipxTeh/NRPLOKqqVuwARAC70fS9WO+?= =?us-ascii?Q?x08rwxHaSJilYVvraOKY96mdtcZz8pvTXkJx9FtHoTftuw34U7l30AEVVFoN?= =?us-ascii?Q?K+prSyL0MJTkPmij0wjFnN80eamzkFuIcM3KyLs7g4T5irQQAg2APbjlxoPz?= =?us-ascii?Q?f7/1aqbrnxtbVoDk4FHsFIPWSD8amOyubq/1KKvBYGjZV4qedoTLnmkzYZ+t?= =?us-ascii?Q?U3HSeKm/1aM7LKeulViFQMrxpRApKGumHOIwAztDVtjhn7kufe61qqGBDUBa?= =?us-ascii?Q?JWQ+CK4FVcwUqod4p+o9U1fDckT/vU04P6Txu8fc1BLNBiO9TxiZ+mKSLzPt?= =?us-ascii?Q?Z5Gfysyit+rzvB+rz2JykIHgS03HOQRNYAOJEGNmm2B7nhNfOxiRSkvUgv6w?= =?us-ascii?Q?raXF2NVGsT1ugSDzwVXKVuAa8uxhxHiLx/r72RicVOEVoPgThiapBZoAQNsY?= =?us-ascii?Q?4bAvs1h6NP7C2IFGDT8eJmOwyLIyxMq+fGIW7nKa565LEfKyvZrasUAkgUiY?= =?us-ascii?Q?nav+o6/M3ToMHyWA6UyzXMPBXPI=3D?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: f2062e94-050c-4ac8-86ba-08d9b9864369 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR02MB8564.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2021 13:34:15.9099 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: I/lO4AVAv3ZDLVKoJxmMoysn6j/HaaX1LmdcSLl4tQDVOsnygbueIhuLB6vVWxxxae7ooVD419DRJi8CdwV+p5crtmKfTEl2t4yeRlxtbrM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR02MB6179 X-Proofpoint-GUID: AZKVyhFAnFcpyHQdyArZLENDbVW1qpLG X-Proofpoint-ORIG-GUID: AZKVyhFAnFcpyHQdyArZLENDbVW1qpLG X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205, Aquarius:18.0.790, Hydra:6.0.425, FMLib:17.11.62.513 definitions=2021-12-07_05,2021-12-06_02,2021-12-02_01 X-Proofpoint-Spam-Reason: safe X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.85 on 10.11.54.8 X-loop: libvir-list@redhat.com X-Mailman-Approved-At: Tue, 07 Dec 2021 09:13:25 -0500 Cc: prachatos.mitra@nutanix.com, Rohit Kumar , prerna.saxena@nutanix.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1638886430695100001 Content-Type: text/plain; charset="utf-8" This patch is to determine the VM which had IO or socket hangup error. Signed-off-by: Rohit Kumar --- src/qemu/qemu_monitor.c | 46 +++++++++++++++++++++++++---------------- 1 file changed, 28 insertions(+), 18 deletions(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index 75e0e4ed92..d36db280d9 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c @@ -530,13 +530,19 @@ qemuMonitorIO(GSocket *socket G_GNUC_UNUSED, qemuMonitor *mon =3D opaque; bool error =3D false; bool hangup =3D false; + virDomainObj *vm =3D mon->vm; + g_autofree char *vmName =3D NULL; + + if (vm !=3D NULL && vm->def !=3D NULL) { + vmName =3D g_strdup(vm->def->name); + } =20 virObjectRef(mon); =20 /* lock access to the monitor and protect fd */ virObjectLock(mon); #if DEBUG_IO - VIR_DEBUG("Monitor %p I/O on socket %p cond %d", mon, socket, cond); + VIR_DEBUG("Monitor %p I/O on socket %p cond %d vm=3D%p name=3D%s", mon= , socket, cond, vm, NULLSTR(vmName)); #endif if (mon->fd =3D=3D -1 || !mon->watch) { virObjectUnlock(mon); @@ -583,8 +589,8 @@ qemuMonitorIO(GSocket *socket G_GNUC_UNUSED, =20 if (!error && !mon->goteof && cond & G_IO_ERR) { - virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("Invalid file descriptor while waiting for mo= nitor")); + virReportError(VIR_ERR_INTERNAL_ERROR, + _("Invalid file descriptor while waiting for mo= nitor vm_name=3D%s"), NULLSTR(vmName)); mon->goteof =3D true; } } @@ -609,13 +615,13 @@ qemuMonitorIO(GSocket *socket G_GNUC_UNUSED, virResetLastError(); } else { if (virGetLastErrorCode() =3D=3D VIR_ERR_OK && !mon->goteof) - virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("Error while processing monitor IO")); + virReportError(VIR_ERR_INTERNAL_ERROR, + _("Error while processing monitor IO vm_nam= e=3D%s"), NULLSTR(vmName)); virCopyLastError(&mon->lastError); virResetLastError(); } =20 - VIR_DEBUG("Error on monitor %s", NULLSTR(mon->lastError.message)); + VIR_DEBUG("Error on monitor %s vm=3D%p name=3D%s", NULLSTR(mon->la= stError.message), vm, NULLSTR(vmName)); /* If IO process resulted in an error & we have a message, * then wakeup that waiter */ if (mon->msg && !mon->msg->finished) { @@ -631,22 +637,20 @@ qemuMonitorIO(GSocket *socket G_GNUC_UNUSED, * will try to acquire the virDomainObj *mutex next */ if (mon->goteof) { qemuMonitorEofNotifyCallback eofNotify =3D mon->cb->eofNotify; - virDomainObj *vm =3D mon->vm; =20 /* Make sure anyone waiting wakes up now */ virCondSignal(&mon->notify); virObjectUnlock(mon); - VIR_DEBUG("Triggering EOF callback"); + VIR_DEBUG("Triggering EOF callback vm=3D%p name=3D%s", vm, NULLSTR= (vmName)); (eofNotify)(mon, vm, mon->callbackOpaque); virObjectUnref(mon); } else if (error) { qemuMonitorErrorNotifyCallback errorNotify =3D mon->cb->errorNotif= y; - virDomainObj *vm =3D mon->vm; =20 /* Make sure anyone waiting wakes up now */ virCondSignal(&mon->notify); virObjectUnlock(mon); - VIR_DEBUG("Triggering error callback"); + VIR_DEBUG("Triggering error callback vm=3D%p name=3D%s", vm, NULLS= TR(vmName)); (errorNotify)(mon, vm, mon->callbackOpaque); virObjectUnref(mon); } else { @@ -932,17 +936,23 @@ qemuMonitorSend(qemuMonitor *mon, qemuMonitorMessage *msg) { int ret =3D -1; + virDomainObj *vm =3D mon->vm; + g_autofree char *vmName =3D NULL; + + if (vm !=3D NULL && vm->def !=3D NULL) { + vmName =3D g_strdup(vm->def->name); + } =20 /* Check whether qemu quit unexpectedly */ if (mon->lastError.code !=3D VIR_ERR_OK) { - VIR_DEBUG("Attempt to send command while error is set %s", - NULLSTR(mon->lastError.message)); + VIR_DEBUG("Attempt to send command while error is set %s vm=3D%p n= ame=3D%s", + NULLSTR(mon->lastError.message), vm, NULLSTR(vmName)); virSetError(&mon->lastError); return -1; } if (mon->goteof) { - virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("End of file from qemu monitor")); + virReportError(VIR_ERR_INTERNAL_ERROR, + _("End of file from qemu monitor vm_name=3D%s"), NU= LLSTR(vmName)); return -1; } =20 @@ -955,15 +965,15 @@ qemuMonitorSend(qemuMonitor *mon, =20 while (!mon->msg->finished) { if (virCondWait(&mon->notify, &mon->parent.lock) < 0) { - virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("Unable to wait on monitor condition")); + virReportError(VIR_ERR_INTERNAL_ERROR, + _("Unable to wait on monitor condition vm_name= =3D%s"), NULLSTR(vmName)); goto cleanup; } } =20 if (mon->lastError.code !=3D VIR_ERR_OK) { - VIR_DEBUG("Send command resulted in error %s", - NULLSTR(mon->lastError.message)); + VIR_DEBUG("Send command resulted in error %s vm=3D%p name=3D%s", + NULLSTR(mon->lastError.message), vm, NULLSTR(vmName)); virSetError(&mon->lastError); goto cleanup; } --=20 2.25.1