[PATCH v2 0/8] some cleanups around CPU related code

Daniel Henrique Barboza posted 8 patches 2 weeks, 4 days ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20211119124830.569230-1-danielhb413@gmail.com
src/cpu/cpu_ppc64.c          |  26 +--
src/qemu/qemu_capabilities.c | 356 +++++++++++++++++++----------------
2 files changed, 198 insertions(+), 184 deletions(-)

[PATCH v2 0/8] some cleanups around CPU related code

Posted by Daniel Henrique Barboza 2 weeks, 4 days ago
Changes from v1, all suggested by Jano:

- helper functions were added to virQEMUCapsLoadCache() to eliminate the
cleanup label without mixing automatic and manual freeing
- create extra strings with different scopes in
virQEMUCapsLoadHostCPUModelInfo() to avoid mixing automatic and manual
freeing
- v1 link: https://listman.redhat.com/archives/libvir-list/2021-November/msg00497.html


Daniel Henrique Barboza (8):
  qemu_capabilities.c: add virQEMUCapsParseFlags()
  qemu_capabilities.c: add virQEMUCapsParseGIC()
  qemu_capabilities.c: del 'nodes' var from virQEMUCapsLoadCache()
  qemu_capabilities.c: add virQEMUCapsValidateEmulator()
  qemu_capabilities.c: add virQEMUCapsValidateArch()
  qemu_capabilities.c: remove cleanup label from virQEMUCapsLoadCache()
  cpu_ppc64.c: remove 'guest' param from ppc64Compute()
  qemu_capabilities.c: del 'cleanup' label in
    virQEMUCapsLoadHostCPUModelInfo()

 src/cpu/cpu_ppc64.c          |  26 +--
 src/qemu/qemu_capabilities.c | 356 +++++++++++++++++++----------------
 2 files changed, 198 insertions(+), 184 deletions(-)

-- 
2.31.1

Re: [PATCH v2 0/8] some cleanups around CPU related code

Posted by Ján Tomko 2 weeks, 4 days ago
On a Friday in 2021, Daniel Henrique Barboza wrote:
>Changes from v1, all suggested by Jano:
>
>- helper functions were added to virQEMUCapsLoadCache() to eliminate the
>cleanup label without mixing automatic and manual freeing
>- create extra strings with different scopes in
>virQEMUCapsLoadHostCPUModelInfo() to avoid mixing automatic and manual
>freeing
>- v1 link: https://listman.redhat.com/archives/libvir-list/2021-November/msg00497.html
>
>
>Daniel Henrique Barboza (8):
>  qemu_capabilities.c: add virQEMUCapsParseFlags()
>  qemu_capabilities.c: add virQEMUCapsParseGIC()
>  qemu_capabilities.c: del 'nodes' var from virQEMUCapsLoadCache()
>  qemu_capabilities.c: add virQEMUCapsValidateEmulator()
>  qemu_capabilities.c: add virQEMUCapsValidateArch()
>  qemu_capabilities.c: remove cleanup label from virQEMUCapsLoadCache()
>  cpu_ppc64.c: remove 'guest' param from ppc64Compute()
>  qemu_capabilities.c: del 'cleanup' label in
>    virQEMUCapsLoadHostCPUModelInfo()
>
> src/cpu/cpu_ppc64.c          |  26 +--
> src/qemu/qemu_capabilities.c | 356 +++++++++++++++++++----------------
> 2 files changed, 198 insertions(+), 184 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano