From nobody Fri Apr 19 23:42:30 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 163714953023772.67413959051942; Wed, 17 Nov 2021 03:45:30 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-518-UAvYpKp-NzeyiSYsRrlz-A-1; Wed, 17 Nov 2021 06:45:25 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 809111015DA1; Wed, 17 Nov 2021 11:45:19 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 329C4101E819; Wed, 17 Nov 2021 11:45:19 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 6A2AB180BAD2; Wed, 17 Nov 2021 11:45:17 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1AHBjG3H019572 for ; Wed, 17 Nov 2021 06:45:16 -0500 Received: by smtp.corp.redhat.com (Postfix) id 664D940CFD10; Wed, 17 Nov 2021 11:45:16 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast02.extmail.prod.ext.rdu2.redhat.com [10.11.55.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6127140CFD05 for ; Wed, 17 Nov 2021 11:45:16 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 486118011A5 for ; Wed, 17 Nov 2021 11:45:16 +0000 (UTC) Received: from mail-ua1-f45.google.com (mail-ua1-f45.google.com [209.85.222.45]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-90-_OestRPCMGCLETidiq4YVQ-1; Wed, 17 Nov 2021 06:45:14 -0500 Received: by mail-ua1-f45.google.com with SMTP id y5so5176891ual.7 for ; Wed, 17 Nov 2021 03:45:14 -0800 (PST) Received: from rekt.ihost.com ([152.250.208.89]) by smtp.gmail.com with ESMTPSA id a4sm11761326vkm.46.2021.11.17.03.45.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Nov 2021 03:45:13 -0800 (PST) X-MC-Unique: UAvYpKp-NzeyiSYsRrlz-A-1 X-MC-Unique: _OestRPCMGCLETidiq4YVQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5ugjGjlNJEZ3q2LuzmxG0kYc7AZ/Zf7XjFrluGtwNHQ=; b=IoBpepVQ90EwogUraBds/LnIMzDdEtBk5xlMbxZYVt4uyH4RTdTXrdJwowOeTtnBee 82gK0GWqSE1jEsLE6decQ1DYX45UwYYip6BPO0WH3huGUnanymlW2zP+zceywEbmodx0 LUXDJREAIPsWa7izdLuKEHN3lijxVSyqLSiP8EumbPkXxVaxlug94yJAPgiEyFUyROow pAEyPIdV/StB7cL7QZrIRqnwvF2A7zKSnITGLgPl9Tp/QAKD+kPrDh3W1kH3R6lzeDUn 3Ftj6ci8Hk/pR71X4IAWLVk+aCHFxW08kVMUtdhqsF+2ZpC0RlyoaYn79Aktm8MVMZUv xCCw== X-Gm-Message-State: AOAM530pCnHYMyTL2bI0TenNcAcDdJh41KypWY1v90bZedKMHiu7yX7o MVfSWHhrzPFKWGlj+v+PQKE5lnHakjY= X-Google-Smtp-Source: ABdhPJyV7wwcYbBkHHkswkLijJaAivCKIz4BIF2GMEmhxJN+LFgPqR7xrXeBo5hoWTPN4QiIWIA/mw== X-Received: by 2002:ab0:2498:: with SMTP id i24mr22856422uan.18.1637149513712; Wed, 17 Nov 2021 03:45:13 -0800 (PST) From: Daniel Henrique Barboza To: libvir-list@redhat.com Subject: [PATCH v2 1/1] tests/qemuxml2*/graphics-spice-timeout: skip CPU model check Date: Wed, 17 Nov 2021 08:45:03 -0300 Message-Id: <20211117114503.933643-2-danielhb413@gmail.com> In-Reply-To: <20211117114503.933643-1-danielhb413@gmail.com> References: <20211117114503.933643-1-danielhb413@gmail.com> MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1 X-loop: libvir-list@redhat.com Cc: fiuczy@linux.ibm.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1637149531707100001 Content-Type: text/plain; charset="utf-8" Commit 65b0b746b516 changed spice tests to use latest caps. Before this change, "FLAG_REAL_CAPS" wasn't being set in testQemuInfoInitArgs(). The absence of this flag triggered the code path inside testCompareXMLToArgv() that executed testUpdateQEMUCaps(). This function will update the host CPU via virQEMUCapsUpdateHostCPUModel() into virQEMUCapsInitHostCPUModel(). In this function, virQEMUCapsInitCPUModel() would end up updating the hostCPU inside the qemuCaps (via virQEMUCapsProbeHostCPU()). Before the forementioned commit, the host CPU was being defaulted to x86_64, vendor Intel, for the 'graphics-spice-timeout' test that is using the 'pc' machine type and 'accel=3Dkvm'. Today, "FLAG_REAL_CAPS" is being set because we're using the latest caps from x86_64. This means that the whole code path mentioned above is skipped. qemuCaps are now being loaded via virQEMUCapsLoadCache() directly. Without the handling being done by testUpdateQEMUCaps(), the host CPU is being retrieved later on, down below qemuProcessCreatePretendCmdPrepare() into qemuProcessUpdateGuestCPU(). The latter will attempt to update the domain cpu and executing a virCPUCompare with the hostCPU and def->cpu. All this logic ended up causing a failure of the 'graphics-spice-timeout' test in ppc64 and s390x hosts. This test is being run with KVM acceleration, and the KVM driver for ppc64 and s390x will return a default x86_64 CPU with vendor "AMD", making virCPUCompare() fail with the following message: "QEMU XML-2-ARGV graphics-spice-timeout.x86_64-latest ... libvirt: CPU Driver error : the CPU is incompatible with host CPU: host CPU vendor does not match required CPU vendor Intel" Fix this test by setting cpu check=3D'none' and avoid the virCPUCompare() that causes the problem for ppc64 and s390x hosts. Note that this is a build fix: a proper investigation of why we're defaulting to an incompatible x86_64 CPU in the circunstances mentioned above is still warranted. Reported-by: Boris Fiuczynski Reviewed-by: Boris Fiuczynski Signed-off-by: Daniel Henrique Barboza --- tests/qemuxml2argvdata/graphics-spice-timeout.xml | 2 +- .../qemuxml2xmloutdata/graphics-spice-timeout.x86_64-latest.xml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/qemuxml2argvdata/graphics-spice-timeout.xml b/tests/qemu= xml2argvdata/graphics-spice-timeout.xml index 065318651f..33dae5c4bf 100644 --- a/tests/qemuxml2argvdata/graphics-spice-timeout.xml +++ b/tests/qemuxml2argvdata/graphics-spice-timeout.xml @@ -15,7 +15,7 @@ - + core2duo Intel diff --git a/tests/qemuxml2xmloutdata/graphics-spice-timeout.x86_64-latest.= xml b/tests/qemuxml2xmloutdata/graphics-spice-timeout.x86_64-latest.xml index fd34a6caf5..9e6782d00b 100644 --- a/tests/qemuxml2xmloutdata/graphics-spice-timeout.x86_64-latest.xml +++ b/tests/qemuxml2xmloutdata/graphics-spice-timeout.x86_64-latest.xml @@ -15,7 +15,7 @@ - + core2duo Intel --=20 2.31.1