From nobody Thu Mar 28 11:51:44 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1637107996579731.2030203432347; Tue, 16 Nov 2021 16:13:16 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-383-2gwN3f2cOE-e2eR8kERqZg-1; Tue, 16 Nov 2021 19:13:12 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 10623420E7; Wed, 17 Nov 2021 00:13:07 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0C97560BF1; Wed, 17 Nov 2021 00:13:05 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id EB8744A702; Wed, 17 Nov 2021 00:12:59 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1AH0C454025329 for ; Tue, 16 Nov 2021 19:12:04 -0500 Received: by smtp.corp.redhat.com (Postfix) id C13BC1121315; Wed, 17 Nov 2021 00:12:04 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast04.extmail.prod.ext.rdu2.redhat.com [10.11.55.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BB2C71121314 for ; Wed, 17 Nov 2021 00:12:02 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E399E100B8D7 for ; Wed, 17 Nov 2021 00:12:01 +0000 (UTC) Received: from mail-qt1-f174.google.com (mail-qt1-f174.google.com [209.85.160.174]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-143-JxK1BcprOsyjGHS8lGBLHw-1; Tue, 16 Nov 2021 19:12:00 -0500 Received: by mail-qt1-f174.google.com with SMTP id z9so949631qtj.9 for ; Tue, 16 Nov 2021 16:12:00 -0800 (PST) Received: from rekt.ihost.com ([152.250.208.89]) by smtp.gmail.com with ESMTPSA id v2sm8870524qkp.72.2021.11.16.16.11.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Nov 2021 16:11:59 -0800 (PST) X-MC-Unique: 2gwN3f2cOE-e2eR8kERqZg-1 X-MC-Unique: JxK1BcprOsyjGHS8lGBLHw-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=IHH11GHmKVzbVXzOOO2HBaZkr6FoEfvAN3ROxup/64M=; b=NjdcXQ5/l9x97Ei/hqyNNIeux3E4G9wJGyKDNZt1wMeVsuufSL0bta+x8XijuB3Obu Me8gHsYPqC93UO8jm4ectujdzOYlgvKgEBVEPLVHwchFZMOKkBGNZ/wdjHpkzgyOR2Od F+tqm8SgsfFkpynDiKqd/kPsj+d4JOs4wLKx5DSJQzk37AUSFS4szFeO8l/6ppLadQnx 3KKXGcWjjDGbRQr4zIcCCrLzMkz2yIJVV4Rl1gNd+5tt57/Q+V5ywzuyJC+oDufwxcqc 1p8Yj4ZbWGJW60B+6aXo4bHSYTOQGejLVg9jvgWDExxwfqB+4MzEHkwelPwDsuf5K81O W82A== X-Gm-Message-State: AOAM530ovz23QgHvJJUcKGGkOmysDDeRwXS3xuF56VCLn1D6HWKKD9k4 zN6IMWRkmBnpe6Bc8gPAUjUds7Rs2YA= X-Google-Smtp-Source: ABdhPJzEOiZi9liO3ARsy1/4hhQG/WpxuHx7DLkDJj+fEdwGnmlM/oq41ZTrgBjlzu6+G0quNUjfiQ== X-Received: by 2002:a05:622a:93:: with SMTP id o19mr11935239qtw.104.1637107919665; Tue, 16 Nov 2021 16:11:59 -0800 (PST) From: Daniel Henrique Barboza To: libvir-list@redhat.com Subject: [RFC PATCH] tests/qemuxml2*/graphics-spice-timeout: skip CPU model check Date: Tue, 16 Nov 2021 21:11:50 -0300 Message-Id: <20211117001150.845465-1-danielhb413@gmail.com> MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-loop: libvir-list@redhat.com Cc: fiuczy@linux.ibm.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1637107998990100001 Content-Type: text/plain; charset="utf-8" Commit 65b0b746b516 changed spice tests to use latest caps. Before this change, "FLAG_REAL_CAPS" wasn't being set in testQemuInfoInitArgs(). The absence of this flag triggered the code path inside testCompareXMLToArgv() that executed testUpdateQEMUCaps(). This function will update the host CPU via virQEMUCapsUpdateHostCPUModel() into virQEMUCapsInitHostCPUModel(). In this function, virQEMUCapsInitCPUModel() would end up updating the hostCPU inside the qemuCaps (via virQEMUCapsProbeHostCPU()). Before the forementioned commit, the host CPU was being defaulted to x86_64, vendor Intel, for the 'graphics-spice-timeout' test that is using the 'pc' machine type and 'accel=3Dkvm'. Today, "FLAG_REAL_CAPS" is being set because we're using the latest caps from x86_64. This means that the whole code path mentioned above is skipped. qemuCaps are now being loaded via virQEMUCapsLoadCache() directly. Without the handling being done by testUpdateQEMUCaps(), the host CPU is being retrieved later on, down below qemuProcessCreatePretendCmdPrepare() into qemuProcessUpdateGuestCPU(). The latter will attempt to update the domain cpu and executing a virCPUCompare with the hostCPU and def->cpu. All this logic ended up causing a failure of the 'graphics-spice-timeout' test in ppc64 and s390x hosts. This test is being run with KVM acceleration, and the KVM driver for ppc64 and s390x will return a default x86_64 CPU with vendor "AMD", making virCPUCompare() fail with the following message: "QEMU XML-2-ARGV graphics-spice-timeout.x86_64-latest ... libvirt: CPU Driver error : the CPU is incompatible with host CPU: host CPU vendor does not match required CPU vendor Intel" Fix this test by setting cpu check=3D'none' and avoid the virCPUCompare() that causes the problem for ppc64 and s390x hosts. Reported-by: Boris Fiuczynski Signed-off-by: Daniel Henrique Barboza Reviewed-by: Boris Fiuczynski --- Sending as a RFC because I'm not sure if this patch fixes the problem for s390x. Boris, can you please test and see if this fix works for you? tests/qemuxml2argvdata/graphics-spice-timeout.xml | 2 +- .../qemuxml2xmloutdata/graphics-spice-timeout.x86_64-latest.xml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/qemuxml2argvdata/graphics-spice-timeout.xml b/tests/qemu= xml2argvdata/graphics-spice-timeout.xml index 065318651f..33dae5c4bf 100644 --- a/tests/qemuxml2argvdata/graphics-spice-timeout.xml +++ b/tests/qemuxml2argvdata/graphics-spice-timeout.xml @@ -15,7 +15,7 @@ - + core2duo Intel diff --git a/tests/qemuxml2xmloutdata/graphics-spice-timeout.x86_64-latest.= xml b/tests/qemuxml2xmloutdata/graphics-spice-timeout.x86_64-latest.xml index fd34a6caf5..9e6782d00b 100644 --- a/tests/qemuxml2xmloutdata/graphics-spice-timeout.x86_64-latest.xml +++ b/tests/qemuxml2xmloutdata/graphics-spice-timeout.x86_64-latest.xml @@ -15,7 +15,7 @@ - + core2duo Intel --=20 2.31.1