From nobody Sun May 5 12:43:19 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1637077881; cv=none; d=zohomail.com; s=zohoarc; b=bkLvpz+WYGhelqp9ajDMPAqF++6MDohicc60Nb2bV6nOaMS47lymr30sZ5hUgs0bsvuLTuGkO6U+r5GvefZNJ1OdI2fmEdx10c+/IILnYHWZgIX1Ix9bXu1QIm/EiyPN1kKWnlWFE+hjtFSN1DYeZTMv4n034xw1Y82PaVA6a+A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1637077881; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=yMHVkr5jbwnTumTPEYL5G5bkeywfnSt34IFmFyabdZY=; b=aRarpZlPxa6fktJRPg6fY4d9+JF0TL4I6Aufs61ESJGD63ajQ2Tr2t2oq11U5nArBkjzwANrnsFarFUywtbb/pni/YkqdvIm4ZEN8XtVK2yOzOkan99Twd8tAttSOnYTRlCftcxRUAXKGM9o7u+S8BpnmX99b9k4+F6wjbsSe7M= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1637077881824345.87448165636374; Tue, 16 Nov 2021 07:51:21 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-227-XbwbP8LNNC2nXuf4UEz3rQ-1; Tue, 16 Nov 2021 10:51:19 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CEC20101F008; Tue, 16 Nov 2021 15:51:12 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D88F67621D; Tue, 16 Nov 2021 15:51:11 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 623E24EA2F; Tue, 16 Nov 2021 15:51:10 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1AGFp9si015453 for ; Tue, 16 Nov 2021 10:51:09 -0500 Received: by smtp.corp.redhat.com (Postfix) id E682460C4A; Tue, 16 Nov 2021 15:51:09 +0000 (UTC) Received: from kinshicho.usersys.redhat.com (unknown [10.40.192.180]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3BB2860C13 for ; Tue, 16 Nov 2021 15:50:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1637077880; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=yMHVkr5jbwnTumTPEYL5G5bkeywfnSt34IFmFyabdZY=; b=aikW8BUsCpL4t6CXMIU5HCD28cF+i9sNZop06j4/6J/ZVxbFSIoZMhfAZXivxtYCXXFjkW C2hrAVFe2Gg/LvMd3r7BxghOrzvCdF504TAq2iBr0J6ZoP5bwoAnFaf9Yol/nYWKbkVi0B ttf7hkeE+qHQ06w1h04TSv+YZ3FqUuE= X-MC-Unique: XbwbP8LNNC2nXuf4UEz3rQ-1 From: Andrea Bolognani To: libvir-list@redhat.com Subject: [libvirt PATCH] spec: Don't create unnecessary directory Date: Tue, 16 Nov 2021 16:50:55 +0100 Message-Id: <20211116155055.123909-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1637077883391100001 Content-Type: text/plain; charset="utf-8" The directory is already created by the build system, so we don't need to create it explicitly in the spec file; moreover, the path was incorrect, because it used datadir instead of localstatedir. Fixes: 4e041189f85bc1b0f8d5278c0cafdd4aba55beaf Signed-off-by: Andrea Bolognani --- libvirt.spec.in | 1 - 1 file changed, 1 deletion(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 5f1773ef93..85e879fedb 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -1192,7 +1192,6 @@ rm -f $RPM_BUILD_ROOT%{_libdir}/libvirt/storage-file/= *.a rm -f $RPM_BUILD_ROOT%{wireshark_plugindir}/libvirt.la %endif =20 -install -d -m 0755 $RPM_BUILD_ROOT%{_datadir}/lib/libvirt/dnsmasq/ # We don't want to install /etc/libvirt/qemu/networks in the main %%files = list # because if the admin wants to delete the default network completely, we = don't # want to end up re-incarnating it on every RPM upgrade. --=20 2.31.1