From nobody Sat May 4 10:02:28 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1636641385; cv=none; d=zohomail.com; s=zohoarc; b=URwKYzZHG4lSu7XVRO96l+AwmCQt2ric4oTmHa6BC9x43c5LrNOeRhpwh1BIS6bB+rfwmWk999nsTBgkRda5FsquXz7rHSDXRmeHgrOcZjH5E8cLP8re33l8gcMns9qFUbkbKlsIPbKw63m/nD05N/csGs9bQNeC/L4JkFRuHH0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1636641385; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=lJsNpjyWbvgVU2c/4XKMEI3UN+050by84MGWYoXykVg=; b=ijbu3Z9s9VTWKxrAQgRke58NOYBCOu3PuBsUzk/d0+HtBXy7XWwopje9LbpfbKbR/Ur0oLNrLFMczNMsm22MUbbDkVlTNH65WAUMdc3Y3c0C0SqKC7xHKu4wRq6AFBdKG/QPADSA6jC7WGp6CBku1HNKL9mA305FZruISVlpm9I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1636641385268731.4637605432883; Thu, 11 Nov 2021 06:36:25 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-397-VyGfdbBUO2-NsN4ubNeS3Q-1; Thu, 11 Nov 2021 09:36:22 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4B9BE15722; Thu, 11 Nov 2021 14:36:16 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A707919C59; Thu, 11 Nov 2021 14:36:14 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id D9BB24A703; Thu, 11 Nov 2021 14:36:10 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1ABEa8Cd028873 for ; Thu, 11 Nov 2021 09:36:08 -0500 Received: by smtp.corp.redhat.com (Postfix) id 72FA860CC4; Thu, 11 Nov 2021 14:36:08 +0000 (UTC) Received: from merkur.fritz.box (unknown [10.39.193.238]) by smtp.corp.redhat.com (Postfix) with ESMTP id 94D6C60C9F; Thu, 11 Nov 2021 14:35:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1636641384; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=lJsNpjyWbvgVU2c/4XKMEI3UN+050by84MGWYoXykVg=; b=EIOBaBWdoBP1Xqu4MF3Jwmcqi7YlnXxxmGavGXfHI881Fkf6niF6jQKygtMn5StUC/cO7p lkGHOlDKTGCwJNqI/RZDtokfGWvBcvg3SEljMUtwAnhvgyLvUGeVutbBCPOCGnBwS5D7SN 5idwRXF9K+wQZPVSLAuiwkzufpSHzkg= X-MC-Unique: VyGfdbBUO2-NsN4ubNeS3Q-1 From: Kevin Wolf To: qemu-devel@nongnu.org Subject: [PATCH for-6.2] docs: Deprecate incorrectly typed device_add arguments Date: Thu, 11 Nov 2021 15:35:30 +0100 Message-Id: <20211111143530.18985-1-kwolf@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: libvir-list@redhat.com Cc: kwolf@redhat.com, libvir-list@redhat.com, armbru@redhat.com, pbonzini@redhat.com, eblake@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1636641386362100001 Content-Type: text/plain; charset="utf-8" While introducing a non-QemuOpts code path for device creation for JSON -device, we noticed that QMP device_add doesn't check its input correctly (accepting arguments that should have been rejected), and that users may be relying on this behaviour (libvirt did until it was fixed recently). Let's use a deprecation period before we fix this bug in QEMU to avoid nasty surprises for users. Signed-off-by: Kevin Wolf Reviewed-by: Daniel P. Berrang=C3=A9 Reviewed-by: Markus Armbruster --- docs/about/deprecated.rst | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index 600031210d..c03fcf951f 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -250,6 +250,20 @@ options are removed in favor of using explicit ``block= dev-create`` and ``blockdev-add`` calls. See :doc:`/interop/live-block-operations` for details. =20 +Incorrectly typed ``device_add`` arguments (since 6.2) +'''''''''''''''''''''''''''''''''''''''''''''''''''''' + +Due to shortcomings in the internal implementation of ``device_add``, QEMU +incorrectly accepts certain invalid arguments: Any object or list argument= s are +silently ignored. Other argument types are not checked, but an implicit +conversion happens, so that e.g. string values can be assigned to integer +device properties or vice versa. + +This is a bug in QEMU that will be fixed in the future so that previously +accepted incorrect commands will return an error. Users should make sure t= hat +all arguments passed to ``device_add`` are consistent with the documented +property types. + System accelerators ------------------- =20 --=20 2.31.1