From nobody Sun Apr 28 16:46:12 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=quarantine dis=quarantine) header.from=suse.com Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1636500986052112.06585989928305; Tue, 9 Nov 2021 15:36:26 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-88-bGSjvV5eOSaurrz-tT3g9A-1; Tue, 09 Nov 2021 18:36:21 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4E16E802C91; Tue, 9 Nov 2021 23:36:15 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A3A2D60C05; Tue, 9 Nov 2021 23:36:12 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 30EE84A703; Tue, 9 Nov 2021 23:36:08 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1A9NYULN000443 for ; Tue, 9 Nov 2021 18:34:30 -0500 Received: by smtp.corp.redhat.com (Postfix) id E9D972026D11; Tue, 9 Nov 2021 23:34:29 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast04.extmail.prod.ext.rdu2.redhat.com [10.11.55.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E3F642026D6B for ; Tue, 9 Nov 2021 23:34:24 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 110581066559 for ; Tue, 9 Nov 2021 23:34:24 +0000 (UTC) Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-19-4JWo24OHNYaFg6-LCbMBPQ-1; Tue, 09 Nov 2021 18:34:22 -0500 Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-ve1eur03lp2055.outbound.protection.outlook.com [104.47.9.55]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-18-qvyhrnDoNbe1YWNYJdTI1Q-1; Wed, 10 Nov 2021 00:34:19 +0100 Received: from AM0PR04MB4899.eurprd04.prod.outlook.com (20.176.215.208) by AM0PR04MB5506.eurprd04.prod.outlook.com (20.178.115.221) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.16; Tue, 9 Nov 2021 23:34:18 +0000 Received: from AM0PR04MB4899.eurprd04.prod.outlook.com ([fe80::c58b:de4e:3ba7:9ef6]) by AM0PR04MB4899.eurprd04.prod.outlook.com ([fe80::c58b:de4e:3ba7:9ef6%4]) with mapi id 15.20.4669.016; Tue, 9 Nov 2021 23:34:18 +0000 Received: from localhost (75.169.52.172) by AS8PR04CA0109.eurprd04.prod.outlook.com (2603:10a6:20b:31e::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.15 via Frontend Transport; Tue, 9 Nov 2021 23:34:17 +0000 X-MC-Unique: bGSjvV5eOSaurrz-tT3g9A-1 X-MC-Unique: 4JWo24OHNYaFg6-LCbMBPQ-1 X-MC-Unique: qvyhrnDoNbe1YWNYJdTI1Q-1 From: Jim Fehlig To: libvir-list@redhat.com Subject: [PATCH] libxl: Free data returned from libxl_userdata_retrieve Date: Tue, 9 Nov 2021 16:34:14 -0700 Message-ID: <20211109233414.13132-1-jfehlig@suse.com> X-ClientProxiedBy: AS8PR04CA0109.eurprd04.prod.outlook.com (2603:10a6:20b:31e::24) To AM0PR04MB4899.eurprd04.prod.outlook.com (2603:10a6:208:c5::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2bd2f25d-59ed-4f10-4dc5-08d9a3d97310 X-MS-TrafficTypeDiagnostic: AM0PR04MB5506: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1360 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0 X-Microsoft-Antispam-Message-Info: v//o9iV1arQUHp4swvD2KRCzzJHbfEBQb4QKhUsqfEkty+C4iJCw7dYcxnTQNmXRSsWxYLzFaw+JEmfzEiOdLJvzTDNJZ43DO52cv76n1CwUVpKL65OB7qVzYYreB9PIKgTnLsSBLTaa1KYFHhmzbVaeMGdhUiFPjQe9h3UOjhh2I248fXBUCoYqe1W9Pu0T4VeGUrv64X4nkZ94mykh+v2526GjRWyOGQnU6zYKH9VmVT7RdRKdUT6LxA9n8v+v5i4KiPgDhtYxP/O2OudGdvKMPIVawR2b/66SLKFTIrhbamZ3L7ToK5NjiWbtkMJ6xmC1llwhR2iF1svtKUoaqJIyE2nr3ftU2Zw3lkhZ/jz54EqIM+f+JxXgDxej+2qU7luDxDu3YgDH879IdZKke/cuzJ0ClGzVjM5CxveeR2J32BPY0GJUJjR8D3cF1JnLff5qddvkkoXxxq1YY1UJIgOEkW4iyMNjbuX5SkPUtFKBgDwgwubhk/BG6G/PCTPAt/uosdMltoT5CPOXpNnUZDpeKsyx/2R5qYljZUAvsNqYhqXmqGieDW3xzVCI5JOApxsjA88JXfUYzbvkB+p8JYcUYxyFKIm8yRY9gJYI9UWRCOyapM05LlylLtDsG0+PyPDghzPuhhaKi2Q2nU6/8g== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR04MB4899.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(6666004)(5660300002)(38100700002)(66556008)(66476007)(86362001)(6486002)(2906002)(6916009)(8676002)(316002)(508600001)(8936002)(66946007)(1076003)(2616005)(956004)(6496006)(26005)(36756003)(186003)(83380400001); DIR:OUT; SFP:1101 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?CY7rozFQrNuLszMucl2hDsGUjmiAIsO7MzwXjVSTsFUmCu2BMZYC74PPSSWE?= =?us-ascii?Q?vEeeBBMlN2Jea57TuAfsHWHmW60mllM/5k7smegPj2oWUfcFmvtLyiVbMRhi?= =?us-ascii?Q?V0ypiRqE2TGJJ+r5TO5Xe64+wca1qwDJNRZgOfMd/PSSDGy/sEKdsWGATOU5?= =?us-ascii?Q?VCXRa7H56oIR6UOtdq1zA60Uc/nsQWTFsw5FENOpSzjPm/8kwS+a2+1FiVGv?= =?us-ascii?Q?RGNYSJj8ZbFPsL40H946W1i4FqpUlDR5Bq155Vjxx1hp+9/4nra395ykGlsy?= =?us-ascii?Q?4ICEyi3WhVXa/XjnLQ6lBNMNzOtJxDaA3XQG1/1QE/sczTAoEKrFxb/3fVy1?= =?us-ascii?Q?olYva7tC26dCSs09M68yXV0KU7ULDasTXG4MoFCnluJ4V6P7MxfGrkZxeZQM?= =?us-ascii?Q?eKHvwxYPgr0HynSO2YffSfZrTwjbSCLeVLSNJOliwlMBt9RhutYDNxVQunq9?= =?us-ascii?Q?ngGHvp/JhsqW7c7dEayTKtBZR4WbVR1nHcuil5nYA6yPENKR3hplqpoIkSiV?= =?us-ascii?Q?8Jy9LGvZtsYYAxUUqnmQAD+/mPS616qaPsTm5yaOvZiu5OdaWJHn2stYQKZq?= =?us-ascii?Q?dWpm3qhLzhfYrYJxeUX2mO4AlC4HcA++GTlfPEQkONgYWgAjfPfwD0Rn77dC?= =?us-ascii?Q?906o/R3jfHiJhIFS1KT6UH8cg7ptSi43/YY1WOAf5UmWukv+szfxNMQtNwkn?= =?us-ascii?Q?nbxXYAa8Wk8Mxgz/3BkisxrAPBk0gFvYscsQWMNf7K3fiDFEE3gAByZqiHYY?= =?us-ascii?Q?l/bRMPMFvh5QRJBoWga6ngqXEYf2aTDzMf0pVf8gOqstYxK+fUjjV1hh4EXn?= =?us-ascii?Q?se/1szB4NFi/VGm+lA5+V8/ToWfTu6Kp6udyALkbj/hteWlibpfZs4yzsRrh?= =?us-ascii?Q?WVGd3layfVPB667n6aD/uHhX+TBei6o5B4RyybDlmdNJ/SVAWa1TxxugUPEn?= =?us-ascii?Q?6j2aelg/v+B2Ae3wBqdJ54oo0+wAY+fToC1S1169bv4Vo/IQPtjhDHy0cYhJ?= =?us-ascii?Q?Uznx7b9zhqVT0HrcI3tRQ+UIx6WYdxbScZz+cyJVyibp/YWkN2eihT2g3Clu?= =?us-ascii?Q?gYEf6+nhScIlmGI+P5gmNB8nEQnwgB2BgjrXHDTN1Zir8q+E2ut7ww5dPUi6?= =?us-ascii?Q?RvRUFBaCVGgv4ykQBf22xabMyFp1Q68NNGcNkavwrk4BV/xx5T92tKvyuLEQ?= =?us-ascii?Q?opcwpH96MLa3OiJqBmh4S1TlEA6ULkRnhxvJccBLCScRlHaeheGnI10DZ9Ol?= =?us-ascii?Q?LaV+SvnAImvxw5G3lo60ejLbRJA/gVTPUFVDZLqUUI27BKDQWMo0aKpPbI3Y?= =?us-ascii?Q?bWBOjaB/aWRIc+LDW0vIRdT6kWw+/2ab74p1MyTWdIbqCdxvnz6juIzL8QkA?= =?us-ascii?Q?Ez4V2oFSWjHZlMusSQUismVpL8+Fj0/S6lV8RYcoNUKcbgdZx4kCDNfx9LB5?= =?us-ascii?Q?debyNyTVIyUUs4l7l6kGpdNGcreNf/5ACDgHIUbaNiADkWGx4T0o79bycE3n?= =?us-ascii?Q?u7BYo57TDmicP2QMKgEU4F2VNogii162ol6CgAGqyxaiGESevCs8nxhl9MtK?= =?us-ascii?Q?sX+F8D3L+7FHJcGn+kOrImKBZCJRyVHed997FwZmnkGeAXGXJmfOdgC+LC+t?= =?us-ascii?Q?4GWXyS5bg7aB7o9X4TDeo/U=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2bd2f25d-59ed-4f10-4dc5-08d9a3d97310 X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB4899.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2021 23:34:18.4174 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rPRGm2J4KGzAfeC74u/J6zJ4gzsZyLfRWLVEF5fCD3cR2SFh3ZBj5Gtb9um+53XHkIld1HErV3dWJLsqlvqAcA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5506 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-MIME-Autoconverted: from quoted-printable to 8bit by lists01.pubmisc.prod.ext.phx2.redhat.com id 1A9NYULN000443 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1636500987532100001 Content-Type: text/plain; charset="utf-8" Found via valgrind =3D=3D15016=3D=3D 3,701 bytes in 2 blocks are definitely lost in loss recor= d 975 of 1,009 =3D=3D15016=3D=3D at 0x4C2A2AF: malloc (in /usr/lib64/valgrind/vgpreload= _memcheck-amd64-linux.so) =3D=3D15016=3D=3D by 0x1FCD30CB: libxl_read_file_contents (in /usr/lib64= /libxenlight.so.4.12.0) =3D=3D15016=3D=3D by 0x1FCCA58A: ??? (in /usr/lib64/libxenlight.so.4.12.= 0) =3D=3D15016=3D=3D by 0x1FCCA6C2: libxl_userdata_retrieve (in /usr/lib64/= libxenlight.so.4.12.0) =3D=3D15016=3D=3D by 0x1FA42A5A: libxlReconnectDomain (libxl_driver.c:39= 4) =3D=3D15016=3D=3D by 0x53BAC99: virDomainObjListHelper (virdomainobjlist= .c:802) =3D=3D15016=3D=3D by 0x530842F: virHashForEach (virhash.c:575) =3D=3D15016=3D=3D by 0x53BC0E0: virDomainObjListForEach (virdomainobjlis= t.c:817) =3D=3D15016=3D=3D by 0x1FA423C4: libxlReconnectDomains (libxl_driver.c:4= 68) =3D=3D15016=3D=3D by 0x1FA423C4: libxlStateInitialize (libxl_driver.c:77= 8) =3D=3D15016=3D=3D by 0x54E8E9E: virStateInitialize (libvirt.c:657) =3D=3D15016=3D=3D by 0x12DBFA: daemonRunStateInit (remote_daemon.c:797) =3D=3D15016=3D=3D by 0x535BF79: virThreadHelper (virthread.c:206) Signed-off-by: Jim Fehlig Reviewed-by: Michal Privoznik --- src/libxl/libxl_driver.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index 7ea157f9c4..1a9bf8f186 100644 --- a/src/libxl/libxl_driver.c +++ b/src/libxl/libxl_driver.c @@ -461,6 +461,7 @@ libxlReconnectDomain(virDomainObj *vm, =20 cleanup: libxl_dominfo_dispose(&d_info); + VIR_FREE(data); virObjectUnlock(vm); virObjectUnref(vm); virObjectUnref(cfg); --=20 2.33.0