From nobody Sun Feb 8 20:13:42 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1636043559; cv=none; d=zohomail.com; s=zohoarc; b=UoouHZL4pjf0p3CIQqUOhPlSarFH/Fphma39Fp3l4h6HVCxcHMiokH/BxdZ2eXvR+ZBoeLBMt9TAqnDvwpOvjvc17mBAVZCgElbxTfOrO5LK9CiklwvMyXswoEr3duem3wyts01prp9Tp6Fv2p3MDio5OxYB/409k4lTgLURZ4A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1636043559; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Vsy593sWOraW1TuLUIDl0Q+y6cH+Cyg9+j9tmjDbC6I=; b=HjpemRmxXwAtZDM0n3xLt/U1SJzlUoya7+1gdI3HNW89WVswogBxzY2gIGkvDRa27PVKYs5AJCR/nEbmLm9pTBQcnHWRnM/MwsYH2MVOtHgD5oLxwOIVHEuv+TvVx3tOYyX2IQ6btsL3dgLObF9b5bev5dLkTS5Dwhd2nwP58tE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1636043559016702.5534112337768; Thu, 4 Nov 2021 09:32:39 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-398-RrG2ShibPMKRAFZZVIKrxw-1; Thu, 04 Nov 2021 12:32:36 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5CEC61018722; Thu, 4 Nov 2021 16:32:31 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3A66F70953; Thu, 4 Nov 2021 16:32:31 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 2997E4EA37; Thu, 4 Nov 2021 16:32:30 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1A4GRTxi026392 for ; Thu, 4 Nov 2021 12:27:29 -0400 Received: by smtp.corp.redhat.com (Postfix) id F365319D9F; Thu, 4 Nov 2021 16:27:28 +0000 (UTC) Received: from work.speedport.ip (unknown [10.39.193.164]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4B72419C79; Thu, 4 Nov 2021 16:27:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1636043558; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=Vsy593sWOraW1TuLUIDl0Q+y6cH+Cyg9+j9tmjDbC6I=; b=iiiJem3JCDWw1Qt/iAdQHemEw+C9J96kCK0qo8vYCJVNdftiM3m+uQ+iV6bJoH1H1kdOXv jGe+Tn7lCkbDVglYT56MaaD+ijIV7Sh+KUw0+KhcXn0SeuQWmac9WYo4Il9M+L1lSQ8shd 2F7tAH0h9Uil1KlNGGv0yUi93r+uA1Y= X-MC-Unique: RrG2ShibPMKRAFZZVIKrxw-1 From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH v2 07/20] cpu_x86: Implement virCPUDataIsIdentical for x86 Date: Thu, 4 Nov 2021 17:27:07 +0100 Message-Id: <20211104162720.108973-8-twiederh@redhat.com> In-Reply-To: <20211104162720.108973-1-twiederh@redhat.com> References: <20211104162720.108973-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com Cc: Tim Wiederhake X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1636043560192100001 Content-Type: text/plain; charset="utf-8" Signed-off-by: Tim Wiederhake --- src/cpu/cpu_x86.c | 69 +++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 69 insertions(+) diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c index a08ac225ef..5ce193e693 100644 --- a/src/cpu/cpu_x86.c +++ b/src/cpu/cpu_x86.c @@ -3332,6 +3332,74 @@ virCPUx86DataAddFeature(virCPUData *cpuData, } =20 =20 +static bool +virCPUx86DataItemIsIdentical(const virCPUx86DataItem *a, + const virCPUx86DataItem *b) +{ + if (a->type !=3D b->type) + return false; + + switch (a->type) { + case VIR_CPU_X86_DATA_NONE: + break; + + case VIR_CPU_X86_DATA_CPUID: + return a->data.cpuid.eax_in =3D=3D b->data.cpuid.eax_in && + a->data.cpuid.ecx_in =3D=3D b->data.cpuid.ecx_in && + a->data.cpuid.eax =3D=3D b->data.cpuid.eax && + a->data.cpuid.ebx =3D=3D b->data.cpuid.ebx && + a->data.cpuid.ecx =3D=3D b->data.cpuid.ecx && + a->data.cpuid.edx =3D=3D b->data.cpuid.edx; + + case VIR_CPU_X86_DATA_MSR: + return a->data.msr.index =3D=3D b->data.msr.index && + a->data.msr.eax =3D=3D b->data.msr.eax && + a->data.msr.edx =3D=3D b->data.msr.edx; + } + + return true; +} + +static virCPUCompareResult +virCPUx86DataIsIdentical(const virCPUData *a, + const virCPUData *b) +{ + const virCPUx86Data *adata; + const virCPUx86Data *bdata; + size_t i; + size_t j; + + if (!a || !b) + return VIR_CPU_COMPARE_ERROR; + + if (a->arch !=3D b->arch) + return VIR_CPU_COMPARE_INCOMPATIBLE; + + if (!((adata =3D &a->data.x86) && (bdata =3D &b->data.x86))) + return VIR_CPU_COMPARE_ERROR; + + if (adata->len !=3D bdata->len) + return VIR_CPU_COMPARE_INCOMPATIBLE; + + for (i =3D 0; i < adata->len; ++i) { + bool found =3D false; + + for (j =3D 0; j < bdata->len; ++j) { + if (!virCPUx86DataItemIsIdentical(&adata->items[i], + &bdata->items[j])) + continue; + + found =3D true; + break; + } + + if (!found) + return VIR_CPU_COMPARE_INCOMPATIBLE; + } + + return VIR_CPU_COMPARE_IDENTICAL; +} + static bool virCPUx86FeatureIsMSR(const char *name) { @@ -3415,4 +3483,5 @@ struct cpuArchDriver cpuDriverX86 =3D { .copyMigratable =3D virCPUx86CopyMigratable, .validateFeatures =3D virCPUx86ValidateFeatures, .dataAddFeature =3D virCPUx86DataAddFeature, + .dataIsIdentical =3D virCPUx86DataIsIdentical, }; --=20 2.31.1