From nobody Mon Feb 9 11:46:57 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1635135892; cv=none; d=zohomail.com; s=zohoarc; b=SD86B5fN5S0zcPQ7dgDDsZ411Q+/O5cUIGQBQ39X/9HacKlDE7c1/VGOqvSanrbxqjwvqlNPT9QaNkQV8xR3E6+YEQ6TG+4Vw8pMbJNSnEHK4S7zSwkZnLkQDELNoAI62PW9vwidx4m6f1IpCzNSxjYgEkj8jB0JWdLDU5W3N3U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635135892; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=TDuE6wB+NhgVZWT1yd+7ld8eNMlPXfVnsXRFVQ7a3Y8=; b=OQ9Amw3IcjVeaphvIAnrWVIBoc8/L3u0YZ2oh0TP1xoNtKUm2AgCutBuvlwo0yyDSbcspsJj+VUSInvCvKN7d2Yu9V8pSbj2C3573rvjLN8j3mKc5IeNhWt8UR4Zc46zIMhso3ebD/MVu2DHX+VQnyaq7YuUl440H63pL2VLDdY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 16351358923781015.7899693143096; Sun, 24 Oct 2021 21:24:52 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-195-FiTB8MBfNieBWODcN9jGTQ-1; Mon, 25 Oct 2021 00:24:49 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 55A84802B7A; Mon, 25 Oct 2021 04:24:44 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2883660BF4; Mon, 25 Oct 2021 04:24:44 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id A4CA34E590; Mon, 25 Oct 2021 04:24:43 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 19P4OKP6014780 for ; Mon, 25 Oct 2021 00:24:20 -0400 Received: by smtp.corp.redhat.com (Postfix) id 84A935BB06; Mon, 25 Oct 2021 04:24:20 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-7.ams2.redhat.com [10.36.112.7]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 534396060F; Mon, 25 Oct 2021 04:24:20 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 0F36B11380CA; Mon, 25 Oct 2021 06:24:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635135891; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=TDuE6wB+NhgVZWT1yd+7ld8eNMlPXfVnsXRFVQ7a3Y8=; b=FzxNi/BUlEQ5J68cpkbt0NpRG++vyPpie6IGYXlNJQiZclnZQDjEAhjb+WJ0GH/GWhmsIa 49NALjFdmOqP7EfEcFSsD05c1VWpOtiQO3N23rs/ii+5BBi7k3/lZ4Np/TH69Q0t1/6t3L UGlbrXGKH/QuRHFkPTJACCZ/lSEvHoE= X-MC-Unique: FiTB8MBfNieBWODcN9jGTQ-1 From: Markus Armbruster To: qemu-devel@nongnu.org Subject: [PATCH v4 5/5] block: Deprecate transaction type drive-backup Date: Mon, 25 Oct 2021 06:24:05 +0200 Message-Id: <20211025042405.3762351-6-armbru@redhat.com> In-Reply-To: <20211025042405.3762351-1-armbru@redhat.com> References: <20211025042405.3762351-1-armbru@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Cc: kwolf@redhat.com, vsementsov@virtuozzo.com, libvir-list@redhat.com, eblake@redhat.com, pkrempa@redhat.com, marcandre.lureau@redhat.com, jsnow@redhat.com, libguestfs@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1635135893947100001 Content-Type: text/plain; charset="utf-8" Several moons ago, Vladimir posted Subject: [PATCH v2 3/3] qapi: deprecate drive-backup Date: Wed, 5 May 2021 16:58:03 +0300 Message-Id: <20210505135803.67896-4-vsementsov@virtuozzo.com> https://lists.gnu.org/archive/html/qemu-devel/2021-05/msg01394.html with this TODO: We also need to deprecate drive-backup transaction action.. But union members in QAPI doesn't support 'deprecated' feature. I tried to dig a bit, but failed :/ Markus, could you please help with it? At least by advice? This is one way to resolve it. Sorry it took so long. John explored another way, namely adding feature flags to union branches. Could also be useful, say to add different features to branches in multiple unions sharing the same tag enum. Signed-off-by: Markus Armbruster Reviewed-by: Vladimir Sementsov-Ogievskiy --- qapi/transaction.json | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/qapi/transaction.json b/qapi/transaction.json index d175b5f863..381a2df782 100644 --- a/qapi/transaction.json +++ b/qapi/transaction.json @@ -54,6 +54,10 @@ # @blockdev-snapshot-sync: since 1.1 # @drive-backup: Since 1.6 # +# Features: +# @deprecated: Member @drive-backup is deprecated. Use member +# @blockdev-backup instead. +# # Since: 1.1 ## { 'enum': 'TransactionActionKind', @@ -62,7 +66,7 @@ 'block-dirty-bitmap-disable', 'block-dirty-bitmap-merge', 'blockdev-backup', 'blockdev-snapshot', 'blockdev-snapshot-internal-sync', 'blockdev-snapshot-sync', - 'drive-backup' ] } + { 'name': 'drive-backup', 'features': [ 'deprecated' ] } ] } =20 ## # @AbortWrapper: --=20 2.31.1