From nobody Mon May 6 18:14:33 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1635054097907275.79581732933536; Sat, 23 Oct 2021 22:41:37 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-124-2flidixeNJakKLr4T__XQg-1; Sun, 24 Oct 2021 01:41:32 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 01C1810A8E00; Sun, 24 Oct 2021 05:41:26 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BE40B5F4EC; Sun, 24 Oct 2021 05:41:23 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id B08FD4A703; Sun, 24 Oct 2021 05:41:17 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 19O5fFqS011528 for ; Sun, 24 Oct 2021 01:41:15 -0400 Received: by smtp.corp.redhat.com (Postfix) id 5E8461121315; Sun, 24 Oct 2021 05:41:15 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast04.extmail.prod.ext.rdu2.redhat.com [10.11.55.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 59D421121314 for ; Sun, 24 Oct 2021 05:41:12 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8C845100B8DA for ; Sun, 24 Oct 2021 05:41:12 +0000 (UTC) Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-313-_1j8hQpEMXm0CnoeawGGUQ-1; Sun, 24 Oct 2021 01:41:10 -0400 Received: by mail-pj1-f48.google.com with SMTP id np13so5783578pjb.4 for ; Sat, 23 Oct 2021 22:41:10 -0700 (PDT) Received: from anisinha-lenovo.ba.nuagenetworks.net ([115.96.129.254]) by smtp.googlemail.com with ESMTPSA id z7sm12511443pgo.11.2021.10.23.22.41.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Oct 2021 22:41:08 -0700 (PDT) X-MC-Unique: 2flidixeNJakKLr4T__XQg-1 X-MC-Unique: _1j8hQpEMXm0CnoeawGGUQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=tzWsYwSvs58pMPbld+nl6xjqdo4uZjMIx++oKEORSB0=; b=AnA3Rg0UwbdNMIISBEK3ZB+yI5XnuCiNpzq+iXafRZbxIwuNUnlmCD2Wsce+PE0it/ YlZ0ET+KOXF9rdu+I1g6hVJ1VjosM4Ow80kb36goOcYQRIP5PAYgLZ0BOtQ5ueMUn93N ukH/ZYqjI4Zi5fkkU0WMt3JNfLzXxE06Px5b/NK0kwJ/W4tgGXa8k+B2y0+vEdHrhg2d 5Mmsiz3hTzIy1el9/nhE075Tmknun8hs4Mp/5l7ld4p6yPc68+/0DtpiZKA4vjOxpT0o TCWoZ/6iX3gMNmnZ2zja2QvHH9Wp3c9ULhxK1hSoVntvd2N/JJsrkYwkkTJQItXarc0v MGeQ== X-Gm-Message-State: AOAM530ZI0K6Mds3m2qg2PkxYV6bMPl+WHAFd6iNCalsVQrbc7CUcwPx hSFOEyjPbOWEc0KX+/BpwyBYlJtuwHEPpw== X-Google-Smtp-Source: ABdhPJxuR+6iyt8OrX8qCpOIe6sQ4VoQDvsFl74LfybH7jw7GQYttUubV3GxPytUpvhjoQDn31tS/A== X-Received: by 2002:a17:902:780f:b0:13a:3a88:f4cb with SMTP id p15-20020a170902780f00b0013a3a88f4cbmr9594133pll.68.1635054068798; Sat, 23 Oct 2021 22:41:08 -0700 (PDT) From: Ani Sinha To: libvir-list@redhat.com Subject: [PATCH] cosmetic: remove unused function return value Date: Sun, 24 Oct 2021 11:10:43 +0530 Message-Id: <20211024054043.357202-1-ani@anisinha.ca> MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-loop: libvir-list@redhat.com Cc: Ani Sinha X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1635054098964100001 Content-Type: text/plain; charset="utf-8" qemuBuildPMPCIRootHotplugCommandLine() returns 0 unconditionally. There is = no failure scenario at present. So clean up the code by removing integer return from the function and also remove the failure check conditional from the function call. Also fix indentation for the above function call while at it. Signed-off-by: Ani Sinha Reviewed-by: Laine Stump --- src/qemu/qemu_command.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index d6df50ec73..093d8ae62c 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -3177,9 +3177,9 @@ qemuBuildSkipController(const virDomainControllerDef = *controller, return false; } =20 -static int +static void qemuBuildPMPCIRootHotplugCommandLine(virCommand *cmd, - const virDomainControllerDef *controller) + const virDomainControllerDef *control= ler) { if (controller->type =3D=3D VIR_DOMAIN_CONTROLLER_TYPE_PCI && controller->model =3D=3D VIR_DOMAIN_CONTROLLER_MODEL_PCI_ROOT && @@ -3189,7 +3189,7 @@ qemuBuildPMPCIRootHotplugCommandLine(virCommand *cmd, virCommandAddArgFormat(cmd, "PIIX4_PM.acpi-root-pci-hotplug=3D= %s", virTristateSwitchTypeToString(controlle= r->opts.pciopts.hotplug)); } - return 0; + return; } =20 static int @@ -3207,8 +3207,7 @@ qemuBuildControllersByTypeCommandLine(virCommand *cmd, if (cont->type !=3D type) continue; =20 - if (qemuBuildPMPCIRootHotplugCommandLine(cmd, cont)) - continue; + qemuBuildPMPCIRootHotplugCommandLine(cmd, cont); =20 if (qemuBuildSkipController(cont, def)) continue; --=20 2.25.1