From nobody Mon Feb 9 17:35:05 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1634833556; cv=none; d=zohomail.com; s=zohoarc; b=nHAwYhVRUr+XubuRC7TaHwQb9SUiLN1ScsV6iMihhwIrKHvlVK2Drrzu0GXSTnE7DubqdYLw5GDgiZS+AumuYdsGMUzwvGzVUOhZ86zc8n5cJW9TpSrMIeHWLHcgyAN9yw4KUbEJJiQls+xAjWi7qtK/R55NH8YeScfrEqylpRE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1634833556; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=g3fD+OpyMmZzk864bDGjXSOBTkI+/hT0QiVYFIWfBH4=; b=Y1p54ABLf0lyrntaWP0fn/aPNHlAO/OpkZQPRNd2d0j8jjatlVLWhuhAvPvjVTbXNjz4jvX/oRL6p42lMQKglNJXmfBDLP5+pHANceO2F5L1hMe2iO+DJrt0kPtlvs7CRU738+q210bmAfU953msa7GooVK7DJv7evDOtUJJEsw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1634833556732382.33967815718574; Thu, 21 Oct 2021 09:25:56 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-576-fl_vZzjnOTicTw9mGn9IWg-1; Thu, 21 Oct 2021 12:25:52 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7108B107B106; Thu, 21 Oct 2021 16:25:43 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 50CBC5FC22; Thu, 21 Oct 2021 16:25:43 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 1A1F21832DD5; Thu, 21 Oct 2021 16:25:43 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 19LGPZ6l006591 for ; Thu, 21 Oct 2021 12:25:35 -0400 Received: by smtp.corp.redhat.com (Postfix) id BDECF5F4F5; Thu, 21 Oct 2021 16:25:35 +0000 (UTC) Received: from vhost3.router.laine.org (ovpn-114-79.phx2.redhat.com [10.3.114.79]) by smtp.corp.redhat.com (Postfix) with ESMTP id F32AB18428; Thu, 21 Oct 2021 16:25:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634833555; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=g3fD+OpyMmZzk864bDGjXSOBTkI+/hT0QiVYFIWfBH4=; b=B4Mdlp2rJF76fLwEDuIkvqYKFJTOEgWivTY+fOuAnapESsDpYZR9U+mLozdd3LhpNNfrrM setW6oELsV9Zizm44W+LPq6V4uNLQRJjnpsJ5c333y9KXLud9uJE6MPTuMC0lXhnrAt7jf cehsuo99dI0H1mRTObpL2KM1qYLhMe0= X-MC-Unique: fl_vZzjnOTicTw9mGn9IWg-1 From: Laine Stump To: libvir-list@redhat.com Subject: [libvirt PATCH 06/10] Revert "qemuValidateDomainDefPCIFeature: un-break error messages" Date: Thu, 21 Oct 2021 12:24:56 -0400 Message-Id: <20211021162500.1295221-7-laine@redhat.com> In-Reply-To: <20211021162500.1295221-1-laine@redhat.com> References: <20211021162500.1295221-1-laine@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Cc: Ani Sinha , Igor Mammedov , Julia Suvorova , Michael Tsirkin X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1634833558266100001 Content-Type: text/plain; charset="utf-8" This reverts commit 7d074c56830c5d435f87667299cc102650dbbb4f. Signed-off-by: Laine Stump --- src/qemu/qemu_validate.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index d3b9691db5..0cb4542efd 100644 --- a/src/qemu/qemu_validate.c +++ b/src/qemu/qemu_validate.c @@ -194,7 +194,8 @@ qemuValidateDomainDefPCIFeature(const virDomainDef *def, case VIR_DOMAIN_PCI_ACPI_BRIDGE_HOTPLUG: if (!ARCH_IS_X86(def->os.arch)) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("acpi-bridge-hotplug is not available= for architecture '%s'"), + _("acpi-bridge-hotplug is not available= " + "for architecture '%s'"), virArchToString(def->os.arch)); return -1; } @@ -202,7 +203,8 @@ qemuValidateDomainDefPCIFeature(const virDomainDef *def, !virQEMUCapsGet(qemuCaps, QEMU_CAPS_PIIX4_ACPI_HOTPLUG_BRIDGE)) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("acpi-bridge-hotplug is not available= with this QEMU binary")); + _("acpi-bridge-hotplug is not available= " + "with this QEMU binary")); return -1; } break; --=20 2.31.1