From nobody Sat May 4 19:25:38 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1634292742147527.3560790285397; Fri, 15 Oct 2021 03:12:22 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-568-GsAJYuiaM--nGGf-v7CvTg-1; Fri, 15 Oct 2021 06:12:19 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5167D5074B; Fri, 15 Oct 2021 10:12:14 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2CA2A5C1BB; Fri, 15 Oct 2021 10:12:14 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id D3073180598A; Fri, 15 Oct 2021 10:12:13 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 19FACB8Q004241 for ; Fri, 15 Oct 2021 06:12:12 -0400 Received: by smtp.corp.redhat.com (Postfix) id AF5CF40CFD11; Fri, 15 Oct 2021 10:12:11 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast05.extmail.prod.ext.rdu2.redhat.com [10.11.55.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A96A440CFD0D for ; Fri, 15 Oct 2021 10:12:11 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9035D8001EA for ; Fri, 15 Oct 2021 10:12:11 +0000 (UTC) Received: from corp-ob08.yahoo-corp.jp (corp-ob08.yahoo-corp.jp [183.79.94.93]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-142-9dEudMSHPCu7LEScONAK1w-1; Fri, 15 Oct 2021 06:12:09 -0400 Received: from JPN01-OS2-obe.outbound.protection.outlook.com (mail-os2jpn01lp2054.outbound.protection.outlook.com [104.47.92.54]) by corp-ob08.yahoo-corp.jp (Postfix) with ESMTPS id C04A31A49B04 for ; Fri, 15 Oct 2021 19:12:06 +0900 (JST) Received: from TYCPR01MB7919.jpnprd01.prod.outlook.com (2603:1096:400:186::10) by TYWPR01MB8696.jpnprd01.prod.outlook.com (2603:1096:400:17c::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.22; Fri, 15 Oct 2021 10:12:06 +0000 Received: from TYCPR01MB7919.jpnprd01.prod.outlook.com ([fe80::e075:693b:905:bb22]) by TYCPR01MB7919.jpnprd01.prod.outlook.com ([fe80::e075:693b:905:bb22%9]) with mapi id 15.20.4608.017; Fri, 15 Oct 2021 10:12:06 +0000 Received: from R-SUR-LBA-2603.yahoo.co.jp (211.14.8.148) by TYCPR01CA0082.jpnprd01.prod.outlook.com (2603:1096:405:3::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15 via Frontend Transport; Fri, 15 Oct 2021 10:12:05 +0000 X-MC-Unique: GsAJYuiaM--nGGf-v7CvTg-1 X-MC-Unique: 9dEudMSHPCu7LEScONAK1w-1 From: Hiroki Narukawa To: libvir-list@redhat.com Subject: [PATCH 1/1] qemu_validate: Fix capability check for disk queue_size Date: Fri, 15 Oct 2021 19:11:49 +0900 Message-Id: <20211015101149.3915-2-hnarukaw@yahoo-corp.jp> In-Reply-To: <20211015101149.3915-1-hnarukaw@yahoo-corp.jp> References: <20211015101149.3915-1-hnarukaw@yahoo-corp.jp> X-ClientProxiedBy: TYCPR01CA0082.jpnprd01.prod.outlook.com (2603:1096:405:3::22) To TYCPR01MB7919.jpnprd01.prod.outlook.com (2603:1096:400:186::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7fda2f25-1b54-460e-34cb-08d98fc43da3 X-MS-TrafficTypeDiagnostic: TYWPR01MB8696: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:260 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0 X-Microsoft-Antispam-Message-Info: LMHdXdmGj7HC1oMBuGFtrpGbDGNRbMgj+dF71PI6lZVjgug3p2N7u5jVDa2o3KmF6+YP0ciiDSq91r8yNSQwKQd3WWuN4OoR9/7gsKsfsAKJz4pvssHmmpJvSuQ+5HGHBcXGs4XBkPuquHfst9rrpUxsimSsqQn6DXvV9U3yAYxv2kmI1r5+L/4gCdcPmE2JeREKSoflFS9HIOauQIgUPGUSxXRoSNsAJ7vb2F1LW2UWQYB8q2rZzocYBqshnshQ4uyXw1qFOUY92CwQ+95J2pwKdkFaV5oebVfG+yqOVEAgUdrknVSpJpemkEj2OpqSjFAmF7De2OUuGUkxouJO0xDxLdEEPRhOAVLRHVVZj7YaZM3hJWKDR6C6D5AIEXK02T6fXljSRL6ysWnAxJxwtyYImTayk9bjUfDb9gIydF1kI4M+b3aZlgv8Lx4DPQG7P9foscWKUTxKYYjIxLz9zFg5S55iVMa/SWyE7MZTPrLTXrkN0iBBNP+lRKen5nAnPYaCAmQhcRtSt9bqyCxj+zSSY5+fUgGM/63IVZkQvtb4e5OzlMuwdhfr6PwL5fFvQx3r3lQrYIDXKbfHctjMOmTAqg6pci943J6+8DX2YorYqjJF77v2rFM0mLDKkZ9XbF6DWigkK8nU9gUjIIQFUqZumGvbTufFzFwwhJuxFCFzw8VLcclemCbhDtyEM/lXYNRVuChysWSKoVjbFcYVmQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TYCPR01MB7919.jpnprd01.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(82960400001)(508600001)(66556008)(4326008)(107886003)(4744005)(66946007)(26005)(2616005)(66476007)(6486002)(8936002)(6916009)(83380400001)(6506007)(1076003)(6666004)(36756003)(8676002)(38350700002)(86362001)(52116002)(316002)(38100700002)(186003)(2906002)(5660300002)(6512007)(956004); DIR:OUT; SFP:1102 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?mCNyqYosZQlyScTk7XS7uSJMVPrWVsA4eHXUmuiORNu9R8gU6VAXntEQPN84?= =?us-ascii?Q?M3qBtk05E2+aVgpNlO960uIbCWoxpZyQzG51LLrH7wFzslpI8ftFBm0yQUce?= =?us-ascii?Q?pD+rhhFJrJYxpBtAwMRq80yVOfvNZ+jj+izxG78czU4hPaRu/x1cCerYQypo?= =?us-ascii?Q?JItpZYhNbOslx/xqpFtnUI3f5+1Wt5I5hvL7qA4Vh1LCWYkHHOFLT3UxrthS?= =?us-ascii?Q?97D5GYHhpfLahRMOf/50q+Bx5RyLCbQlA4BVYs3TRTrNu9TTjybH1p40odo1?= =?us-ascii?Q?63Cz2ipBxEsUpsCZltXMEpmubExsgKhmfEWDHGL623rLOVFW5cXS/LhP9FA9?= =?us-ascii?Q?f2OUPYpwPn4RqL/t0dMEAZY9FugidsqVOmLetA+FGDyI3pEmcUyBuLnWcEJo?= =?us-ascii?Q?MohpSF2gP5CSlnF3zG0fSNppcYvNGXI+hDqRQimqbM/KCiRgmDiyeH2HL5BS?= =?us-ascii?Q?IFbFhjBrfmqoG2fvrgUaPQw10Jp+vcMqEc6QmCxzEvaZ/DWXmGCsHKAiC4uc?= =?us-ascii?Q?luBlgnvSrVpMFuqA6/ixExXIjceS2A8U0LMzdLHs2P/iGCnAMD/vRkj7V6lI?= =?us-ascii?Q?x4Y5VH9XGEXjf3zuSBI6ij0upLLLl03YYm7mc6yMDZjv7nM6SQn/l19nU4OX?= =?us-ascii?Q?dJNZLoMZa6rdU06zqgdQXLmbbZUZu/AfYqr9mTqOpTcLz3SbIVdXakuBVqBg?= =?us-ascii?Q?xNaukLNAAZTFEwkntqBwAbjr3NClm9jWWdbb42F4/7RqlTaiX9wnx3+0Fjew?= =?us-ascii?Q?2gzZ6ZJa5Tt7WrdQZRXtL1FKUfNeXkPslNPwMuBjnjrEo4n5i+2msfPXAh/1?= =?us-ascii?Q?8/ZdupqhONjHvX2B1ZpdvIgFK3xbb/hZcPbnT2kkNY//svkumAI4WozqW55D?= =?us-ascii?Q?K8UiFJr02iVCJfeI07bOAHy6t6wgBGZ/W5sXhv+V1zoLXtVtlJmYoXKEVz1R?= =?us-ascii?Q?uTfmKHflb8p9dCMGIa5J2XJ9/ATKcmQqVGqW/OcQE4BjgOSjhAkVXsrmi2gE?= =?us-ascii?Q?8/6ARdGQHS90zDt2bsN/ClXHtKj6v/i9CAQL9rgKUci93eDBQWB8gez7mh3V?= =?us-ascii?Q?XWUC9w7nMGzghFU/yt0UDeoQ36ioS48cRTug+GdgKHT7NcmBbxlf7M8ruV8h?= =?us-ascii?Q?JXqaudUNbTeemwEi8hsPqXSOHeTxTLGjicLsSKRZjh8k1kAlzDQCUDn6dhVN?= =?us-ascii?Q?ZaOIC74mm7Aglwe4tr9RknYjoPHghwvGXIVml40z0sC9ojHonYR2RRtV1KaW?= =?us-ascii?Q?6yc23FLQbxNjJ0+tHZC4qaAwKZrK3LJ7ZzPVZlmXrxNlxU80MGwsfFaifJ13?= =?us-ascii?Q?j/6F+ojzOM96BGidKPCzyP61?= X-OriginatorOrg: yahoo-corp.jp X-MS-Exchange-CrossTenant-Network-Message-Id: 7fda2f25-1b54-460e-34cb-08d98fc43da3 X-MS-Exchange-CrossTenant-AuthSource: TYCPR01MB7919.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 10:12:06.1686 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a208d369-cd4e-4f87-b119-98eaf31df2c3 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YO/WqmYTgQ1a4Y3povFvhbaf5W0w8apktnbJqUvp+0ocuHwfH9H7ZeNY8i/ZBxuwuTFQzumD0ZbWkAHoy34LjA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYWPR01MB8696 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1 X-loop: libvir-list@redhat.com Cc: aoiwa@yahoo-corp.jp, Hiroki Narukawa X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-ZM-MESSAGEID: 1634292744686100001 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Commit ad209e7d adds QEMU_CAPS_VIRTIO_BLK_QUEUE_SIZE capability, but the following commit 2d6d67e1 missed to use it and uses QEMU_CAPS_VIRTIO_BLK_NUM_QUEUES instead. This commit fixes the mistake. Signed-off-by: Hiroki Narukawa Reviewed-by: Michal Privoznik --- src/qemu/qemu_validate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index 4a82b512d1..e87a5fc65e 100644 --- a/src/qemu/qemu_validate.c +++ b/src/qemu/qemu_validate.c @@ -2861,7 +2861,7 @@ qemuValidateDomainDeviceDefDiskFrontend(const virDoma= inDiskDef *disk, return -1; } if (disk->queue_size > 0 && - !virQEMUCapsGet(qemuCaps, QEMU_CAPS_VIRTIO_BLK_NUM_QUEUES)) { + !virQEMUCapsGet(qemuCaps, QEMU_CAPS_VIRTIO_BLK_QUEUE_SIZE)) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", _("queue-size property isn't supported by this = QEMU binary")); return -1; --=20 2.17.1