From nobody Tue Feb 10 11:56:26 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1634291545382161.81961356371198; Fri, 15 Oct 2021 02:52:25 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-341-RCo8-GETN1aqyvhWiuEQ2Q-1; Fri, 15 Oct 2021 05:52:21 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 203D7801AFC; Fri, 15 Oct 2021 09:52:16 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EC37460E1C; Fri, 15 Oct 2021 09:52:15 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id D65034E9E2; Fri, 15 Oct 2021 09:52:14 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 19F9nrkb000669 for ; Fri, 15 Oct 2021 05:49:53 -0400 Received: by smtp.corp.redhat.com (Postfix) id 7B1942026D46; Fri, 15 Oct 2021 09:49:53 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast01.extmail.prod.ext.rdu2.redhat.com [10.11.55.17]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 758192026D48 for ; Fri, 15 Oct 2021 09:49:50 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9DA3C899EC0 for ; Fri, 15 Oct 2021 09:49:50 +0000 (UTC) Received: from corp-ob07.yahoo-corp.jp (corp-ob07.yahoo-corp.jp [183.79.94.94]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-493-FT7kp2C3NUiXHRLSfT-n1g-1; Fri, 15 Oct 2021 05:49:45 -0400 Received: from JPN01-OS2-obe.outbound.protection.outlook.com (mail-os2jpn01lp2055.outbound.protection.outlook.com [104.47.92.55]) by corp-ob07.yahoo-corp.jp (Postfix) with ESMTPS id 0ABF619FB186 for ; Fri, 15 Oct 2021 18:49:42 +0900 (JST) Received: from TYCPR01MB7919.jpnprd01.prod.outlook.com (2603:1096:400:186::10) by TYCPR01MB8176.jpnprd01.prod.outlook.com (2603:1096:400:105::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.14; Fri, 15 Oct 2021 09:49:41 +0000 Received: from TYCPR01MB7919.jpnprd01.prod.outlook.com ([fe80::e075:693b:905:bb22]) by TYCPR01MB7919.jpnprd01.prod.outlook.com ([fe80::e075:693b:905:bb22%9]) with mapi id 15.20.4608.017; Fri, 15 Oct 2021 09:49:41 +0000 Received: from R-SUR-LBA-2603.yahoo.co.jp (211.14.8.148) by TY2PR02CA0018.apcprd02.prod.outlook.com (2603:1096:404:56::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16 via Frontend Transport; Fri, 15 Oct 2021 09:49:41 +0000 X-MC-Unique: RCo8-GETN1aqyvhWiuEQ2Q-1 X-MC-Unique: FT7kp2C3NUiXHRLSfT-n1g-1 From: Hiroki Narukawa To: libvir-list@redhat.com Subject: [PATCH 1/4] qemu_capabilities: Add QEMU_CAPS_QUERY_DIRTY_RATE capability Date: Fri, 15 Oct 2021 18:49:17 +0900 Message-Id: <20211015094920.3658-2-hnarukaw@yahoo-corp.jp> In-Reply-To: <20211015094920.3658-1-hnarukaw@yahoo-corp.jp> References: <20211015094920.3658-1-hnarukaw@yahoo-corp.jp> X-ClientProxiedBy: TY2PR02CA0018.apcprd02.prod.outlook.com (2603:1096:404:56::30) To TYCPR01MB7919.jpnprd01.prod.outlook.com (2603:1096:400:186::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c641be2f-ff36-4956-281e-08d98fc11c00 X-MS-TrafficTypeDiagnostic: TYCPR01MB8176: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:13 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0 X-Microsoft-Antispam-Message-Info: 7Z+yNalpiQ+jIXYGvYSYtMneZ6LTQY9P3tcjYY6JB93Abek6Ml+jjZTG1LG+2Q57l4waygiqQ2Zdt2wwfmXNq37huwRFe3x7ED0M8eGr3V86R3Thuycm//aIJ6qDb5I7Cm6ka+evzP9oRMMyzCsiNsVfl4UPDuKjknr0VzB/PmUJ1XoWVkUFDp+AFN0jz9HociPVMmive1SFdyXlsOe0K1N65Z62ROjuMwnWxSuB2zxKgDkJpm9Le1Pbm4swXtRKP3HcK2ZqbAG5Togy7+aIycBb622hlTdChntOygGfahk7Coexgp4xcC/C6GAyDNrxe6k1FV+MKc6dgQHxDs6gqBsEyH6xS/131BAaHBxr0NxRMQ32tMfXKlj2LYQQ/xeO+jY1U6dVSWw2heNCP37NX4bK/WBXjbPJw4lHapWq9ZHL9nsXtIjOlIYC2Q8D5+DNy7kFt1mhQmh/xPP0JlXK2UoFQYtfSC8JESHXcvIil9KGGZ9sINgwoiGK2Gju1rKkBopKnpmdadjW//JXhmbqGxF9u+2Y3TTOjJlBeHpWHH6LWIVV4M0KVsCq4jwNmWxIb8AWTe5l/D86+e54U9cDUto1tX7lX3GkBbmKKZtGibUSMB/PrbSZXwYvDFxNwEJyH4Tf6Ot5k89JvvPfB60xsOjhy6bnG2cIOoWuiomX/D5IerXQO+JsWWSiEyTERsxabu/N+t1mol3GxAGD8lRCsS3Wy6875TFoChXtdXzn6Kg= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TYCPR01MB7919.jpnprd01.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(26005)(83380400001)(6506007)(6486002)(6512007)(107886003)(52116002)(86362001)(8936002)(36756003)(5660300002)(186003)(4326008)(1076003)(508600001)(956004)(6666004)(38350700002)(66556008)(38100700002)(66476007)(8676002)(2906002)(66946007)(82960400001)(316002)(6916009)(2616005)(14143004); DIR:OUT; SFP:1102 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?hQXA+Y6+iUPp/C7sBhV9fBxq/FDE4+R6CumyyomzDVlMJ+Y8/AOpHH1FCHPo?= =?us-ascii?Q?u8XTG7wvq+24EIczVkE3+U+WTssIKzmC+wg3a+m/5cdiv1pdpDboy3kBzbWj?= =?us-ascii?Q?L5aC0xxfcMMk2tQivtbhjU2GGnqQHkkosnTYO4gTbBgcg9mDw1C+rkX3PeQX?= =?us-ascii?Q?W+Pa4rUi5IFIRMmJiNoJD7VJUuz3YGUqRBHDUgUSwSDURjpVOHTjtxWOm5PM?= =?us-ascii?Q?7m6yGb3wJx2QvSFHzBrt3GzEvF0KaBYqA10Ali1x9Jk8U2qZyT2NpyOab2+6?= =?us-ascii?Q?zQ5AH+u7qVAu9t6UL4Cooqs+t3epwBn0GNxQiz3aprSwOBNQ2xnxHWTCobcG?= =?us-ascii?Q?AuaT+9qnQddz+ZcmDcalijdn5nrEhQkn0KhopOT3QDzs55BpgfbjjJGJMakg?= =?us-ascii?Q?wchS+HemAkFT8dPSNKsU1OMqCHdIwuWHhhZvJwIBjn9HskhcChYLm7TQ6PHk?= =?us-ascii?Q?iip7teWI2CwvBRaEICUIATp4iXNaZn1bdVxUkF9qobtvXYahRNqg6CrAhm0u?= =?us-ascii?Q?RBXH3Fty8PpVkuHtPBrJUic20muYMmzydgY+uxEBGMSilbfLmKGf/zRdkNjk?= =?us-ascii?Q?wHfx5X0p+9z3SMVoVFnq76dYypkYXBCCTotqPi2Kmc+C0pxTnn9xH0u7m6/A?= =?us-ascii?Q?95PG1/CV13iftu8Mg5ocQ1mOtcq9iwy2g02XRW07vz/OnobnAzbEH35omISS?= =?us-ascii?Q?uS/AL0hsN/YRohFFh9ESkIDrzX0BLVlSOxMBQnP30ffplwJnJdSTXfgB+uBk?= =?us-ascii?Q?1KVRpOfd6nAHrmJ6Kpk950Zkrh9FofIWCO0NhG2KlEX67+zbUiPwiVdtiXux?= =?us-ascii?Q?m38zlqb1L2MrALYm8Qd/QpoezkJlMI/OZJFYeCCBP2gwyGLNnyIUkNhPAL9t?= =?us-ascii?Q?BhlFXJadTqW9TSIvkPjs/5bDj1tc47gr+PhiZchoEMIvUjApGjM8Y2Tp05Lh?= =?us-ascii?Q?GTvAP6pJ6P3bKzngIHbF1Ab5TONsFlnrCjusrrTJHW0k9he4OmO6r9dKFSin?= =?us-ascii?Q?wdnT8MBjYTGIviIaMmVaLTpvIwgcbKuqd0j/jqRZjdmjbsNJSDTh7flXQ9m7?= =?us-ascii?Q?c4DIHaB+0xUmf9z/ABSu6HaQM4EE696H2c9l6+Eo9J7nEXmQFYxMJdn9Yclz?= =?us-ascii?Q?29MwGja/j7j/0f8Dlu4nTH6OAVkXMbzRBvo1jJx9aDFiRsVmkyBq+WBv7/CA?= =?us-ascii?Q?n0WnLsty7fgxvatRuXkJsANQVAfwGdhSYLUVXEd35oykhBMSBBGS6FFjAOlf?= =?us-ascii?Q?AfyDFNRmRKMd10JpyX5kQLdtXBKHPstBp8XawpZEB5ken6sC3D2hdG+SrACS?= =?us-ascii?Q?PgypKyPK+3I+HK//4mlDX4B4?= X-OriginatorOrg: yahoo-corp.jp X-MS-Exchange-CrossTenant-Network-Message-Id: c641be2f-ff36-4956-281e-08d98fc11c00 X-MS-Exchange-CrossTenant-AuthSource: TYCPR01MB7919.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 09:49:41.1973 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a208d369-cd4e-4f87-b119-98eaf31df2c3 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +6ihrVAyBAi6FLpWlTN4Q1oAO7bxq+YqKQTvtxB8V3AQNO2t5JTDZXMh6UYcyCUGGsS6ND6aOJAnJzvfbB3GZQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYCPR01MB8176 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: libvir-list@redhat.com Cc: aoiwa@yahoo-corp.jp, Hiroki Narukawa X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-ZM-MESSAGEID: 1634291546833100003 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" query-dirty-rate command is used for virsh domstats by default, but this is available only on qemu >=3D5.2.0. In this commit, add capability flag for query-dirty-rate first. Signed-off-by: Hiroki Narukawa --- src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + tests/qemucapabilitiesdata/caps_5.2.0.aarch64.xml | 1 + tests/qemucapabilitiesdata/caps_5.2.0.ppc64.xml | 1 + tests/qemucapabilitiesdata/caps_5.2.0.riscv64.xml | 1 + tests/qemucapabilitiesdata/caps_5.2.0.s390x.xml | 1 + tests/qemucapabilitiesdata/caps_5.2.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_6.0.0.aarch64.xml | 1 + tests/qemucapabilitiesdata/caps_6.0.0.s390x.xml | 1 + tests/qemucapabilitiesdata/caps_6.0.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_6.1.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_6.2.0.x86_64.xml | 1 + 12 files changed, 13 insertions(+) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 32be7e67f1..9dfddd0129 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -650,6 +650,7 @@ VIR_ENUM_IMPL(virQEMUCaps, /* 415 */ "chardev.json", /* QEMU_CAPS_CHARDEV_JSON */ "device.json", /* QEMU_CAPS_DEVICE_JSON */ + "query-dirty-rate", /* QEMU_CAPS_QUERY_DIRTY_RATE */ ); =20 =20 @@ -1194,6 +1195,7 @@ struct virQEMUCapsStringFlags virQEMUCapsCommands[] = =3D { { "blockdev-reopen", QEMU_CAPS_BLOCKDEV_REOPEN }, { "set-numa-node", QEMU_CAPS_NUMA }, { "set-action", QEMU_CAPS_SET_ACTION }, + { "query-dirty-rate", QEMU_CAPS_QUERY_DIRTY_RATE }, }; =20 struct virQEMUCapsStringFlags virQEMUCapsMigration[] =3D { diff --git a/src/qemu/qemu_capabilities.h b/src/qemu/qemu_capabilities.h index 5b5215416f..6a4c5a723d 100644 --- a/src/qemu/qemu_capabilities.h +++ b/src/qemu/qemu_capabilities.h @@ -630,6 +630,7 @@ typedef enum { /* virQEMUCapsFlags grouping marker for = syntax-check */ /* 415 */ QEMU_CAPS_CHARDEV_JSON, /* -chardev accepts JSON */ QEMU_CAPS_DEVICE_JSON, /* -device accepts JSON */ + QEMU_CAPS_QUERY_DIRTY_RATE, /* accepts query-dirty-rate */ =20 QEMU_CAPS_LAST /* this must always be the last item */ } virQEMUCapsFlags; diff --git a/tests/qemucapabilitiesdata/caps_5.2.0.aarch64.xml b/tests/qemu= capabilitiesdata/caps_5.2.0.aarch64.xml index 042060235e..f1b23d7ea4 100644 --- a/tests/qemucapabilitiesdata/caps_5.2.0.aarch64.xml +++ b/tests/qemucapabilitiesdata/caps_5.2.0.aarch64.xml @@ -185,6 +185,7 @@ + 5002000 0 61700243 diff --git a/tests/qemucapabilitiesdata/caps_5.2.0.ppc64.xml b/tests/qemuca= pabilitiesdata/caps_5.2.0.ppc64.xml index 61328e1987..1c29ebd5d5 100644 --- a/tests/qemucapabilitiesdata/caps_5.2.0.ppc64.xml +++ b/tests/qemucapabilitiesdata/caps_5.2.0.ppc64.xml @@ -191,6 +191,7 @@ + 5002000 0 42900243 diff --git a/tests/qemucapabilitiesdata/caps_5.2.0.riscv64.xml b/tests/qemu= capabilitiesdata/caps_5.2.0.riscv64.xml index 5f7b02a396..06f83cf543 100644 --- a/tests/qemucapabilitiesdata/caps_5.2.0.riscv64.xml +++ b/tests/qemucapabilitiesdata/caps_5.2.0.riscv64.xml @@ -176,6 +176,7 @@ + 5002000 0 0 diff --git a/tests/qemucapabilitiesdata/caps_5.2.0.s390x.xml b/tests/qemuca= pabilitiesdata/caps_5.2.0.s390x.xml index 3c653acbde..d4466bf781 100644 --- a/tests/qemucapabilitiesdata/caps_5.2.0.s390x.xml +++ b/tests/qemucapabilitiesdata/caps_5.2.0.s390x.xml @@ -142,6 +142,7 @@ + 5002000 0 39100243 diff --git a/tests/qemucapabilitiesdata/caps_5.2.0.x86_64.xml b/tests/qemuc= apabilitiesdata/caps_5.2.0.x86_64.xml index bd2dc77d21..507b2a95a3 100644 --- a/tests/qemucapabilitiesdata/caps_5.2.0.x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_5.2.0.x86_64.xml @@ -229,6 +229,7 @@ + 5002000 0 43100243 diff --git a/tests/qemucapabilitiesdata/caps_6.0.0.aarch64.xml b/tests/qemu= capabilitiesdata/caps_6.0.0.aarch64.xml index 0c897137a4..0838f42843 100644 --- a/tests/qemucapabilitiesdata/caps_6.0.0.aarch64.xml +++ b/tests/qemucapabilitiesdata/caps_6.0.0.aarch64.xml @@ -193,6 +193,7 @@ + 6000000 0 61700242 diff --git a/tests/qemucapabilitiesdata/caps_6.0.0.s390x.xml b/tests/qemuca= pabilitiesdata/caps_6.0.0.s390x.xml index 5d75b2ef63..0e33c45539 100644 --- a/tests/qemucapabilitiesdata/caps_6.0.0.s390x.xml +++ b/tests/qemucapabilitiesdata/caps_6.0.0.s390x.xml @@ -150,6 +150,7 @@ + 6000000 0 39100242 diff --git a/tests/qemucapabilitiesdata/caps_6.0.0.x86_64.xml b/tests/qemuc= apabilitiesdata/caps_6.0.0.x86_64.xml index dc0c01c25b..9eb948002a 100644 --- a/tests/qemucapabilitiesdata/caps_6.0.0.x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_6.0.0.x86_64.xml @@ -237,6 +237,7 @@ + 6000000 0 43100242 diff --git a/tests/qemucapabilitiesdata/caps_6.1.0.x86_64.xml b/tests/qemuc= apabilitiesdata/caps_6.1.0.x86_64.xml index 871e85a2d3..2af1b1ec32 100644 --- a/tests/qemucapabilitiesdata/caps_6.1.0.x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_6.1.0.x86_64.xml @@ -241,6 +241,7 @@ + 6001000 0 43100243 diff --git a/tests/qemucapabilitiesdata/caps_6.2.0.x86_64.xml b/tests/qemuc= apabilitiesdata/caps_6.2.0.x86_64.xml index e5b9bfce0b..25eea8a486 100644 --- a/tests/qemucapabilitiesdata/caps_6.2.0.x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_6.2.0.x86_64.xml @@ -241,6 +241,7 @@ + 6001050 0 43100244 --=20 2.17.1