From nobody Sat May 4 12:02:51 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1634291545382161.81961356371198; Fri, 15 Oct 2021 02:52:25 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-341-RCo8-GETN1aqyvhWiuEQ2Q-1; Fri, 15 Oct 2021 05:52:21 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 203D7801AFC; Fri, 15 Oct 2021 09:52:16 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EC37460E1C; Fri, 15 Oct 2021 09:52:15 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id D65034E9E2; Fri, 15 Oct 2021 09:52:14 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 19F9nrkb000669 for ; Fri, 15 Oct 2021 05:49:53 -0400 Received: by smtp.corp.redhat.com (Postfix) id 7B1942026D46; Fri, 15 Oct 2021 09:49:53 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast01.extmail.prod.ext.rdu2.redhat.com [10.11.55.17]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 758192026D48 for ; Fri, 15 Oct 2021 09:49:50 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9DA3C899EC0 for ; Fri, 15 Oct 2021 09:49:50 +0000 (UTC) Received: from corp-ob07.yahoo-corp.jp (corp-ob07.yahoo-corp.jp [183.79.94.94]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-493-FT7kp2C3NUiXHRLSfT-n1g-1; Fri, 15 Oct 2021 05:49:45 -0400 Received: from JPN01-OS2-obe.outbound.protection.outlook.com (mail-os2jpn01lp2055.outbound.protection.outlook.com [104.47.92.55]) by corp-ob07.yahoo-corp.jp (Postfix) with ESMTPS id 0ABF619FB186 for ; Fri, 15 Oct 2021 18:49:42 +0900 (JST) Received: from TYCPR01MB7919.jpnprd01.prod.outlook.com (2603:1096:400:186::10) by TYCPR01MB8176.jpnprd01.prod.outlook.com (2603:1096:400:105::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.14; Fri, 15 Oct 2021 09:49:41 +0000 Received: from TYCPR01MB7919.jpnprd01.prod.outlook.com ([fe80::e075:693b:905:bb22]) by TYCPR01MB7919.jpnprd01.prod.outlook.com ([fe80::e075:693b:905:bb22%9]) with mapi id 15.20.4608.017; Fri, 15 Oct 2021 09:49:41 +0000 Received: from R-SUR-LBA-2603.yahoo.co.jp (211.14.8.148) by TY2PR02CA0018.apcprd02.prod.outlook.com (2603:1096:404:56::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16 via Frontend Transport; Fri, 15 Oct 2021 09:49:41 +0000 X-MC-Unique: RCo8-GETN1aqyvhWiuEQ2Q-1 X-MC-Unique: FT7kp2C3NUiXHRLSfT-n1g-1 From: Hiroki Narukawa To: libvir-list@redhat.com Subject: [PATCH 1/4] qemu_capabilities: Add QEMU_CAPS_QUERY_DIRTY_RATE capability Date: Fri, 15 Oct 2021 18:49:17 +0900 Message-Id: <20211015094920.3658-2-hnarukaw@yahoo-corp.jp> In-Reply-To: <20211015094920.3658-1-hnarukaw@yahoo-corp.jp> References: <20211015094920.3658-1-hnarukaw@yahoo-corp.jp> X-ClientProxiedBy: TY2PR02CA0018.apcprd02.prod.outlook.com (2603:1096:404:56::30) To TYCPR01MB7919.jpnprd01.prod.outlook.com (2603:1096:400:186::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c641be2f-ff36-4956-281e-08d98fc11c00 X-MS-TrafficTypeDiagnostic: TYCPR01MB8176: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:13 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0 X-Microsoft-Antispam-Message-Info: 7Z+yNalpiQ+jIXYGvYSYtMneZ6LTQY9P3tcjYY6JB93Abek6Ml+jjZTG1LG+2Q57l4waygiqQ2Zdt2wwfmXNq37huwRFe3x7ED0M8eGr3V86R3Thuycm//aIJ6qDb5I7Cm6ka+evzP9oRMMyzCsiNsVfl4UPDuKjknr0VzB/PmUJ1XoWVkUFDp+AFN0jz9HociPVMmive1SFdyXlsOe0K1N65Z62ROjuMwnWxSuB2zxKgDkJpm9Le1Pbm4swXtRKP3HcK2ZqbAG5Togy7+aIycBb622hlTdChntOygGfahk7Coexgp4xcC/C6GAyDNrxe6k1FV+MKc6dgQHxDs6gqBsEyH6xS/131BAaHBxr0NxRMQ32tMfXKlj2LYQQ/xeO+jY1U6dVSWw2heNCP37NX4bK/WBXjbPJw4lHapWq9ZHL9nsXtIjOlIYC2Q8D5+DNy7kFt1mhQmh/xPP0JlXK2UoFQYtfSC8JESHXcvIil9KGGZ9sINgwoiGK2Gju1rKkBopKnpmdadjW//JXhmbqGxF9u+2Y3TTOjJlBeHpWHH6LWIVV4M0KVsCq4jwNmWxIb8AWTe5l/D86+e54U9cDUto1tX7lX3GkBbmKKZtGibUSMB/PrbSZXwYvDFxNwEJyH4Tf6Ot5k89JvvPfB60xsOjhy6bnG2cIOoWuiomX/D5IerXQO+JsWWSiEyTERsxabu/N+t1mol3GxAGD8lRCsS3Wy6875TFoChXtdXzn6Kg= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TYCPR01MB7919.jpnprd01.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(26005)(83380400001)(6506007)(6486002)(6512007)(107886003)(52116002)(86362001)(8936002)(36756003)(5660300002)(186003)(4326008)(1076003)(508600001)(956004)(6666004)(38350700002)(66556008)(38100700002)(66476007)(8676002)(2906002)(66946007)(82960400001)(316002)(6916009)(2616005)(14143004); DIR:OUT; SFP:1102 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?hQXA+Y6+iUPp/C7sBhV9fBxq/FDE4+R6CumyyomzDVlMJ+Y8/AOpHH1FCHPo?= =?us-ascii?Q?u8XTG7wvq+24EIczVkE3+U+WTssIKzmC+wg3a+m/5cdiv1pdpDboy3kBzbWj?= =?us-ascii?Q?L5aC0xxfcMMk2tQivtbhjU2GGnqQHkkosnTYO4gTbBgcg9mDw1C+rkX3PeQX?= =?us-ascii?Q?W+Pa4rUi5IFIRMmJiNoJD7VJUuz3YGUqRBHDUgUSwSDURjpVOHTjtxWOm5PM?= =?us-ascii?Q?7m6yGb3wJx2QvSFHzBrt3GzEvF0KaBYqA10Ali1x9Jk8U2qZyT2NpyOab2+6?= =?us-ascii?Q?zQ5AH+u7qVAu9t6UL4Cooqs+t3epwBn0GNxQiz3aprSwOBNQ2xnxHWTCobcG?= =?us-ascii?Q?AuaT+9qnQddz+ZcmDcalijdn5nrEhQkn0KhopOT3QDzs55BpgfbjjJGJMakg?= =?us-ascii?Q?wchS+HemAkFT8dPSNKsU1OMqCHdIwuWHhhZvJwIBjn9HskhcChYLm7TQ6PHk?= =?us-ascii?Q?iip7teWI2CwvBRaEICUIATp4iXNaZn1bdVxUkF9qobtvXYahRNqg6CrAhm0u?= =?us-ascii?Q?RBXH3Fty8PpVkuHtPBrJUic20muYMmzydgY+uxEBGMSilbfLmKGf/zRdkNjk?= =?us-ascii?Q?wHfx5X0p+9z3SMVoVFnq76dYypkYXBCCTotqPi2Kmc+C0pxTnn9xH0u7m6/A?= =?us-ascii?Q?95PG1/CV13iftu8Mg5ocQ1mOtcq9iwy2g02XRW07vz/OnobnAzbEH35omISS?= =?us-ascii?Q?uS/AL0hsN/YRohFFh9ESkIDrzX0BLVlSOxMBQnP30ffplwJnJdSTXfgB+uBk?= =?us-ascii?Q?1KVRpOfd6nAHrmJ6Kpk950Zkrh9FofIWCO0NhG2KlEX67+zbUiPwiVdtiXux?= =?us-ascii?Q?m38zlqb1L2MrALYm8Qd/QpoezkJlMI/OZJFYeCCBP2gwyGLNnyIUkNhPAL9t?= =?us-ascii?Q?BhlFXJadTqW9TSIvkPjs/5bDj1tc47gr+PhiZchoEMIvUjApGjM8Y2Tp05Lh?= =?us-ascii?Q?GTvAP6pJ6P3bKzngIHbF1Ab5TONsFlnrCjusrrTJHW0k9he4OmO6r9dKFSin?= =?us-ascii?Q?wdnT8MBjYTGIviIaMmVaLTpvIwgcbKuqd0j/jqRZjdmjbsNJSDTh7flXQ9m7?= =?us-ascii?Q?c4DIHaB+0xUmf9z/ABSu6HaQM4EE696H2c9l6+Eo9J7nEXmQFYxMJdn9Yclz?= =?us-ascii?Q?29MwGja/j7j/0f8Dlu4nTH6OAVkXMbzRBvo1jJx9aDFiRsVmkyBq+WBv7/CA?= =?us-ascii?Q?n0WnLsty7fgxvatRuXkJsANQVAfwGdhSYLUVXEd35oykhBMSBBGS6FFjAOlf?= =?us-ascii?Q?AfyDFNRmRKMd10JpyX5kQLdtXBKHPstBp8XawpZEB5ken6sC3D2hdG+SrACS?= =?us-ascii?Q?PgypKyPK+3I+HK//4mlDX4B4?= X-OriginatorOrg: yahoo-corp.jp X-MS-Exchange-CrossTenant-Network-Message-Id: c641be2f-ff36-4956-281e-08d98fc11c00 X-MS-Exchange-CrossTenant-AuthSource: TYCPR01MB7919.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 09:49:41.1973 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a208d369-cd4e-4f87-b119-98eaf31df2c3 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +6ihrVAyBAi6FLpWlTN4Q1oAO7bxq+YqKQTvtxB8V3AQNO2t5JTDZXMh6UYcyCUGGsS6ND6aOJAnJzvfbB3GZQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYCPR01MB8176 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: libvir-list@redhat.com Cc: aoiwa@yahoo-corp.jp, Hiroki Narukawa X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-ZM-MESSAGEID: 1634291546833100003 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" query-dirty-rate command is used for virsh domstats by default, but this is available only on qemu >=3D5.2.0. In this commit, add capability flag for query-dirty-rate first. Signed-off-by: Hiroki Narukawa Reviewed-by: Michal Privoznik --- src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + tests/qemucapabilitiesdata/caps_5.2.0.aarch64.xml | 1 + tests/qemucapabilitiesdata/caps_5.2.0.ppc64.xml | 1 + tests/qemucapabilitiesdata/caps_5.2.0.riscv64.xml | 1 + tests/qemucapabilitiesdata/caps_5.2.0.s390x.xml | 1 + tests/qemucapabilitiesdata/caps_5.2.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_6.0.0.aarch64.xml | 1 + tests/qemucapabilitiesdata/caps_6.0.0.s390x.xml | 1 + tests/qemucapabilitiesdata/caps_6.0.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_6.1.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_6.2.0.x86_64.xml | 1 + 12 files changed, 13 insertions(+) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 32be7e67f1..9dfddd0129 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -650,6 +650,7 @@ VIR_ENUM_IMPL(virQEMUCaps, /* 415 */ "chardev.json", /* QEMU_CAPS_CHARDEV_JSON */ "device.json", /* QEMU_CAPS_DEVICE_JSON */ + "query-dirty-rate", /* QEMU_CAPS_QUERY_DIRTY_RATE */ ); =20 =20 @@ -1194,6 +1195,7 @@ struct virQEMUCapsStringFlags virQEMUCapsCommands[] = =3D { { "blockdev-reopen", QEMU_CAPS_BLOCKDEV_REOPEN }, { "set-numa-node", QEMU_CAPS_NUMA }, { "set-action", QEMU_CAPS_SET_ACTION }, + { "query-dirty-rate", QEMU_CAPS_QUERY_DIRTY_RATE }, }; =20 struct virQEMUCapsStringFlags virQEMUCapsMigration[] =3D { diff --git a/src/qemu/qemu_capabilities.h b/src/qemu/qemu_capabilities.h index 5b5215416f..6a4c5a723d 100644 --- a/src/qemu/qemu_capabilities.h +++ b/src/qemu/qemu_capabilities.h @@ -630,6 +630,7 @@ typedef enum { /* virQEMUCapsFlags grouping marker for = syntax-check */ /* 415 */ QEMU_CAPS_CHARDEV_JSON, /* -chardev accepts JSON */ QEMU_CAPS_DEVICE_JSON, /* -device accepts JSON */ + QEMU_CAPS_QUERY_DIRTY_RATE, /* accepts query-dirty-rate */ =20 QEMU_CAPS_LAST /* this must always be the last item */ } virQEMUCapsFlags; diff --git a/tests/qemucapabilitiesdata/caps_5.2.0.aarch64.xml b/tests/qemu= capabilitiesdata/caps_5.2.0.aarch64.xml index 042060235e..f1b23d7ea4 100644 --- a/tests/qemucapabilitiesdata/caps_5.2.0.aarch64.xml +++ b/tests/qemucapabilitiesdata/caps_5.2.0.aarch64.xml @@ -185,6 +185,7 @@ + 5002000 0 61700243 diff --git a/tests/qemucapabilitiesdata/caps_5.2.0.ppc64.xml b/tests/qemuca= pabilitiesdata/caps_5.2.0.ppc64.xml index 61328e1987..1c29ebd5d5 100644 --- a/tests/qemucapabilitiesdata/caps_5.2.0.ppc64.xml +++ b/tests/qemucapabilitiesdata/caps_5.2.0.ppc64.xml @@ -191,6 +191,7 @@ + 5002000 0 42900243 diff --git a/tests/qemucapabilitiesdata/caps_5.2.0.riscv64.xml b/tests/qemu= capabilitiesdata/caps_5.2.0.riscv64.xml index 5f7b02a396..06f83cf543 100644 --- a/tests/qemucapabilitiesdata/caps_5.2.0.riscv64.xml +++ b/tests/qemucapabilitiesdata/caps_5.2.0.riscv64.xml @@ -176,6 +176,7 @@ + 5002000 0 0 diff --git a/tests/qemucapabilitiesdata/caps_5.2.0.s390x.xml b/tests/qemuca= pabilitiesdata/caps_5.2.0.s390x.xml index 3c653acbde..d4466bf781 100644 --- a/tests/qemucapabilitiesdata/caps_5.2.0.s390x.xml +++ b/tests/qemucapabilitiesdata/caps_5.2.0.s390x.xml @@ -142,6 +142,7 @@ + 5002000 0 39100243 diff --git a/tests/qemucapabilitiesdata/caps_5.2.0.x86_64.xml b/tests/qemuc= apabilitiesdata/caps_5.2.0.x86_64.xml index bd2dc77d21..507b2a95a3 100644 --- a/tests/qemucapabilitiesdata/caps_5.2.0.x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_5.2.0.x86_64.xml @@ -229,6 +229,7 @@ + 5002000 0 43100243 diff --git a/tests/qemucapabilitiesdata/caps_6.0.0.aarch64.xml b/tests/qemu= capabilitiesdata/caps_6.0.0.aarch64.xml index 0c897137a4..0838f42843 100644 --- a/tests/qemucapabilitiesdata/caps_6.0.0.aarch64.xml +++ b/tests/qemucapabilitiesdata/caps_6.0.0.aarch64.xml @@ -193,6 +193,7 @@ + 6000000 0 61700242 diff --git a/tests/qemucapabilitiesdata/caps_6.0.0.s390x.xml b/tests/qemuca= pabilitiesdata/caps_6.0.0.s390x.xml index 5d75b2ef63..0e33c45539 100644 --- a/tests/qemucapabilitiesdata/caps_6.0.0.s390x.xml +++ b/tests/qemucapabilitiesdata/caps_6.0.0.s390x.xml @@ -150,6 +150,7 @@ + 6000000 0 39100242 diff --git a/tests/qemucapabilitiesdata/caps_6.0.0.x86_64.xml b/tests/qemuc= apabilitiesdata/caps_6.0.0.x86_64.xml index dc0c01c25b..9eb948002a 100644 --- a/tests/qemucapabilitiesdata/caps_6.0.0.x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_6.0.0.x86_64.xml @@ -237,6 +237,7 @@ + 6000000 0 43100242 diff --git a/tests/qemucapabilitiesdata/caps_6.1.0.x86_64.xml b/tests/qemuc= apabilitiesdata/caps_6.1.0.x86_64.xml index 871e85a2d3..2af1b1ec32 100644 --- a/tests/qemucapabilitiesdata/caps_6.1.0.x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_6.1.0.x86_64.xml @@ -241,6 +241,7 @@ + 6001000 0 43100243 diff --git a/tests/qemucapabilitiesdata/caps_6.2.0.x86_64.xml b/tests/qemuc= apabilitiesdata/caps_6.2.0.x86_64.xml index e5b9bfce0b..25eea8a486 100644 --- a/tests/qemucapabilitiesdata/caps_6.2.0.x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_6.2.0.x86_64.xml @@ -241,6 +241,7 @@ + 6001050 0 43100244 --=20 2.17.1 From nobody Sat May 4 12:02:51 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1634291628474878.8185732955696; Fri, 15 Oct 2021 02:53:48 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-360-KvBHH3aRPFewB527wqHCTw-1; Fri, 15 Oct 2021 05:53:43 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E3FAE80292B; Fri, 15 Oct 2021 09:53:38 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C1E1668D7D; Fri, 15 Oct 2021 09:53:38 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 8AF0D4EA30; Fri, 15 Oct 2021 09:53:38 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 19F9nonO000650 for ; Fri, 15 Oct 2021 05:49:50 -0400 Received: by smtp.corp.redhat.com (Postfix) id 11279C77F8; Fri, 15 Oct 2021 09:49:50 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast03.extmail.prod.ext.rdu2.redhat.com [10.11.55.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 08AAFC77F5 for ; Fri, 15 Oct 2021 09:49:48 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E5B20811E78 for ; Fri, 15 Oct 2021 09:49:47 +0000 (UTC) Received: from corp-ob07.yahoo-corp.jp (corp-ob07.yahoo-corp.jp [183.79.94.94]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-275-7JGdIY8lOhuzBw2imiorug-1; Fri, 15 Oct 2021 05:49:45 -0400 Received: from JPN01-OS2-obe.outbound.protection.outlook.com (mail-os2jpn01lp2055.outbound.protection.outlook.com [104.47.92.55]) by corp-ob07.yahoo-corp.jp (Postfix) with ESMTPS id 24A3E19FB188 for ; Fri, 15 Oct 2021 18:49:42 +0900 (JST) Received: from TYCPR01MB7919.jpnprd01.prod.outlook.com (2603:1096:400:186::10) by TYCPR01MB8176.jpnprd01.prod.outlook.com (2603:1096:400:105::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.14; Fri, 15 Oct 2021 09:49:41 +0000 Received: from TYCPR01MB7919.jpnprd01.prod.outlook.com ([fe80::e075:693b:905:bb22]) by TYCPR01MB7919.jpnprd01.prod.outlook.com ([fe80::e075:693b:905:bb22%9]) with mapi id 15.20.4608.017; Fri, 15 Oct 2021 09:49:41 +0000 Received: from R-SUR-LBA-2603.yahoo.co.jp (211.14.8.148) by TY2PR02CA0018.apcprd02.prod.outlook.com (2603:1096:404:56::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16 via Frontend Transport; Fri, 15 Oct 2021 09:49:41 +0000 X-MC-Unique: KvBHH3aRPFewB527wqHCTw-1 X-MC-Unique: 7JGdIY8lOhuzBw2imiorug-1 From: Hiroki Narukawa To: libvir-list@redhat.com Subject: [PATCH 2/4] qemu_driver: add required capabilities to qemuDomainGetStatsWorkers Date: Fri, 15 Oct 2021 18:49:18 +0900 Message-Id: <20211015094920.3658-3-hnarukaw@yahoo-corp.jp> In-Reply-To: <20211015094920.3658-1-hnarukaw@yahoo-corp.jp> References: <20211015094920.3658-1-hnarukaw@yahoo-corp.jp> X-ClientProxiedBy: TY2PR02CA0018.apcprd02.prod.outlook.com (2603:1096:404:56::30) To TYCPR01MB7919.jpnprd01.prod.outlook.com (2603:1096:400:186::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3371fe8c-1a42-44f1-2d49-08d98fc11c35 X-MS-TrafficTypeDiagnostic: TYCPR01MB8176: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:30 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0 X-Microsoft-Antispam-Message-Info: k3/lmK8vJ+W/LaJbp7t8VUubgqjh44wpETVRUmxHX8uFAgjt+sgv/4Rt9vlhYTaN9xIwPUqt8g2jWDCki/+lJek60FLavtCCLb/z33Uzwde66lAVNDSpAkhW/D0l/UZnokIN822jTcLBj11iKUd/SIBMOFJWWpeULNfbW/13g948/ACxrAWAr9kEe7YhIjyF9haxfIg0D8ZH3YgCPK/utbnO+VJFiux2yfTp8WVlmnMBOOOXD/ZsYmHdKVtLWuwdRi1e8OwcgAGGC/Tb732V4awjnMwczi35jHwUoCZGu7tt0QXAwji+stksJknBkuIL+xngNCqcmGHQseJFMwkMqpNQrebR/gPa9EUhVvvC6PfnYem/5O7OvLFCJZo/R2tnDOso+oVk6mDcpxOcc9hFCVj/F1RDPfZ2ClnoXaTvu84s8yVevX7yVVfkXXpWC3zs8iO1Zsu01CNeOq09qQYb/FjTs7kpbiSEXQIdY5qy6BVwkjPyaygalcrwG2DcG4slDglubbPMCdx8xMQKcJy20kVEXMVcmQ5rHTBVRQ3KGj/mW8aoeeGlOKxDu1yk4oyUXn2cC7LmudcMs50LJFAeUwDdkCNlGVVasyfWLj0LQHXLAogQsq8nRO45CsP9C8omd6kF4K6rkYj9wur2r/NcCT2x/qPDN5gVqWoVVI/JoCtJhnZKUSDMooynqqF1fY/dstBIPb9ahNhmcq98eYb/ZW6nY1QBXB4BkWV2FWKfcDT6LHXe8EYplte6Gi8/Zbfe60k3o2MdnDbALaOJVOJadA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TYCPR01MB7919.jpnprd01.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(26005)(83380400001)(6506007)(6486002)(6512007)(107886003)(52116002)(86362001)(8936002)(36756003)(5660300002)(186003)(4326008)(1076003)(508600001)(956004)(6666004)(38350700002)(66556008)(38100700002)(66476007)(8676002)(2906002)(66946007)(82960400001)(316002)(6916009)(2616005)(145543001)(145603002); DIR:OUT; SFP:1102 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Uq3Dc/loCuXN0vCMwPqVUswTyurF9BpUc5theMGGTjr8MTcKpyN3RqUepX+g?= =?us-ascii?Q?CNbHJmyDD1AUuxNnrifpeho9e0iHK6yDPkYNJq9iLqZY8UnAkLa3cOO5MVcQ?= =?us-ascii?Q?AjqxCvaj+lqzx3TviTp/CK8isKkCBvaqoCmW/iBSO9DzKbDEJInwFyqwUitn?= =?us-ascii?Q?/+1dvINTwqg5plGH6M9FWuezxS6yDwdsaVKItSIAbbInmZ4NA2fv4S6FTdC9?= =?us-ascii?Q?Xd/sNpCfKOt2mnN3pnHCZUe4BeKNT1KbV1GCAAtS0RR7XYzxW1G3xq6pzqy/?= =?us-ascii?Q?76WRQouCKO9XUhtDg9SqkoFdHyuxWAAGyuWWRXaNyCON6bLpNvBIgFK1fLgn?= =?us-ascii?Q?nQbiQHCc4joEt4TF4IUT9M9VibMa3eG3O+K67KXVym4IiTScp9AVmv2sNRSZ?= =?us-ascii?Q?aQQwgzPv9lShseCLk3JbpqZhrSRUy+MwcmXzOq9/ZTR489BXYdEWMQUGQDOk?= =?us-ascii?Q?teFCieYzjtSCeaNOW8e3sdZRRfC15qiu6J5DR5WG2AfvpSwSiUPT+IwVdw2U?= =?us-ascii?Q?rcKbIS4tdj+6XaUpbPWJYU1YoX2r2qIgtHNY3acqvM2+bMoDmGeo9LqfioVJ?= =?us-ascii?Q?r2REXNK7vhUXjwY7KXZ+sYMUJblG+gEJrQPfQbdoRIQI6x9A09672AiWCdMX?= =?us-ascii?Q?JnE6YZWzosSbLJzOpSU+XO19E3L67KVq7nZvkE+v3Mb71UNN7QnFcSnWP6EI?= =?us-ascii?Q?yM3pqinsWDGiouuamhLYP67Bb+a3faYj3d3UDVhIA1CsdQHURJfxwxTdsmWs?= =?us-ascii?Q?if2/xZrZTzdD467Xv7MgjMXdUP2/e/bDfU1p/oXDtqVyKolkF+c3W1Y3D6D7?= =?us-ascii?Q?m8lVSeUwhqPzWIMUnrggdg5z1K0Ph1fqN+bYOwjyKPPdZf3CFQcsTr3sb4pg?= =?us-ascii?Q?5aEHtu+X5DqfTJxqWWuLPODyzMnMG/hNWetzT/nm+zhQEViCsiAoVayr7uah?= =?us-ascii?Q?f4tIszCNiqJXdDa4VBuIwBKLUJEVgOzmt6+slFTKhupP3NvOGH3ygOrRpCo6?= =?us-ascii?Q?NF1PINwzTSJvQL8NIlWnmVIPfANPUNNwJP2Bf06cAkJ5PIIrAKX1MOFyIiZc?= =?us-ascii?Q?TR95eg6PGxhdI86Wdh+XPOubC5zNJjEXRn/jxgVkPp7U7hpSIdVGH9wDNVpu?= =?us-ascii?Q?3JzLRbjjbAsdrWNR0SnSJkj8wVRrztocizqlaR1ZAdx1eydsF58L4ujkUaya?= =?us-ascii?Q?B7cRuScl68LwdzZSXih+SaVZ8p81CrBxkXEIUiL0IXep3dok/teOdOE3Muwd?= =?us-ascii?Q?yeUqS8+pJ4aIiHTaDAQRGkvEYHo2n6IbKm6b+XC0kIhehGUk0gEiOTLXlT6c?= =?us-ascii?Q?LLiE7iFNOpMoy7vmS7FRcvft?= X-OriginatorOrg: yahoo-corp.jp X-MS-Exchange-CrossTenant-Network-Message-Id: 3371fe8c-1a42-44f1-2d49-08d98fc11c35 X-MS-Exchange-CrossTenant-AuthSource: TYCPR01MB7919.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 09:49:41.5657 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a208d369-cd4e-4f87-b119-98eaf31df2c3 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ACe2mxD5tkpOcXyNohhaNHFSUqplpxjCm5GIPXLJVMO7c8uD/6Vv11yQRNRzkZ5KScuAYQB/lfyjqS2jFi2ZkQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYCPR01MB8176 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-loop: libvir-list@redhat.com Cc: aoiwa@yahoo-corp.jp, Hiroki Narukawa X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-ZM-MESSAGEID: 1634291628856100001 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" One of qemuDomainGetStatsWorkers requires capabilities to run. This commit adds capability information to qemuDomainGetStatsWorkers. Signed-off-by: Hiroki Narukawa Reviewed-by: Michal Privoznik --- src/qemu/qemu_driver.c | 32 +++++++++++++++++++++----------- 1 file changed, 21 insertions(+), 11 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 2b759f5719..ac5eaf139e 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -18685,20 +18685,30 @@ struct qemuDomainGetStatsWorker { qemuDomainGetStatsFunc func; unsigned int stats; bool monitor; + virQEMUCapsFlags* requiredCaps; +}; + +static virQEMUCapsFlags noCapsRequired[] =3D { + QEMU_CAPS_LAST, +}; + +static virQEMUCapsFlags queryDirtyRateRequired[] =3D { + QEMU_CAPS_QUERY_DIRTY_RATE, + QEMU_CAPS_LAST, }; =20 static struct qemuDomainGetStatsWorker qemuDomainGetStatsWorkers[] =3D { - { qemuDomainGetStatsState, VIR_DOMAIN_STATS_STATE, false }, - { qemuDomainGetStatsCpu, VIR_DOMAIN_STATS_CPU_TOTAL, false }, - { qemuDomainGetStatsBalloon, VIR_DOMAIN_STATS_BALLOON, true }, - { qemuDomainGetStatsVcpu, VIR_DOMAIN_STATS_VCPU, true }, - { qemuDomainGetStatsInterface, VIR_DOMAIN_STATS_INTERFACE, false }, - { qemuDomainGetStatsBlock, VIR_DOMAIN_STATS_BLOCK, true }, - { qemuDomainGetStatsPerf, VIR_DOMAIN_STATS_PERF, false }, - { qemuDomainGetStatsIOThread, VIR_DOMAIN_STATS_IOTHREAD, true }, - { qemuDomainGetStatsMemory, VIR_DOMAIN_STATS_MEMORY, false }, - { qemuDomainGetStatsDirtyRate, VIR_DOMAIN_STATS_DIRTYRATE, true }, - { NULL, 0, false } + { qemuDomainGetStatsState, VIR_DOMAIN_STATS_STATE, false, noCapsRequir= ed }, + { qemuDomainGetStatsCpu, VIR_DOMAIN_STATS_CPU_TOTAL, false, noCapsRequ= ired }, + { qemuDomainGetStatsBalloon, VIR_DOMAIN_STATS_BALLOON, true, noCapsReq= uired }, + { qemuDomainGetStatsVcpu, VIR_DOMAIN_STATS_VCPU, true, noCapsRequired = }, + { qemuDomainGetStatsInterface, VIR_DOMAIN_STATS_INTERFACE, false, noCa= psRequired }, + { qemuDomainGetStatsBlock, VIR_DOMAIN_STATS_BLOCK, true, noCapsRequire= d }, + { qemuDomainGetStatsPerf, VIR_DOMAIN_STATS_PERF, false, noCapsRequired= }, + { qemuDomainGetStatsIOThread, VIR_DOMAIN_STATS_IOTHREAD, true, noCapsR= equired }, + { qemuDomainGetStatsMemory, VIR_DOMAIN_STATS_MEMORY, false, noCapsRequ= ired }, + { qemuDomainGetStatsDirtyRate, VIR_DOMAIN_STATS_DIRTYRATE, true, query= DirtyRateRequired }, + { NULL, 0, false, NULL } }; =20 =20 --=20 2.17.1 From nobody Sat May 4 12:02:51 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1634291520414741.5170913980338; Fri, 15 Oct 2021 02:52:00 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-560-qtPOWV_bMNW4qxh6agucGw-1; Fri, 15 Oct 2021 05:51:55 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1AD8419253C4; Fri, 15 Oct 2021 09:51:50 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CED445D740; Fri, 15 Oct 2021 09:51:48 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 4CA1A4A703; Fri, 15 Oct 2021 09:51:45 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 19F9nlr2000635 for ; Fri, 15 Oct 2021 05:49:48 -0400 Received: by smtp.corp.redhat.com (Postfix) id C0331400E410; Fri, 15 Oct 2021 09:49:47 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast02.extmail.prod.ext.rdu2.redhat.com [10.11.55.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BB9D340C1256 for ; Fri, 15 Oct 2021 09:49:47 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9F8D4800883 for ; Fri, 15 Oct 2021 09:49:47 +0000 (UTC) Received: from corp-ob08.yahoo-corp.jp (corp-ob08.yahoo-corp.jp [183.79.94.93]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-14-kusa_RajNvqvApmxPXaLbw-1; Fri, 15 Oct 2021 05:49:45 -0400 Received: from JPN01-OS2-obe.outbound.protection.outlook.com (mail-os2jpn01lp2050.outbound.protection.outlook.com [104.47.92.50]) by corp-ob08.yahoo-corp.jp (Postfix) with ESMTPS id BEBCC1A49B07 for ; Fri, 15 Oct 2021 18:49:42 +0900 (JST) Received: from TYCPR01MB7919.jpnprd01.prod.outlook.com (2603:1096:400:186::10) by TYCPR01MB8176.jpnprd01.prod.outlook.com (2603:1096:400:105::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.14; Fri, 15 Oct 2021 09:49:41 +0000 Received: from TYCPR01MB7919.jpnprd01.prod.outlook.com ([fe80::e075:693b:905:bb22]) by TYCPR01MB7919.jpnprd01.prod.outlook.com ([fe80::e075:693b:905:bb22%9]) with mapi id 15.20.4608.017; Fri, 15 Oct 2021 09:49:41 +0000 Received: from R-SUR-LBA-2603.yahoo.co.jp (211.14.8.148) by TY2PR02CA0018.apcprd02.prod.outlook.com (2603:1096:404:56::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16 via Frontend Transport; Fri, 15 Oct 2021 09:49:41 +0000 X-MC-Unique: qtPOWV_bMNW4qxh6agucGw-1 X-MC-Unique: kusa_RajNvqvApmxPXaLbw-1 From: Hiroki Narukawa To: libvir-list@redhat.com Subject: [PATCH 3/4] qemu_driver: add check for qemu capabilities requirements Date: Fri, 15 Oct 2021 18:49:19 +0900 Message-Id: <20211015094920.3658-4-hnarukaw@yahoo-corp.jp> In-Reply-To: <20211015094920.3658-1-hnarukaw@yahoo-corp.jp> References: <20211015094920.3658-1-hnarukaw@yahoo-corp.jp> X-ClientProxiedBy: TY2PR02CA0018.apcprd02.prod.outlook.com (2603:1096:404:56::30) To TYCPR01MB7919.jpnprd01.prod.outlook.com (2603:1096:400:186::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d8f8a3e6-973d-4f20-5fc0-08d98fc11c68 X-MS-TrafficTypeDiagnostic: TYCPR01MB8176: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:32 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0 X-Microsoft-Antispam-Message-Info: u4l771yeczTxicPuAnb+oc8bBXY7v0zkGiU5iaB8By1Fs4hpQPWFwPXQYzySvYDzwOmWilZmvC6k2LZG024U3UjcZDEvVuosiyyu+OrXy27tO/0tZo/OsxiaCuxbpM9FVPHr9gw0NJF7Zs74ice9tnu2imE9QiJW/qkWICa2zEP7Rcx+DNx8kKy74Ku0RM4q/Z3hmS5ko+ZHHZw5Q2PqZhME6PoqNZIvB1++DdKVYHUPbTsqJb/+KehazKguSBGn7fqAs9/j3fi3bDpH7j6tfoWbL9FX9jK7O8tEi91CNFtMML3C5rVEYtElf8y7hY9eU5iBjHN/YSGHFzW48lwHM3JQT5dmKynqznarABIKLvnNDVOjiXOw48E/ZbrOAWdg+VKsJMKTl6MQvoYzHlhWN1ieSyyH5u988JIc97jONGjdzGdXwOu6aveSkWyPsJ7HArIgJUsIm1MeBgR9ICwIS2lqXj8ty2uaWQ8ZNV+J5vKNVh8T2YJ51zLgRuWs0dFV3+SkZl0wx9bJMWy1q1sCrMZZBLZpiq9QVx6VsB7PBXSc2iAIjY4fDUE2AmV9yIWEi4ejp7XUjtB424pY4UG033mrReCXo+Ge8TeeKAAWHE/NiND5Oap2hf1FJEzRqtSe4IX8IfIi5aGkThW8dj4sfIatxfFyIVHyA56LLk5Uiop8VAdT/lSd/01EvNxwfxBY6Ot+9xPDY+UctXbCpPInWw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TYCPR01MB7919.jpnprd01.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(26005)(83380400001)(6506007)(6486002)(6512007)(107886003)(52116002)(86362001)(8936002)(36756003)(5660300002)(186003)(4326008)(1076003)(508600001)(956004)(6666004)(38350700002)(66556008)(38100700002)(66476007)(8676002)(2906002)(66946007)(82960400001)(316002)(6916009)(2616005); DIR:OUT; SFP:1102 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?McTWDTpzEhRi7NCk14yBpyFlQTizslQaEWywNZc9WE4/wGkFmdHTttaJ54Gp?= =?us-ascii?Q?NC/OqSs8897gp18exBttANZlJSYllDI8/rJ3RaqZH+6nNEYbi6NlPpqrEkaM?= =?us-ascii?Q?vE+6gOxlQxBld2GYyCPBep1PWIyTju47tBkCJ9Wkv+X15HXiQjc+3tpa0+3L?= =?us-ascii?Q?kaB9lXmNLVmZcEp9RBvpGXBTl7zdbKpCPHVk1IBiBY0qjcpqJ0f/amcsJ0b6?= =?us-ascii?Q?GFyw8PSKJVuA/qGyXHhxgybWv8jtmAS9t9V3eIyUGRpK6A5YZQzQbzShk7C8?= =?us-ascii?Q?gFOqQhQp/WBs9uy8g33H/KTWbe+i2khASo/DUnD4IlkBWY8aUfbThTSnbA9k?= =?us-ascii?Q?CD3n1Ty/a9iJRNHNoB5ZVvFbhLCU1E9i1Pn47PUzvJnP0dK9zF+wWeXtIKoF?= =?us-ascii?Q?7iWMoMaGyneWjI2vZObvMSjusch7fX0Sxz28UVtSOhpZOE4+J3osWG9xKczw?= =?us-ascii?Q?BVXWLLQECTRYqbvOvnnXBqvspkGb40GNxrTwVflnzfH3O4jUpqidyVzSFklE?= =?us-ascii?Q?OAK9pUps/R1kBMVD18O8mknKSv9PqTggt6lN64O+dj9eyR65Y1TWqnoGHRnR?= =?us-ascii?Q?DLDAoZmjbaTK06Ro0Yr7nwLO4te26NQvzQce16Pl9diaIwwB5oiMoHkmdhi4?= =?us-ascii?Q?/AyvW285LrTPD4DdzMTbXK7ppxPWhhmLZ1D2uHDGKTSzzy7QprWSEOZTRPf1?= =?us-ascii?Q?mRN7jC7nxhJnU0Nd4A88qLJFIssx87EN9B3mOlGn/fbH8ZfGaK3m6ojPzTlx?= =?us-ascii?Q?tRSqv8WZoHWd2zZxZiDyzSCJjCCacZ8R0lRA3yKKMEJ1kRlSrPvOWfmNXW90?= =?us-ascii?Q?vDwMdoFRS6iOpuknViprNdvYiSiaviFArRVbQzZd/1sx1XGO4PwJO4XBKVY5?= =?us-ascii?Q?EHEq4LD0wxGla3KYOiKx2EwSTM98plSOr5HGqXkXUj9H7/ZWqNCtQgiL7bHI?= =?us-ascii?Q?2RnkpHeuCFNoO0bUqFqRhOtY24Lkaki7nma8Nnvs1Zv0RIFgvzEMMpKJoEVR?= =?us-ascii?Q?Y2f9x2RGIv1p8YdiF9coS4e6VvYRwws3NuEd5neBEHh5tpRKTYY2RbQaGfim?= =?us-ascii?Q?7PMVdtSypbdvGvaYRGlYsXeJMtEz5BC7tkl75BLcbq52xu0MxaLR4VgPAQEQ?= =?us-ascii?Q?fyhRqWhRA38zuXLik79N3y2W7LvDfymLkjuYKR3IEeAY5Sm+/xDv4F/Oc8EL?= =?us-ascii?Q?6WICb/c4i6R2Iozx5Qrk3cJgdg2zeq/46dk7hrYb6Fn/2aftJO75/x4vcA4b?= =?us-ascii?Q?dQEe7sdBi2Gbh/mb4d+oWfbElm1bgVfv7zD9uw1N6ae1PoOA2GSWV0IW4ENp?= =?us-ascii?Q?zILtEUR+xDTm3zcNBd1/7yzZ?= X-OriginatorOrg: yahoo-corp.jp X-MS-Exchange-CrossTenant-Network-Message-Id: d8f8a3e6-973d-4f20-5fc0-08d98fc11c68 X-MS-Exchange-CrossTenant-AuthSource: TYCPR01MB7919.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 09:49:41.9012 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a208d369-cd4e-4f87-b119-98eaf31df2c3 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bgcmXBDvZIL8dMwbDMZm/k9NONto/fu6OadIUSRV6sdym1uoqqw0OC+Znd/WGnlUdW2PVkUzWy1+MpSLU0PGgg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYCPR01MB8176 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 X-loop: libvir-list@redhat.com Cc: aoiwa@yahoo-corp.jp, Hiroki Narukawa X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-ZM-MESSAGEID: 1634291522455100001 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" query-dirty-rate command is used for virsh domstats by default, but this is available only on qemu >=3D5.2.0. By this commit, qemu domain stats will check capabilities requirements befo= re issuing actual query. Signed-off-by: Hiroki Narukawa Reviewed-by: Michal Privoznik --- src/qemu/qemu_driver.c | 40 +++++++++++++++++++++++++++++----------- 1 file changed, 29 insertions(+), 11 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index ac5eaf139e..9cfd0a6ca5 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -18714,13 +18714,28 @@ static struct qemuDomainGetStatsWorker qemuDomain= GetStatsWorkers[] =3D { =20 static int qemuDomainGetStatsCheckSupport(unsigned int *stats, - bool enforce) + bool enforce, + virDomainObj *vm) { + qemuDomainObjPrivate *priv =3D vm->privateData; unsigned int supportedstats =3D 0; size_t i; + virQEMUCapsFlags* flagCursor; =20 - for (i =3D 0; qemuDomainGetStatsWorkers[i].func; i++) - supportedstats |=3D qemuDomainGetStatsWorkers[i].stats; + for (i =3D 0; qemuDomainGetStatsWorkers[i].func; i++) { + bool supportedByQemu =3D true; + + for (flagCursor =3D qemuDomainGetStatsWorkers[i].requiredCaps; *fl= agCursor !=3D QEMU_CAPS_LAST; + ++flagCursor) { + if (!virQEMUCapsGet(priv->qemuCaps, *flagCursor)) { + supportedByQemu =3D false; + break; + } + } + if (supportedByQemu) { + supportedstats |=3D qemuDomainGetStatsWorkers[i].stats; + } + } =20 if (*stats =3D=3D 0) { *stats =3D supportedstats; @@ -18791,7 +18806,7 @@ static int qemuConnectGetAllDomainStats(virConnectPtr conn, virDomainPtr *doms, unsigned int ndoms, - unsigned int stats, + unsigned int requestedStats, virDomainStatsRecordPtr **retStats, unsigned int flags) { @@ -18805,11 +18820,12 @@ qemuConnectGetAllDomainStats(virConnectPtr conn, int nstats =3D 0; size_t i; int ret =3D -1; - unsigned int privflags =3D 0; + unsigned int privflags; unsigned int domflags =3D 0; unsigned int lflags =3D flags & (VIR_CONNECT_LIST_DOMAINS_FILTERS_ACTI= VE | VIR_CONNECT_LIST_DOMAINS_FILTERS_PERSIS= TENT | VIR_CONNECT_LIST_DOMAINS_FILTERS_STATE); + unsigned int stats; =20 virCheckFlags(VIR_CONNECT_LIST_DOMAINS_FILTERS_ACTIVE | VIR_CONNECT_LIST_DOMAINS_FILTERS_PERSISTENT | @@ -18821,9 +18837,6 @@ qemuConnectGetAllDomainStats(virConnectPtr conn, if (virConnectGetAllDomainStatsEnsureACL(conn) < 0) return -1; =20 - if (qemuDomainGetStatsCheckSupport(&stats, enforce) < 0) - return -1; - if (ndoms) { if (virDomainObjListConvert(driver->domains, conn, doms, ndoms, &v= ms, &nvms, virConnectGetAllDomainStatsChec= kACL, @@ -18838,14 +18851,19 @@ qemuConnectGetAllDomainStats(virConnectPtr conn, =20 tmpstats =3D g_new0(virDomainStatsRecordPtr, nvms + 1); =20 - if (qemuDomainGetStatsNeedMonitor(stats)) - privflags |=3D QEMU_DOMAIN_STATS_HAVE_JOB; - for (i =3D 0; i < nvms; i++) { virDomainStatsRecordPtr tmp =3D NULL; domflags =3D 0; + privflags =3D 0; vm =3D vms[i]; =20 + stats =3D requestedStats; + if (qemuDomainGetStatsCheckSupport(&stats, enforce, vm) < 0) + return -1; + + if (qemuDomainGetStatsNeedMonitor(stats)) + privflags |=3D QEMU_DOMAIN_STATS_HAVE_JOB; + virObjectLock(vm); =20 if (HAVE_JOB(privflags)) { --=20 2.17.1 From nobody Sat May 4 12:02:51 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 163429160392127.59339180839561; Fri, 15 Oct 2021 02:53:23 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-372-d--E3dTCNVWHchxRjxGdGw-1; Fri, 15 Oct 2021 05:53:21 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6C8A2100C663; Fri, 15 Oct 2021 09:53:16 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4AE141002D67; Fri, 15 Oct 2021 09:53:16 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 178894EA30; Fri, 15 Oct 2021 09:53:16 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 19F9nmnB000636 for ; Fri, 15 Oct 2021 05:49:48 -0400 Received: by smtp.corp.redhat.com (Postfix) id 555C040CFD11; Fri, 15 Oct 2021 09:49:48 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast06.extmail.prod.ext.rdu2.redhat.com [10.11.55.22]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4F92E40CFD0D for ; Fri, 15 Oct 2021 09:49:48 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3665618A01A0 for ; Fri, 15 Oct 2021 09:49:48 +0000 (UTC) Received: from corp-ob07.yahoo-corp.jp (corp-ob07.yahoo-corp.jp [183.79.94.94]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-60-jPhD2f1ZOkSPbL1Sy7ZLFw-1; Fri, 15 Oct 2021 05:49:46 -0400 Received: from JPN01-TY1-obe.outbound.protection.outlook.com (mail-ty1jpn01lp2051.outbound.protection.outlook.com [104.47.93.51]) by corp-ob07.yahoo-corp.jp (Postfix) with ESMTPS id 175C319FB18A for ; Fri, 15 Oct 2021 18:49:43 +0900 (JST) Received: from TYCPR01MB7919.jpnprd01.prod.outlook.com (2603:1096:400:186::10) by TYCPR01MB8690.jpnprd01.prod.outlook.com (2603:1096:400:18b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Fri, 15 Oct 2021 09:49:42 +0000 Received: from TYCPR01MB7919.jpnprd01.prod.outlook.com ([fe80::e075:693b:905:bb22]) by TYCPR01MB7919.jpnprd01.prod.outlook.com ([fe80::e075:693b:905:bb22%9]) with mapi id 15.20.4608.017; Fri, 15 Oct 2021 09:49:42 +0000 Received: from R-SUR-LBA-2603.yahoo.co.jp (211.14.8.148) by TY2PR02CA0018.apcprd02.prod.outlook.com (2603:1096:404:56::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16 via Frontend Transport; Fri, 15 Oct 2021 09:49:42 +0000 X-MC-Unique: d--E3dTCNVWHchxRjxGdGw-1 X-MC-Unique: jPhD2f1ZOkSPbL1Sy7ZLFw-1 From: Hiroki Narukawa To: libvir-list@redhat.com Subject: [PATCH 4/4] NEWS: document bug fix about virsh domstats on qemu < 5.2.0 Date: Fri, 15 Oct 2021 18:49:20 +0900 Message-Id: <20211015094920.3658-5-hnarukaw@yahoo-corp.jp> In-Reply-To: <20211015094920.3658-1-hnarukaw@yahoo-corp.jp> References: <20211015094920.3658-1-hnarukaw@yahoo-corp.jp> X-ClientProxiedBy: TY2PR02CA0018.apcprd02.prod.outlook.com (2603:1096:404:56::30) To TYCPR01MB7919.jpnprd01.prod.outlook.com (2603:1096:400:186::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1e3517b8-3e62-4ddf-d688-08d98fc11ca4 X-MS-TrafficTypeDiagnostic: TYCPR01MB8690: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1122 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0 X-Microsoft-Antispam-Message-Info: 9Z/76vdhsJMqqolKE6vnzmK/rCKJrvv4K5EtS4k1Hu2VgdNpKA50r4+lw9QFb/EIIDTm12OcOooJPoPbmk4q2P5nHYYDUSToXH/XuPr6DUmvBuFvRTp6MNlijSb7jfpSs+i4cXxT+mUbekM1WqY119PN710zujMmnyk6tKtI+35Rix2hkEApeKRUSjpZRL3jhQvTTVDhprNwRUWYcv3qP4jNPZm30jPj1BET8aZ/YGzFQekzmSDrgHs08nr6BGs3YDDGkYOhzoVtfJTuYW6GtbxDSft7pn/P6HWdo4eh2D0pvXzwqyJHwq3eFxAkU58A8qGoCI+PAuIda5ZFY74FWQst3obRQyW5hR5IyLbj7kk+Qv02Blj7ax2UBFa4wNd9wZj1YwRHQHOFjoEGa6bWGjkBWQlXK5CerRLeEgzBH6RfZx/cbUOBMWIgaS6FBaPD7DKktvnuGJ0P2QPkVf7ZfvA3VKgzO+IIxjxw8PfsHNrC7PoYj6LQgo3pukHCrIcdrLKi10yIf/nPrzPKrPZv/2TmzqoeV0fLo1bac6yrxxjZ0SP+wf7X31yOgz/tmXje2D/qrXWMx8r2PW27OXMtkm3bRUT0efIZgWbC9NH+/riCMyQ48j5M0Fx08el05g4eCSR4G+srIeQhoK4lzkhFSp/yPERdxge2865lKc8CFkI39PQceFaRblh4Q/Bm1M8/xI3v/bFWYfuk0wcR8/khZw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TYCPR01MB7919.jpnprd01.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(2906002)(38350700002)(6666004)(66556008)(66476007)(956004)(2616005)(107886003)(1076003)(66946007)(38100700002)(5660300002)(52116002)(6486002)(8936002)(86362001)(6506007)(6512007)(6916009)(36756003)(82960400001)(508600001)(316002)(186003)(4744005)(4326008)(8676002)(26005); DIR:OUT; SFP:1102 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?eTVZ/E/LyKefvtJ/euDlldqYoU8DKhWiqesaCXy+sTtQAkMWO6ZYrzJV1foR?= =?us-ascii?Q?oysnKMbwQv4BraE5Lm5EsF5JM6thS/FqfQBQTKuAM5cOFVWyAVCqZ0gRfqRW?= =?us-ascii?Q?A5KzhaM43M93L1OTk9S/BqCBeut8DtT3jMkmfla53WHP27t5OeJfz2U97q+0?= =?us-ascii?Q?4Kqec15+Ya6NYdiDq6tXhIxXuu8Ij2J4T1/KsIPdOf5Q5dI198rlxZOxsyno?= =?us-ascii?Q?HyUibToPYbueBMJYp/FChXq5uakQn/v1Ov5mAXlFnoxrbKeiM9s8vROiIXY3?= =?us-ascii?Q?c4g+C4TvH5jykUB38knIhevacZHIez7uizwt/QECPFFL4SPoJ+2+RJRpS6mu?= =?us-ascii?Q?WD7ZPyxq9QhwUYbER6SdiVL/9FL3Mz4+AiOyrPgQ//RXRguEH8t4cq2FCljf?= =?us-ascii?Q?uEOjpD+2UhteReyU0LG75vGql5yRcV1S5OjiRH2AhUIki90ryZiLHjedzq3m?= =?us-ascii?Q?pKSgWDSyGBqw5t4JuosYDgaoVae1UPklcBNzid6xxB/EroaoNA2Uu46vBv/A?= =?us-ascii?Q?Zy6Z9dDwJXTPFrqfSnqnVA6kdMHIjULpxEQODbdwpimrEitj+T+gtV7ZK0om?= =?us-ascii?Q?drQMNvmquMmyDZJ/hrqqvQGMLXutQGTSvoLUVe5PsuYwgm7gnRvmf+WAC5VB?= =?us-ascii?Q?GsiOD/BUor8Cu7DcBmyX7m1LKSGr5QrQfoP4+Ca0ZuFC+QVYCdrIqRliVd6u?= =?us-ascii?Q?Xpno44DjcSanYm4ZJbyYvEEFCBiiWBv6j9lSDUkF3QFhCcgNH8SeIk8tecaa?= =?us-ascii?Q?AHtNnoQ03I285YVhJxu+oeMKrnYHZzLNkLRDC5R6OESDgrtkDTKpU4mpw/Gf?= =?us-ascii?Q?swaZR9pDcpl44QiXpW6eau2tSuEC651FnjqveyHEuInK94pjNJ5gUexVwzDA?= =?us-ascii?Q?9Vhq31SkQaQapdb5UqnrGdiLo7fHVc7wH/0CjpndZWe+ulSAwkNcwJ4CDay6?= =?us-ascii?Q?w5qPnl9Mr1mUT0sgufi/MwmAeVZzE2Qgr23ntCDrdI83CO2WtsevqaeSrXJ+?= =?us-ascii?Q?pSt3pUeLKwlOL8z5WW5LtrS8pPLr24K+IryfR+kyHqFzGpKfvueo0PqH5hCB?= =?us-ascii?Q?jA8Gly3wbMSx7hqAIAslAC4vafaknAa/8IaFBZ/2RdJPR8rqJchaS8PMjPPv?= =?us-ascii?Q?zXXZYmXbpEr4Tja3HCPOdmaYqIICOE/3xvv5TdVRwrlXVBwQ9a+7PtbLahSD?= =?us-ascii?Q?mQgd56np8QiA0v/7GIA12fiQLWtrJu1wkGS6zQZtgYHamyBz8BkLhfldy/ci?= =?us-ascii?Q?4QsywtazcYQSPvcrThM7ebs6frtdoZG5TluGHpZvzd1W0/EsstL5fclAxsb5?= =?us-ascii?Q?86hU0EfvL4Wdj70+sojovToY?= X-OriginatorOrg: yahoo-corp.jp X-MS-Exchange-CrossTenant-Network-Message-Id: 1e3517b8-3e62-4ddf-d688-08d98fc11ca4 X-MS-Exchange-CrossTenant-AuthSource: TYCPR01MB7919.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 09:49:42.2716 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a208d369-cd4e-4f87-b119-98eaf31df2c3 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: COvb1QZvb9kcj0BwGU06EYKGIebP1ds2QJqou6e5pvutTl2E0fFRiyyC4sW35ziJU4VFybkZjzaT4MccSVldKA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYCPR01MB8690 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1 X-loop: libvir-list@redhat.com Cc: aoiwa@yahoo-corp.jp, Hiroki Narukawa X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-ZM-MESSAGEID: 1634291605379100001 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" I think that virsh domstats problem on qemu < 5.2.0 is what users want to find which version fixes. Reviewed-by: Michal Privoznik --- NEWS.rst | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index ae678bffc4..2c51628278 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -44,6 +44,11 @@ v7.9.0 (unreleased) =20 * **Bug fixes** =20 + * qemu: Fix problems on ``virsh domstats`` with qemu <5.2.0 + + Libvirt v7.2.0 and later called query-dirty-rate, which was introduced= in + qemu-5.2.0, regardless of qemu version and failed in qemu-5.1.0. This + release fixes the bug. =20 v7.8.0 (2021-10-01) =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --=20 2.17.1