From nobody Fri Mar 29 06:57:19 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1633781455; cv=none; d=zohomail.com; s=zohoarc; b=XqNiMme4bp4/zACuhVslRuNEac6o/z8MN92I5iaEazAAiF9M4KqkKVfRd5V5V3ICAIkEWrUdHHvekigRwLyENn+GMKQYpc93g+Y/RsKySsLbjbhhPlCqIYGUage1o7zv6K2Yyd8vR74zbs2+rDMh5zwhNLXC8iL30+rAj5QbVfE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1633781455; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=MW6cCujDtG/w5q52vzs2If7HJOGXs5Vt1MAUMQQsSuY=; b=Kjsj1abQCrKV1TD69wqqY+YGnQGuDY90Jla1K3byAnLDEGTEedCUHcpB5UV7vHxSoKowbvVMUN+q2X5MXmgAdxWCvvqedpfhlWpMg+wCbjYPXJJp0FvM/drloB3SY8nYYwEtSpHFYFQyP7ZU/NI6NY4o7L2zrr2eD0fz89LoXdw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 163378145491111.291100102917312; Sat, 9 Oct 2021 05:10:54 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-469-wP__qGoZMAi3RybMxsFIFA-1; Sat, 09 Oct 2021 08:10:51 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0B60C18125C0; Sat, 9 Oct 2021 12:10:47 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DD53626E41; Sat, 9 Oct 2021 12:10:46 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id AD0635A0D0; Sat, 9 Oct 2021 12:10:46 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 199CAjZS030841 for ; Sat, 9 Oct 2021 08:10:45 -0400 Received: by smtp.corp.redhat.com (Postfix) id 02C03652AB; Sat, 9 Oct 2021 12:10:45 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-14.ams2.redhat.com [10.36.112.14]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9235E57CAB; Sat, 9 Oct 2021 12:10:08 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 521591138529; Sat, 9 Oct 2021 14:09:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1633781453; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=MW6cCujDtG/w5q52vzs2If7HJOGXs5Vt1MAUMQQsSuY=; b=XXB3UnAdiqlg4cunBdd/IxHUCToYJK5GcjjmC6xM5/kImx+jzAOIUcSGWXfvJOTPngi1AY P8ks2Cu2AokrDnpCLEgzDSSEcYI+Ez9AcT8sryfIRfdG9e1Iv1WD7nfIaVkgUHDbHEhlJy xORW36izSDvWMiuzkjgSMHF1xRUvkkg= X-MC-Unique: wP__qGoZMAi3RybMxsFIFA-1 From: Markus Armbruster To: qemu-devel@nongnu.org Subject: [PATCH RFC v2 5/5] block: Deprecate transaction type drive-backup Date: Sat, 9 Oct 2021 14:09:44 +0200 Message-Id: <20211009120944.2858887-6-armbru@redhat.com> In-Reply-To: <20211009120944.2858887-1-armbru@redhat.com> References: <20211009120944.2858887-1-armbru@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com Cc: kwolf@redhat.com, vsementsov@virtuozzo.com, libvir-list@redhat.com, eblake@redhat.com, pkrempa@redhat.com, marcandre.lureau@redhat.com, jsnow@redhat.com, libguestfs@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1633781456260100003 Content-Type: text/plain; charset="utf-8" Several moons ago, Vladimir posted Subject: [PATCH v2 3/3] qapi: deprecate drive-backup Date: Wed, 5 May 2021 16:58:03 +0300 Message-Id: <20210505135803.67896-4-vsementsov@virtuozzo.com> https://lists.gnu.org/archive/html/qemu-devel/2021-05/msg01394.html with this TODO: We also need to deprecate drive-backup transaction action.. But union members in QAPI doesn't support 'deprecated' feature. I tried to dig a bit, but failed :/ Markus, could you please help with it? At least by advice? This is one way to resolve it. Sorry it took so long. John explored another way, namely adding feature flags to union branches. Could also be useful, say to add different features to branches in multiple unions sharing the same tag enum. Signed-off-by: Markus Armbruster --- qapi/transaction.json | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/qapi/transaction.json b/qapi/transaction.json index d175b5f863..0564a893b3 100644 --- a/qapi/transaction.json +++ b/qapi/transaction.json @@ -54,6 +54,9 @@ # @blockdev-snapshot-sync: since 1.1 # @drive-backup: Since 1.6 # +# Features: +# @deprecated: Member @drive-backup is deprecated. Use FIXME instead. +# # Since: 1.1 ## { 'enum': 'TransactionActionKind', @@ -62,7 +65,7 @@ 'block-dirty-bitmap-disable', 'block-dirty-bitmap-merge', 'blockdev-backup', 'blockdev-snapshot', 'blockdev-snapshot-internal-sync', 'blockdev-snapshot-sync', - 'drive-backup' ] } + { 'name': 'drive-backup', 'features': [ 'deprecated' ] } ] } =20 ## # @AbortWrapper: --=20 2.31.1