From nobody Fri Apr 26 12:29:56 2024
Delivered-To: importer@patchew.org
Received-SPF: pass (zohomail.com: domain of redhat.com designates
170.10.133.124 as permitted sender) client-ip=170.10.133.124;
envelope-from=libvir-list-bounces@redhat.com;
helo=us-smtp-delivery-124.mimecast.com;
Authentication-Results: mx.zohomail.com;
spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as
permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com;
dmarc=fail(p=none dis=none) header.from=il.ibm.com
Return-Path:
Received: from us-smtp-delivery-124.mimecast.com
(us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com
with SMTPS id 1633637064847657.7094329780865;
Thu, 7 Oct 2021 13:04:24 -0700 (PDT)
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
[209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
us-mta-302-pbIzhy6XOW6_n7unnW_oVg-1; Thu, 07 Oct 2021 16:04:22 -0400
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com
[10.5.11.14])
(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
(No client certificate requested)
by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4F1701009447;
Thu, 7 Oct 2021 20:03:11 +0000 (UTC)
Received: from colo-mx.corp.redhat.com
(colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20])
by smtp.corp.redhat.com (Postfix) with ESMTPS id 460A3A7BB;
Thu, 7 Oct 2021 20:03:10 +0000 (UTC)
Received: from lists01.pubmisc.prod.ext.phx2.redhat.com
(lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33])
by colo-mx.corp.redhat.com (Postfix) with ESMTP id B97F1180598A;
Thu, 7 Oct 2021 20:02:49 +0000 (UTC)
Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com
[10.11.54.6])
by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP
id 197JLcsd030659 for ;
Thu, 7 Oct 2021 15:21:38 -0400
Received: by smtp.corp.redhat.com (Postfix)
id DDE682166B26; Thu, 7 Oct 2021 19:21:37 +0000 (UTC)
Received: from mimecast-mx02.redhat.com
(mimecast06.extmail.prod.ext.rdu2.redhat.com [10.11.55.22])
by smtp.corp.redhat.com (Postfix) with ESMTPS id D88672166B2F
for ; Thu, 7 Oct 2021 19:21:37 +0000 (UTC)
Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com
[205.139.110.61])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(No client certificate requested)
by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BA73A189FE99
for ; Thu, 7 Oct 2021 19:21:37 +0000 (UTC)
Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com
[148.163.156.1]) (Using TLS) by relay.mimecast.com with ESMTP id
us-mta-326-qPdJ3tcSN2y9a7eWzZQrAA-1; Thu, 07 Oct 2021 15:21:35 -0400
Received: from pps.filterd (m0098394.ppops.net [127.0.0.1])
by mx0a-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id
197IVfF1023054
for ; Thu, 7 Oct 2021 15:21:34 -0400
Received: from pps.reinject (localhost [127.0.0.1])
by mx0a-001b2d01.pphosted.com with ESMTP id 3bj68js0u7-1
(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256
verify=NOT)
for ; Thu, 07 Oct 2021 15:21:34 -0400
Received: from m0098394.ppops.net (m0098394.ppops.net [127.0.0.1])
by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 197IWWVl030749
for ; Thu, 7 Oct 2021 15:21:34 -0400
Received: from ppma02dal.us.ibm.com (a.bd.3ea9.ip4.static.sl-reverse.com
[169.62.189.10])
by mx0a-001b2d01.pphosted.com with ESMTP id 3bj68js0u2-1
(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256
verify=NOT); Thu, 07 Oct 2021 15:21:34 -0400
Received: from pps.filterd (ppma02dal.us.ibm.com [127.0.0.1])
by ppma02dal.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 197JIlPE004714;
Thu, 7 Oct 2021 19:21:33 GMT
Received: from b03cxnp07027.gho.boulder.ibm.com
(b03cxnp07027.gho.boulder.ibm.com [9.17.130.14])
by ppma02dal.us.ibm.com with ESMTP id 3bef2e1du5-1
(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256
verify=NOT); Thu, 07 Oct 2021 19:21:33 +0000
Received: from b03ledav001.gho.boulder.ibm.com
(b03ledav001.gho.boulder.ibm.com [9.17.130.232])
by b03cxnp07027.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with
ESMTP id 197JLU2M35389778
(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
verify=OK); Thu, 7 Oct 2021 19:21:30 GMT
Received: from b03ledav001.gho.boulder.ibm.com (unknown [127.0.0.1])
by IMSVA (Postfix) with ESMTP id E35886E05D;
Thu, 7 Oct 2021 19:21:29 +0000 (GMT)
Received: from b03ledav001.gho.boulder.ibm.com (unknown [127.0.0.1])
by IMSVA (Postfix) with ESMTP id 345E36E059;
Thu, 7 Oct 2021 19:21:29 +0000 (GMT)
Received: from oro.sl.cloud9.ibm.com (unknown [9.59.192.176])
by b03ledav001.gho.boulder.ibm.com (Postfix) with ESMTP;
Thu, 7 Oct 2021 19:21:29 +0000 (GMT)
X-MC-Unique: pbIzhy6XOW6_n7unnW_oVg-1
X-MC-Unique: qPdJ3tcSN2y9a7eWzZQrAA-1
From: Or Ozeri
To: libvir-list@redhat.com
Subject: [PATCH v4 4/5] qemu: add librbd encryption engine
Date: Thu, 7 Oct 2021 14:21:20 -0500
Message-Id: <20211007192121.1052752-5-oro@il.ibm.com>
In-Reply-To: <20211007192121.1052752-1-oro@il.ibm.com>
References: <20211007192121.1052752-1-oro@il.ibm.com>
MIME-Version: 1.0
X-TM-AS-GCONF: 00
X-Proofpoint-ORIG-GUID: N6Cl0pCjqiOUkNk1ptH5fRdL8tOZaX-w
X-Proofpoint-GUID: wdSrt66HspncpWQUmDP83TyiJkcZUUHf
X-Proofpoint-Virus-Version: vendor=baseguard
engine=ICAP:2.0.182.1, Aquarius:18.0.790, Hydra:6.0.391,
FMLib:17.0.607.475
definitions=2021-10-07_03,2021-10-07_02,2020-04-07_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0
mlxscore=0 bulkscore=0
suspectscore=0 clxscore=1015 lowpriorityscore=0 spamscore=0
malwarescore=0
priorityscore=1501 impostorscore=0 adultscore=0 phishscore=0
mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1
engine=8.12.0-2109230001 definitions=main-2110070123
X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection
Definition; Similar Internal Domain=false;
Similar Monitored External Domain=false;
Custom External Domain=false; Mimecast External Domain=false;
Newly Observed Domain=false; Internal User Name=false;
Custom Display Name List=false; Reply-to Address Mismatch=false;
Targeted Threat Dictionary=false;
Mimecast Threat Dictionary=false; Custom Threat Dictionary=false
X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6
X-loop: libvir-list@redhat.com
Cc: idryomov@gmail.com, Or Ozeri , to.my.trociny@gmail.com,
dannyh@il.ibm.com
X-BeenThere: libvir-list@redhat.com
X-Mailman-Version: 2.1.12
Precedence: junk
List-Id: Development discussions about the libvirt library & tools
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Sender: libvir-list-bounces@redhat.com
Errors-To: libvir-list-bounces@redhat.com
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14
Authentication-Results: relay.mimecast.com;
auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Transfer-Encoding: quoted-printable
X-ZM-MESSAGEID: 1633637066594100001
Content-Type: text/plain; charset="utf-8"
rbd encryption is new in qemu 6.1.0.
This commit adds a new encryption engine property which
allows the user to use this new encryption engine.
Signed-off-by: Or Ozeri
Reviewed-by: Peter Krempa
---
docs/formatstorageencryption.html.in | 7 +-
docs/schemas/storagecommon.rng | 1 +
src/conf/storage_encryption_conf.c | 2 +-
src/conf/storage_encryption_conf.h | 1 +
src/qemu/qemu_block.c | 26 +++++++
src/qemu/qemu_domain.c | 34 +++++++++
...sk-network-rbd-encryption.x86_64-6.0.0.err | 1 +
...-network-rbd-encryption.x86_64-latest.args | 45 ++++++++++++
.../disk-network-rbd-encryption.xml | 63 +++++++++++++++++
tests/qemuxml2argvtest.c | 2 +
...k-network-rbd-encryption.x86_64-latest.xml | 70 +++++++++++++++++++
tests/qemuxml2xmltest.c | 1 +
12 files changed, 251 insertions(+), 2 deletions(-)
create mode 100644 tests/qemuxml2argvdata/disk-network-rbd-encryption.x86_=
64-6.0.0.err
create mode 100644 tests/qemuxml2argvdata/disk-network-rbd-encryption.x86_=
64-latest.args
create mode 100644 tests/qemuxml2argvdata/disk-network-rbd-encryption.xml
create mode 100644 tests/qemuxml2xmloutdata/disk-network-rbd-encryption.x8=
6_64-latest.xml
diff --git a/docs/formatstorageencryption.html.in b/docs/formatstorageencry=
ption.html.in
index 178fcd0d7c..02ee8f8ca3 100644
--- a/docs/formatstorageencryption.html.in
+++ b/docs/formatstorageencryption.html.in
@@ -27,7 +27,12 @@
The encryption tag supports an optional engine
tag, which allows selecting which component actually handles
the encryption. Currently defined values of engine are
- qemu.
+ qemu and librbd.
+ Both qemu and librbd require using the qem=
u driver.
+ The librbd engine requires qemu version >=3D 6.1.0,
+ and is only applicable for RBD network disks.
+ If the engine tag is not specified, the qemu engine wil=
l be
+ used by default (assuming the qemu driver is used).