From nobody Fri Apr 19 19:00:50 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1633368578284917.7257606195782; Mon, 4 Oct 2021 10:29:38 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-13-yKJJp2RkP2GylvN2v0YncQ-1; Mon, 04 Oct 2021 13:29:35 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C20D5835DE0; Mon, 4 Oct 2021 17:29:30 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7A04C5C1D5; Mon, 4 Oct 2021 17:29:30 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 349D31800FE4; Mon, 4 Oct 2021 17:29:30 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 194HQrU4031085 for ; Mon, 4 Oct 2021 13:26:53 -0400 Received: by smtp.corp.redhat.com (Postfix) id E8A79215673F; Mon, 4 Oct 2021 17:26:52 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast02.extmail.prod.ext.rdu2.redhat.com [10.11.55.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E08E2215673B for ; Mon, 4 Oct 2021 17:26:47 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 16BA6802803 for ; Mon, 4 Oct 2021 17:26:47 +0000 (UTC) Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-271-NaZv7zS8PQyhIWSUVAqAmQ-1; Mon, 04 Oct 2021 13:26:43 -0400 Received: by mail-pg1-f174.google.com with SMTP id 75so17233103pga.3 for ; Mon, 04 Oct 2021 10:26:43 -0700 (PDT) Received: from anisinha-lenovo.ba.nuagenetworks.net ([115.96.107.9]) by smtp.googlemail.com with ESMTPSA id gj6sm8132609pjb.34.2021.10.04.10.26.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Oct 2021 10:26:41 -0700 (PDT) X-MC-Unique: yKJJp2RkP2GylvN2v0YncQ-1 X-MC-Unique: NaZv7zS8PQyhIWSUVAqAmQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=d6LsF61RMPZn35Yx+fxeMsLw6yPAtCMNlHLo0jllDVY=; b=2TVrLy2ihxle4TALzBtwy5lhabErOxk6QwI5UagYjlMYcuQvtwqboaWTpwp/2FccLg hmeGWgBZ/GlMLwY1d0rdtDz1I0eAk4Z3ufbz5ylhF/tzxn7vLGIoR2F0UO6Lx4BUPPlQ uX7kwh2sxTkx/tWmD0dseljGSDmaWlVX7YX0stO0fqJNxUQrcckXhL+eI5sW0rJRrBxJ Pdrze/YpsgdqwVpgcpdLAGdLL7l/7x5ehJNbeHHSrMSSnBPKB2ntvoecgHUrARh0+9XJ GRMPEE6absZKA+3wv1Rl5a1LFqd7fEBbl6IsNxIM2s6wJ8YTWRmUgFg4LAfAlAPUKcpd D6MA== X-Gm-Message-State: AOAM532hAG+5i8lOZjxkcZKLRea/NRNmm4v87Shdd0G6QKeua9+/Fsgr AMKlWjaJGL/DkdobYn92Fr+DbzHMC3uEuQ== X-Google-Smtp-Source: ABdhPJwxxTtbdvCDK+qFpLe0pR7RHg6ea69YnoljjG8jqImG5GSWZJcNw04kyFUQeOCvAH7TdCgpGA== X-Received: by 2002:a63:d2:: with SMTP id 201mr11859296pga.400.1633368402171; Mon, 04 Oct 2021 10:26:42 -0700 (PDT) From: Ani Sinha To: libvir-list@redhat.com, abologna@redhat.com Subject: [PATCH] qemu: capabilities: rename piix4-acpi-root-hotplug-en to more appropriate name Date: Mon, 4 Oct 2021 22:56:13 +0530 Message-Id: <20211004172613.914883-1-ani@anisinha.ca> MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-loop: libvir-list@redhat.com Cc: Ani Sinha X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1633368579190100001 Content-Type: text/plain; charset="utf-8" The capability name piix4-acpi-root-hotplug-en is not conventional and appreared to be confusing to some. "en" suffix is also incorrect as the capability in qemu is used to both enable and disable hotplug on the pci ro= ot bus on the i440fx. Hence, rename it to piix4.acpi-root-pci-hotplug so that = it is clearer, less confusing and more accurate. Signed-off-by: Ani Sinha Reviewed-by: Laine Stump --- src/qemu/qemu_capabilities.c | 2 +- tests/qemucapabilitiesdata/caps_5.2.0.x86_64.xml | 2 +- tests/qemucapabilitiesdata/caps_6.0.0.x86_64.xml | 2 +- tests/qemucapabilitiesdata/caps_6.1.0.x86_64.xml | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 9d0c96a20c..d7b79ef7c0 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -641,7 +641,7 @@ VIR_ENUM_IMPL(virQEMUCaps, "virtio-blk.queue-size", /* QEMU_CAPS_VIRTIO_BLK_QUEUE_SIZE = */ =20 /* 410 */ - "piix4-acpi-root-hotplug-en", /* QEMU_CAPS_PIIX_ACPI_ROOT_PC= I_HOTPLUG */ + "piix4.acpi-root-pci-hotplug", /* QEMU_CAPS_PIIX_ACPI_ROOT_P= CI_HOTPLUG */ ); =20 =20 diff --git a/tests/qemucapabilitiesdata/caps_5.2.0.x86_64.xml b/tests/qemuc= apabilitiesdata/caps_5.2.0.x86_64.xml index 1e5833a9f0..834fb86636 100644 --- a/tests/qemucapabilitiesdata/caps_5.2.0.x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_5.2.0.x86_64.xml @@ -230,7 +230,7 @@ - + 5002000 0 43100243 diff --git a/tests/qemucapabilitiesdata/caps_6.0.0.x86_64.xml b/tests/qemuc= apabilitiesdata/caps_6.0.0.x86_64.xml index b54dd8a22e..e9d1a26400 100644 --- a/tests/qemucapabilitiesdata/caps_6.0.0.x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_6.0.0.x86_64.xml @@ -238,7 +238,7 @@ - + 6000000 0 43100242 diff --git a/tests/qemucapabilitiesdata/caps_6.1.0.x86_64.xml b/tests/qemuc= apabilitiesdata/caps_6.1.0.x86_64.xml index 0ad493191d..971d55e0cc 100644 --- a/tests/qemucapabilitiesdata/caps_6.1.0.x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_6.1.0.x86_64.xml @@ -240,7 +240,7 @@ - + 6001000 0 43100243 --=20 2.25.1