From nobody Wed Feb 11 03:30:10 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1633001134; cv=none; d=zohomail.com; s=zohoarc; b=XmmgUk088npNw4tAUhympaDXBOPCFiAPL5WhfMZojqDPi6fXuV/atiZATS3rGiw5clRyzRPrz1KwIQGubmPEv+6aUSv1vjHGboFBLdAMe+sIG4lhDRCbqHw3iUcO20NTfn8CgJyJqrtYzuKJOQ95lL80xIZkVotkpVdLZ4ChFzg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1633001134; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=vJrgy6AmepKmK9CREwswzOOk35IWU92hTXh4671gHtU=; b=BwKkr6BkxtyfyUM4GrdwwwQoMBv64z0rGxdK6COGG05vupPsyaEko/aI6UBtfYaLp83uTnNYzs5sJ0NFVfPVIxCwB2SgG8UubWbCwsFc6PNqRW4Og9fgncSguFW8NNB1mLr6Aj3ti70zwBf6BWrjD/T22t8KpKxa67/CGdzZI2k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1633001134223560.1020716839502; Thu, 30 Sep 2021 04:25:34 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-356-Ss7rJGQpPp265S6A3PeG1g-1; Thu, 30 Sep 2021 07:25:30 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B3A711084686; Thu, 30 Sep 2021 11:25:25 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 95CD260BE5; Thu, 30 Sep 2021 11:25:25 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 659A24EA2A; Thu, 30 Sep 2021 11:25:25 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 18UBPNfg021164 for ; Thu, 30 Sep 2021 07:25:23 -0400 Received: by smtp.corp.redhat.com (Postfix) id 69FEC5F4F7; Thu, 30 Sep 2021 11:25:23 +0000 (UTC) Received: from work.redhat.com (unknown [10.39.194.122]) by smtp.corp.redhat.com (Postfix) with ESMTP id B3A2F5F4FE; Thu, 30 Sep 2021 11:25:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1633001133; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=vJrgy6AmepKmK9CREwswzOOk35IWU92hTXh4671gHtU=; b=XcZx6Ye7gl8ZKuqeIwsa15Bnf8QzvQF8/kLI/IOHUXVilRlCaiYmya/DCbvrbIPavQnqQQ Mxf65CtqCEd/AkkaqCqOSkmPDR0+SGsxZgaBczEUCkhRjnUM1UEsxrX5UprlmGERL1Q2ec n8LWN9dz+ra/nd5+GHjkCGayboXKkqc= X-MC-Unique: Ss7rJGQpPp265S6A3PeG1g-1 From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH v3 8/9] bhyveAutostartDomain: Use virObjectLockGuard Date: Thu, 30 Sep 2021 13:24:58 +0200 Message-Id: <20210930112459.11429-9-twiederh@redhat.com> In-Reply-To: <20210930112459.11429-1-twiederh@redhat.com> References: <20210930112459.11429-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Cc: Tim Wiederhake X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1633002037329100001 Content-Type: text/plain; charset="utf-8" Signed-off-by: Tim Wiederhake --- src/bhyve/bhyve_driver.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/bhyve/bhyve_driver.c b/src/bhyve/bhyve_driver.c index 516490f6cd..c41de30be9 100644 --- a/src/bhyve/bhyve_driver.c +++ b/src/bhyve/bhyve_driver.c @@ -87,7 +87,8 @@ bhyveAutostartDomain(virDomainObj *vm, void *opaque) { const struct bhyveAutostartData *data =3D opaque; int ret =3D 0; - virObjectLock(vm); + VIR_LOCK_GUARD lock =3D virObjectLockGuard(vm); + if (vm->autostart && !virDomainObjIsActive(vm)) { virResetLastError(); ret =3D virBhyveProcessStart(data->conn, vm, @@ -98,7 +99,6 @@ bhyveAutostartDomain(virDomainObj *vm, void *opaque) vm->def->name, virGetLastErrorMessage()); } } - virObjectUnlock(vm); return ret; } =20 --=20 2.31.1