From nobody Wed Feb 11 03:24:37 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1633001164; cv=none; d=zohomail.com; s=zohoarc; b=UuodnSpsLUTn8YqGcdKUbmgi+1wbFZHiyZj+BivMQFPmWbnRnjhbOLaEV5hdAcm/eoAGuFXHBTNal9q2pNYtBJxyyXVrVa2z1/IQpdfk0/5RNYcu8Sp/AUk+LbFjJEc73ri2VGbBM5YXQaYSRkxzBvyLAcWDJuAVA9ZLFfASNxY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1633001164; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=KgMRrtQofiRmzgzeeJPAqzDYZm0uw6TKrxh6PpEqAbY=; b=aJI33BbRoxHHl5GArd/1CRyF0WU8MQoN/5cnp3aI/tOgGYXo6mA/brO7Er5WrhbUL16BYjC1XdCdUxhKVdDTDzuyfyUeMFrKdJ6rWMaJdC+xLtQHOY0gK2W2Jg/147mrUM58L02CTXLfMKt/Du7/S+6z8xusobWul5UDau4ZPno= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1633001164001551.4476670135589; Thu, 30 Sep 2021 04:26:04 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-481-8Lk22GsLP262zdc6EIFnrg-1; Thu, 30 Sep 2021 07:25:34 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E519F835DF8; Thu, 30 Sep 2021 11:25:28 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 95A8A60FB8; Thu, 30 Sep 2021 11:25:28 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 4BF6C1806D03; Thu, 30 Sep 2021 11:25:28 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 18UBPOwm021171 for ; Thu, 30 Sep 2021 07:25:24 -0400 Received: by smtp.corp.redhat.com (Postfix) id 72EF45F4FC; Thu, 30 Sep 2021 11:25:24 +0000 (UTC) Received: from work.redhat.com (unknown [10.39.194.122]) by smtp.corp.redhat.com (Postfix) with ESMTP id BD7975F4F7; Thu, 30 Sep 2021 11:25:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1633001163; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=KgMRrtQofiRmzgzeeJPAqzDYZm0uw6TKrxh6PpEqAbY=; b=Cyh+G3/Irr5rmxjtOJuUkeoeU2jS1RxdnzfFAz/8rgAwfgLlE/Jbd44SGDrDpmqaTJKOM8 F1L8dhNYy4385D8RvqBLYUkt3ZYoSbtS6lKRVqW6+uqA3QlvHvhA1jxTwxxmMS2pKmR7mz 3NPRgTVuIny4FmWq+trFBsgwu1M2Xak= X-MC-Unique: 8Lk22GsLP262zdc6EIFnrg-1 From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH v3 9/9] lxcDomainDetachDeviceHostdevUSBLive: Use VIR_WITH_OBJECT_LOCK_GUARD Date: Thu, 30 Sep 2021 13:24:59 +0200 Message-Id: <20210930112459.11429-10-twiederh@redhat.com> In-Reply-To: <20210930112459.11429-1-twiederh@redhat.com> References: <20210930112459.11429-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Cc: Tim Wiederhake X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1633001164625100001 Content-Type: text/plain; charset="utf-8" Signed-off-by: Tim Wiederhake --- src/lxc/lxc_driver.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c index e2720a6f89..528af5d164 100644 --- a/src/lxc/lxc_driver.c +++ b/src/lxc/lxc_driver.c @@ -4079,9 +4079,9 @@ lxcDomainDetachDeviceHostdevUSBLive(virLXCDriver *dri= ver, VIR_WARN("cannot deny device %s for domain %s: %s", dst, vm->def->name, virGetLastErrorMessage()); =20 - virObjectLock(hostdev_mgr->activeUSBHostdevs); - virUSBDeviceListDel(hostdev_mgr->activeUSBHostdevs, usb); - virObjectUnlock(hostdev_mgr->activeUSBHostdevs); + VIR_WITH_OBJECT_LOCK_GUARD(hostdev_mgr->activeUSBHostdevs) { + virUSBDeviceListDel(hostdev_mgr->activeUSBHostdevs, usb); + } =20 virDomainHostdevRemove(vm->def, idx); virDomainHostdevDefFree(def); --=20 2.31.1