From nobody Sat May 4 20:23:53 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=quarantine dis=quarantine) header.from=suse.com Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 16315711432885.32188188942564; Mon, 13 Sep 2021 15:12:23 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-197-xnx7x3R4NV-T-bGebfyICA-1; Mon, 13 Sep 2021 18:12:20 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 81B59800FF3; Mon, 13 Sep 2021 22:12:15 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CF4A8781EE; Mon, 13 Sep 2021 22:12:14 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 18A5C4E58E; Mon, 13 Sep 2021 22:12:13 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 18DMB4sw029644 for ; Mon, 13 Sep 2021 18:11:04 -0400 Received: by smtp.corp.redhat.com (Postfix) id 927EA21568BD; Mon, 13 Sep 2021 22:11:04 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast06.extmail.prod.ext.rdu2.redhat.com [10.11.55.22]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8B19121568BE for ; Mon, 13 Sep 2021 22:11:01 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 82822185A794 for ; Mon, 13 Sep 2021 22:11:01 +0000 (UTC) Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-501-3eVocgoHNxOnQF9Y_tK5ow-1; Mon, 13 Sep 2021 18:10:59 -0400 Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-db5eur03lp2057.outbound.protection.outlook.com [104.47.10.57]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-22-XZeHVmeqPNSD2xGae0Kbbg-1; Tue, 14 Sep 2021 00:10:55 +0200 Received: from AM8PR04MB7970.eurprd04.prod.outlook.com (2603:10a6:20b:24f::9) by AM0PR0402MB3906.eurprd04.prod.outlook.com (2603:10a6:208:e::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14; Mon, 13 Sep 2021 22:10:55 +0000 Received: from AM8PR04MB7970.eurprd04.prod.outlook.com ([fe80::283c:d53f:95d5:9377]) by AM8PR04MB7970.eurprd04.prod.outlook.com ([fe80::283c:d53f:95d5:9377%8]) with mapi id 15.20.4500.019; Mon, 13 Sep 2021 22:10:55 +0000 Received: from localhost (192.225.185.198) by PR0P264CA0253.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14 via Frontend Transport; Mon, 13 Sep 2021 22:10:54 +0000 X-MC-Unique: xnx7x3R4NV-T-bGebfyICA-1 X-MC-Unique: 3eVocgoHNxOnQF9Y_tK5ow-1 X-MC-Unique: XZeHVmeqPNSD2xGae0Kbbg-1 From: Jim Fehlig To: libvir-list@redhat.com Subject: [PATCH] libxl: Fix driver reload Date: Mon, 13 Sep 2021 16:10:51 -0600 Message-ID: <20210913221051.1015-1-jfehlig@suse.com> X-ClientProxiedBy: PR0P264CA0253.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100::25) To AM8PR04MB7970.eurprd04.prod.outlook.com (2603:10a6:20b:24f::9) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 39485332-e5d8-4062-94a0-08d977035b52 X-MS-TrafficTypeDiagnostic: AM0PR0402MB3906: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0 X-Microsoft-Antispam-Message-Info: JkWjGuzM2aFBAupKg5Cl6dl9DcpwLFJDHjsQPYAWTEQIsihTe1cLlWIH8uhoB0hqX+2uTSkkdScNU9pHZ+nErEkJAjj9kpXDejGgEKMmF7ISWsPaX0fmeBkA9HiSNmP5NbmPM1j5iJqmxSjDlaW6gqm2/v5E6Pgj0hzzh81dS/zytXqvt3MCnIIKLb5nlC8omztlAmznZvjqKCMV2R0EmvnZVqp0gn+q5t/QCBmn2e7h/DK75cZiTM3NDS3WUXVmLj4cxM1wToXUJW4e5zBLU8e5fJfbjKs2FZ95sjGTTS8sAAf1twjj8Gsb2dJcy7+vHtrXXv94zvl5cU/3NK0MmgtYTHakG1dNXAaIJ86EPocASDpU3VzQ8pZ1dCabYXsqxrVULnrkcRfgvO2/pLZNGMj5TO1THzazNLdQ1lkPO2A0r6dqiuSLrC+vwYGCj4ClSNLWCDUBjWjnaySi63HqbPxfTld0gPJQBX3j9aqpcqKiTmVekIP5wFL4oOnH6qx7RFVJBGAJz5+iT8r5k5opTusgC2FtjARcsF5L4H4a7WnTU4xN2Fo+U7qWXCZUSYwfXfViYnq4jXGWFQSviFk+owMLUZyO0Tf7OHUxdxgK6mct/9fCRfQr/jkh7R08+UhHzBFOko42gJt0ev9skT7ucA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM8PR04MB7970.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(136003)(376002)(39860400002)(396003)(366004)(346002)(5660300002)(36756003)(478600001)(1076003)(186003)(26005)(4744005)(6666004)(316002)(8936002)(8676002)(6496006)(6916009)(956004)(2616005)(66476007)(66556008)(66946007)(38100700002)(6486002)(86362001)(83380400001)(2906002); DIR:OUT; SFP:1101 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?xOqq+UenGu3K37bSRuiDb+ONDdrQfet7YqkUqxKs5wzxXLFquSsfyynf6VdL?= =?us-ascii?Q?WPFK7b7JKnDC6f36LDFzPbh6GbbGCpkum2E921t9zC+0FKvD7P4STnZuYFU2?= =?us-ascii?Q?SuMLfyZVu6zCrOfHvC3S01G3J49rcQKS7sDX4Yvh5CMh3GTYFf4RspvYjgP6?= =?us-ascii?Q?BmxtzFt7kuSjJDgFMNowmD3h88of88T8VEdj1QPmnpL/22+RVlLfHHNUIX+x?= =?us-ascii?Q?VjNT9mLZcGvLGItkQzU/iWnyrCo/p+az3DFAZekF51xF2g0sEnTBV6s0CSwE?= =?us-ascii?Q?AEl2pFSMMQfRxvYuzUjxcPSJgU8j39S+Rlo1WAz2O7PdmHwUOJdCT1c8SiRD?= =?us-ascii?Q?Lxw6+HUZ37UPjFo90C2+n8ZiVG+is64YETIE4rRAq3AUoZxkl9puOu7PII95?= =?us-ascii?Q?az0Zebk9HrBjtjaLrcpq+PhD2sxnaKie6dGFc9UvxJHjczHiFC0jtgtHoe7b?= =?us-ascii?Q?Jca+LrIFPshKs4FdY96Qnx3dPmNNvrAYQjckU0/DDWWZ8krCg8RHAxWQlZFa?= =?us-ascii?Q?DeeRGL912Hn18BosPtOPwUOysXGFoANckSSFXonlGh5zD0YVshN719Xqo5Ro?= =?us-ascii?Q?3oAPMgVPXpa4agUJ4fOuQlK70qD8AWpFlAEUuXgtGk/4GibsvyOV9DRW5aUj?= =?us-ascii?Q?x8/8C27fLcM1YFLLwvlnEy7nHfZ6OvnbL0qcSqGbTheW6ES84I98+JnFxzBl?= =?us-ascii?Q?NU8GkHvAtNq9colgSfAS6RuWVJuZiid9z8U4Yu612Lr3z86d/CU13ngRnp+9?= =?us-ascii?Q?laLnvzSIwbWxIbD6VS96m7N0NrcihryzZq5fqAJ84nuQ6zdmX+SgJ9bmxH1E?= =?us-ascii?Q?U7WZ0rAxwVKCV9soIuL2ArkA7WfeDUqMkoO7NFmyybV3FHfelrPT9+vuf4iy?= =?us-ascii?Q?0mAElVzXmouBUACEiwyMSqsq5jHCuE4yaI9RANz1ID66CTLlffdW+Pk6FsNh?= =?us-ascii?Q?7i3JptWvkX2vCOul7sXAVXs6zg2lUFtMVXcqIFY432SOIKRPPHJJH1PHRGZ/?= =?us-ascii?Q?VkzwaBvHNRO2w9P+q1b3Y/TOCAmJ+yjkvo7e++j0xK2X7XXDGoYACVcsxsOQ?= =?us-ascii?Q?2yeLzdQfm4OgqJqdTAFzz4iVv5Z2QLxkA09PhwookazNjnZCV6yBJCj8iNp0?= =?us-ascii?Q?qnDr1aHUnwK0yUtGPPjcwnJLPDqLqJpeQUfBlASeTiyh6dJYix/UVcwU4eLN?= =?us-ascii?Q?xxuH4zEfd9oJznCULTTObIpS85v5fHoJ5CvP+I2/mlehHnGxcVyrKFf/6ZbI?= =?us-ascii?Q?9pzci64mzvAVFgkuuxN2dxR6FRscesKVrNFFFUA7z5i0lWdtwUm5OPd8cJ2U?= =?us-ascii?Q?EHHBzXJwnZTZFhdzJi+g2sMS?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 39485332-e5d8-4062-94a0-08d977035b52 X-MS-Exchange-CrossTenant-AuthSource: AM8PR04MB7970.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Sep 2021 22:10:55.1407 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IBWnCaNAT1k8g997EI+JJycxQS91F4AWJwJvZXEiccGilcSAKHtt1H+gKx4UZy7TW44yyZ3XcEzJRNhiUYNfkQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0402MB3906 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-MIME-Autoconverted: from quoted-printable to 8bit by lists01.pubmisc.prod.ext.phx2.redhat.com id 18DMB4sw029644 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1631571144981100002 Content-Type: text/plain; charset="utf-8" On reload, the libxl driver calls virDomainObjListLoadAllConfigs to load all configs from /etc/libvirt/libxl/ but incorrectly passes 'true' for the liveStatus parameter, resulting in error messages such as libvirtd[21053]: XML error: unexpected root element , expecting libvirtd[21053]: Failed to load config for domain 'sles15sp3' Fix by not requesting live status when re-reading the persistent VM config files. Signed-off-by: Jim Fehlig Reviewed-by: Michal Privoznik --- src/libxl/libxl_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index 6a3938ead4..c5dbcaafa5 100644 --- a/src/libxl/libxl_driver.c +++ b/src/libxl/libxl_driver.c @@ -821,7 +821,7 @@ libxlStateReload(void) virDomainObjListLoadAllConfigs(libxl_driver->domains, cfg->configDir, cfg->autostartDir, - true, + false, libxl_driver->xmlopt, NULL, libxl_driver); =20 --=20 2.33.0