From nobody Tue Feb 10 00:39:47 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1631417248787831.9757152611447; Sat, 11 Sep 2021 20:27:28 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-211-bCHIWtNXMuCTpZPj0-lG-w-1; Sat, 11 Sep 2021 23:27:26 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6A4F18015C7; Sun, 12 Sep 2021 03:27:21 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4722319C59; Sun, 12 Sep 2021 03:27:21 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 1825A1805986; Sun, 12 Sep 2021 03:27:21 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 18C3QpqF032393 for ; Sat, 11 Sep 2021 23:26:51 -0400 Received: by smtp.corp.redhat.com (Postfix) id 828732166BA2; Sun, 12 Sep 2021 03:26:51 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast06.extmail.prod.ext.rdu2.redhat.com [10.11.55.22]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7D8252166B3F for ; Sun, 12 Sep 2021 03:26:51 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 651C7185A794 for ; Sun, 12 Sep 2021 03:26:51 +0000 (UTC) Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-542-2FMhtfm5Pv-NpBXWFV3wDA-1; Sat, 11 Sep 2021 23:26:49 -0400 Received: by mail-pg1-f180.google.com with SMTP id w8so5912235pgf.5 for ; Sat, 11 Sep 2021 20:26:49 -0700 (PDT) Received: from anisinha-lenovo.ba.nuagenetworks.net ([115.96.79.166]) by smtp.googlemail.com with ESMTPSA id w5sm2854343pfu.160.2021.09.11.20.26.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Sep 2021 20:26:47 -0700 (PDT) X-MC-Unique: bCHIWtNXMuCTpZPj0-lG-w-1 X-MC-Unique: 2FMhtfm5Pv-NpBXWFV3wDA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=njrbSwCuzsL0JB56z/2JtUXrUgr34/Um5Ik+X3bSvJI=; b=1eYTwiGiVSsc6iKOo4mw0X2Uy+/ptVzQfu4InrnifZieeuSq4Fc5zAJxXhMk/kDQ+7 3NsCmLBYNkbiVrtdWkId8rSARAy+adAaGc98SyEiDvWKoqRrWm6JZyewMEO+P8GdZB4K 7qHXebHnTsrKuJF/pfQ8eWSvqiCXLvdknDCCypennl1zHSTgDPvVQUXyEknIcmrj+EfY GS+VroOX2U17+MS+herqoiM05dR6YyXmNdjitTgv5cQ9yv738ADLyU6Z28sIpvIzeR7b y8N3Iz50iKo96Ha3nwvputfKb9wYR4T7keTxAIid5GzDBSTspC8d83NeH/d9ngsUAcg2 OdBQ== X-Gm-Message-State: AOAM532s+0y1Kz39a6gvU7MXnBhopeMAlfzdOX5CbE3VMnDicYzChdS8 dvNWSu/xrkwy2b+Iqul5+Nt4htRthYVBIA== X-Google-Smtp-Source: ABdhPJwmuYfrPtF2oDLgUoDosK4bNmMTLhW/+5T4DIeJ/jWgywUfu47JKRcjQ/QCgW5uXNnTzwm84g== X-Received: by 2002:a05:6a00:124f:b0:416:4ed7:e4c6 with SMTP id u15-20020a056a00124f00b004164ed7e4c6mr4960822pfi.85.1631417207630; Sat, 11 Sep 2021 20:26:47 -0700 (PDT) From: Ani Sinha To: libvir-list@redhat.com Subject: [PATCH v3 2/5] qemu: capablities: detect presence of acpi-root-pci-hotplug for i440fx machines Date: Sun, 12 Sep 2021 08:56:28 +0530 Message-Id: <20210912032631.2853520-3-ani@anisinha.ca> In-Reply-To: <20210912032631.2853520-1-ani@anisinha.ca> References: <20210912032631.2853520-1-ani@anisinha.ca> MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-loop: libvir-list@redhat.com Cc: ani@anisinha.ca, jusual@redhat.com, laine@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1631417250419100001 Content-Type: text/plain; charset="utf-8" The following change in qemu added support for a global boolean flag specif= ic to i440fx machines that would turn off or on acpi based hotplug for pci root bus: 3d7e78aa7777f ("Introduce a new flag for i440fx to disable PCI hotplug on t= he root bus") The option is passed as "-global PIIX4_PM.acpi-root-pci-hotplug=3Don" etc i= n qemu commandline. It is enabled by default. This patch adds the corresponding qe= mu capabilities in libvirt as QEMU_CAPS_PIIX_ACPI_ROOT_PCI_HOTPLUG. Please note that the test specific qemu capabilities .replies files has alr= eady been updated as a part of regular refreshing them when a new qemu version is released. Hence, no updates to those files are required. Signed-off-by: Ani Sinha Reviewed-by: Laine Stump --- src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + tests/qemucapabilitiesdata/caps_5.2.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_6.0.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_6.1.0.x86_64.xml | 1 + 5 files changed, 6 insertions(+) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index c954e42382..706169a5cf 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -642,6 +642,7 @@ VIR_ENUM_IMPL(virQEMUCaps, =20 /* 410 */ "ich9-acpi-hotplug-bridge", /* QEMU_CAPS_ICH9_ACPI_HOTPLUG_B= RIDGE */ + "piix4-acpi-root-hotplug-en", /* QEMU_CAPS_PIIX_ACPI_ROOT_PC= I_HOTPLUG */ ); =20 =20 @@ -1470,6 +1471,7 @@ static struct virQEMUCapsDevicePropsFlags virQEMUCaps= DevicePropsPiix4PM[] =3D { { "disable_s3", QEMU_CAPS_PIIX_DISABLE_S3, NULL }, { "disable_s4", QEMU_CAPS_PIIX_DISABLE_S4, NULL }, { "acpi-pci-hotplug-with-bridge-support", QEMU_CAPS_PIIX_ACPI_HOTPLUG_= BRIDGE, NULL }, + { "acpi-root-pci-hotplug", QEMU_CAPS_PIIX_ACPI_ROOT_PCI_HOTPLUG, NULL = }, }; =20 static struct virQEMUCapsDevicePropsFlags virQEMUCapsDevicePropsUSBRedir[]= =3D { diff --git a/src/qemu/qemu_capabilities.h b/src/qemu/qemu_capabilities.h index f53009b6e9..b0f9559d95 100644 --- a/src/qemu/qemu_capabilities.h +++ b/src/qemu/qemu_capabilities.h @@ -622,6 +622,7 @@ typedef enum { /* virQEMUCapsFlags grouping marker for = syntax-check */ =20 /* 410 */ QEMU_CAPS_ICH9_ACPI_HOTPLUG_BRIDGE, /* -M q35 ICH9-LPC.acpi-pci-hotplu= g-with-bridge-support */ + QEMU_CAPS_PIIX_ACPI_ROOT_PCI_HOTPLUG, /* -M pc PIIX4_PM.acpi-root-pci-= hotplug */ =20 QEMU_CAPS_LAST /* this must always be the last item */ } virQEMUCapsFlags; diff --git a/tests/qemucapabilitiesdata/caps_5.2.0.x86_64.xml b/tests/qemuc= apabilitiesdata/caps_5.2.0.x86_64.xml index 126bae2401..da52eda200 100644 --- a/tests/qemucapabilitiesdata/caps_5.2.0.x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_5.2.0.x86_64.xml @@ -247,6 +247,7 @@ + 5002000 0 43100243 diff --git a/tests/qemucapabilitiesdata/caps_6.0.0.x86_64.xml b/tests/qemuc= apabilitiesdata/caps_6.0.0.x86_64.xml index b01db2dfbe..d75760f1f8 100644 --- a/tests/qemucapabilitiesdata/caps_6.0.0.x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_6.0.0.x86_64.xml @@ -255,6 +255,7 @@ + 6000000 0 43100242 diff --git a/tests/qemucapabilitiesdata/caps_6.1.0.x86_64.xml b/tests/qemuc= apabilitiesdata/caps_6.1.0.x86_64.xml index b136853aba..8fd3c51f4e 100644 --- a/tests/qemucapabilitiesdata/caps_6.1.0.x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_6.1.0.x86_64.xml @@ -258,6 +258,7 @@ + 6001000 0 43100243 --=20 2.25.1