From nobody Sun Feb 8 19:54:42 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1631186742; cv=none; d=zohomail.com; s=zohoarc; b=Uo8ANaNUBr6luPkjC4BIDTQzB+kVMcyPQSQwt1RWugMBtg1aH2sOoZhgAj1heyn6eZqWeqnfuv+e2mkCdIay1eBzq/REmG9dmLghdgP56EQJmWs9zgvffOEEuAlt3wgOlNKgSqtoLH78TuoBrvEra4fBrvK01OnidVJka1fo8sw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1631186742; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=FTEfLD6ZiJoScFuAsRWIF29d69wz6oXk8k5jjMnpCl4=; b=RlODaimKQLGpyFdbMGS4ChBfdalOcLmzuPldG79z1uYyicfhPpPSLx/RmPUNBqQKfhXhEcpFDSPmf/soEsmr2u61LfsKCMuNgduF8guJUo7kYOVVfsDvJ0wRdE6mXQTx6ojBA4OM2WQ3wNaWPNkTbOmMGxnG9MstmZvPkv93Guk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1631186742779423.9185927238658; Thu, 9 Sep 2021 04:25:42 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-111-GPVOzvo2MoOU0AbqnG3Z2g-1; Thu, 09 Sep 2021 07:25:39 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A77D7835DEB; Thu, 9 Sep 2021 11:25:34 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 883AA5D9F4; Thu, 9 Sep 2021 11:25:34 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 589A51806D01; Thu, 9 Sep 2021 11:25:34 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 189BPNgs013951 for ; Thu, 9 Sep 2021 07:25:23 -0400 Received: by smtp.corp.redhat.com (Postfix) id DD8ED1ABD8; Thu, 9 Sep 2021 11:25:23 +0000 (UTC) Received: from localhost.localdomain.com (unknown [10.39.195.19]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4533F5D6AD; Thu, 9 Sep 2021 11:25:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631186741; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=FTEfLD6ZiJoScFuAsRWIF29d69wz6oXk8k5jjMnpCl4=; b=df5BtBdW1YHKchz7G5pqTNJaA5cZLhlu+TeDVnWysPZ07tEozm/lnRoPHX4fkm0PNKzzgo H42fR0354Tq8Z5uryqLh1y30+HtEIAutPVmLZWu8OzGFGyG2EGFpUwyw5xnhr8UqxYVLDr 4ikS45lSQ9BST0LpoIRqpquKeH9d5T4= X-MC-Unique: GPVOzvo2MoOU0AbqnG3Z2g-1 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: libvir-list@redhat.com Subject: [libvirt PATCH 2/4] qemu: tweak error message to be more general purpose Date: Thu, 9 Sep 2021 12:25:14 +0100 Message-Id: <20210909112516.854126-3-berrange@redhat.com> In-Reply-To: <20210909112516.854126-1-berrange@redhat.com> References: <20210909112516.854126-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1631186744436100001 The BIOS serial console output is currently implemented using the QEMU 'sga' device, but this is going to change in future patches, so the error message ought to be more generically phrased. Signed-off-by: Daniel P. Berrang=C3=A9 --- src/qemu/qemu_validate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index 3789361b57..47012748e8 100644 --- a/src/qemu/qemu_validate.c +++ b/src/qemu/qemu_validate.c @@ -1209,7 +1209,7 @@ qemuValidateDomainDef(const virDomainDef *def, } if (!def->nserials) { virReportError(VIR_ERR_XML_ERROR, "%s", - _("need at least one serial port to use SGA")); + _("need at least one serial port to use BIOS se= rial output")); return -1; } } --=20 2.31.1