From nobody Tue Feb 10 20:48:35 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1631158557616125.21764690058785; Wed, 8 Sep 2021 20:35:57 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-404-uAnwjnefOWmMV37DJ4R-qQ-1; Wed, 08 Sep 2021 23:35:55 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5A41B104ECFC; Thu, 9 Sep 2021 03:35:50 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 39FE460C81; Thu, 9 Sep 2021 03:35:50 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 08AC64EA38; Thu, 9 Sep 2021 03:35:50 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1893ZUSc003994 for ; Wed, 8 Sep 2021 23:35:30 -0400 Received: by smtp.corp.redhat.com (Postfix) id 0E7622095BA1; Thu, 9 Sep 2021 03:35:30 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast01.extmail.prod.ext.rdu2.redhat.com [10.11.55.17]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 062ED2095BB3 for ; Thu, 9 Sep 2021 03:35:26 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E12338934E2 for ; Thu, 9 Sep 2021 03:35:25 +0000 (UTC) Received: from corp-ob09.yahoo-corp.jp (corp-ob09.yahoo-corp.jp [182.22.125.216]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-559-JTvq0KnkOm2ZpENSOEpOzA-1; Wed, 08 Sep 2021 23:35:23 -0400 Received: from JPN01-TY1-obe.outbound.protection.outlook.com (mail-ty1jpn01lp2056.outbound.protection.outlook.com [104.47.93.56]) by corp-ob09.yahoo-corp.jp (Postfix) with ESMTPS id 4ED2919FB18D for ; Thu, 9 Sep 2021 12:35:21 +0900 (JST) Received: from TY2PR01MB2010.jpnprd01.prod.outlook.com (2603:1096:404:10::15) by TYAPR01MB2752.jpnprd01.prod.outlook.com (2603:1096:404:82::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14; Thu, 9 Sep 2021 03:35:20 +0000 Received: from TY2PR01MB2010.jpnprd01.prod.outlook.com ([fe80::cce2:1d9a:207c:c06c]) by TY2PR01MB2010.jpnprd01.prod.outlook.com ([fe80::cce2:1d9a:207c:c06c%5]) with mapi id 15.20.4478.025; Thu, 9 Sep 2021 03:35:20 +0000 Received: from R-SUR-LBA-2603.yahoo.co.jp (211.14.29.147) by TYCPR01CA0024.jpnprd01.prod.outlook.com (2603:1096:405::36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14 via Frontend Transport; Thu, 9 Sep 2021 03:35:20 +0000 X-MC-Unique: uAnwjnefOWmMV37DJ4R-qQ-1 X-MC-Unique: JTvq0KnkOm2ZpENSOEpOzA-1 From: Hiroki Narukawa To: libvir-list@redhat.com Subject: [PATCH 2/5] qemu: add disk queue count ABI stability check Date: Thu, 9 Sep 2021 12:34:45 +0900 Message-Id: <20210909033448.7018-3-hnarukaw@yahoo-corp.jp> In-Reply-To: <20210909033448.7018-1-hnarukaw@yahoo-corp.jp> References: <20210909033448.7018-1-hnarukaw@yahoo-corp.jp> X-ClientProxiedBy: TYCPR01CA0024.jpnprd01.prod.outlook.com (2603:1096:405::36) To TY2PR01MB2010.jpnprd01.prod.outlook.com (2603:1096:404:10::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d5e876b7-e19d-4c93-93e3-08d97342d9a0 X-MS-TrafficTypeDiagnostic: TYAPR01MB2752: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:260 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0 X-Microsoft-Antispam-Message-Info: l32eL7S9tJrG+2+jDkb4Uh0vxYLyFKCFgccojQF3YPsDvLdAOlPGlaPEEIPIX2hr5OEL39xU3GRjtyAi+97zW2OHMHtjeWTqGY3ljea8X7ygrGoVEIhvta4pkHgkUQ02Z2fIK10w5hxvpBWm/GudePigmexd2m92hjPdV5Z3YDs6VqBN/TO/6DKSeTcHzzBrYjnmmYmMGm8qIbsDl/Kq5DFdy0QQgNOWH2Zv4G1lbNo/MRIdNCjhx9K25tRq4T1BZCNs7t14MfZdMWNfGnVIbgUYHoo2AEuv2EYaUSmuVeTIPERx8iW0rRYbsRdrLYgUsfp6oqhgbx7jGTVT4P4q+3UOl5P98oKB6CNcSetVOdBjduk0ALSvtAzlOJuhs2bjOPjyXNZFOGgIKXEZ09OhHjtI8atLNPXjjF1c9/3e/TgbymuTKa+bd1iptP9OB6Q9ciq/zPLBeAtwLGZKwMwoJ0uMwELClEpz+gD7HwxGt7FQvOpI+1dK7V3N++i4QDoK33Ky1Lwr8AiTV2NoZ2G3Fk6ckmtbV4EjyeG65Hxy7ywe/BA7KRWVzpKZtPe2D27GSB+xMd7k66pFJqPS9A5VJ4dJuJZFUAqzQt0imEN2HsiC+LmfqhuAKZwbwPLCfZ7MpsEnDf6v3zWIhBiJNWP97HBWv6e0l6IpYqCQDKaU4dy2+XUjPZyYBaTy63ZX+wJSyCEPMy29LKpw75+swExoIg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TY2PR01MB2010.jpnprd01.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(136003)(346002)(366004)(39860400002)(396003)(107886003)(956004)(2906002)(2616005)(186003)(66556008)(66476007)(6506007)(26005)(52116002)(86362001)(6916009)(36756003)(8936002)(6666004)(4744005)(4326008)(38350700002)(38100700002)(8676002)(5660300002)(66946007)(316002)(6512007)(478600001)(6486002)(1076003); DIR:OUT; SFP:1102 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?9W9QGwXWmNOec+UtAxp/ZNPoGjbFacmJ6SSLftyjVqRrSMpvZm5N1fApSlAM?= =?us-ascii?Q?Z4PxPG5eJoZkOn0gvjXCkJbo3lSmuLiOJ1BHDDH+J06Kq/v2cOJGIy0YYmNk?= =?us-ascii?Q?JNa99JpZJrm39n5W2AveEi1ihziXoDJk3vUAZxlEg1V/BX3nLJt3/1pTu234?= =?us-ascii?Q?HMNb8ASXaUgYSKU23RFLE1ChzsJpCKqjx18TfuHuImAfyhdb6tvOuLyCP5UA?= =?us-ascii?Q?JTsfYTsi0jVSvS/Adn8qDTODYNhGNfE86YVHTtS3SpErcfe+7NzWoi1f9EMc?= =?us-ascii?Q?TGQFzkUH4cikGlOXthIRmqB4tRJzOki3ntXMgv3oEtQKZDc3z/dAMwjHaV/T?= =?us-ascii?Q?8R42z0KlpDMkvFr159z4MF6YOmXAl9KUzVaO2tYQt5ZI2hYGyQU4Is7YCkK5?= =?us-ascii?Q?RoK+of5pT9rq+ZVnRG6KKRYFXeug89lfRpzdTGHE1oWi5HsmN0LbFGDySvkl?= =?us-ascii?Q?OmbJxHo6m81ASyLCHtbbX9rPuu1HPDJnvZTYgzxXesbP7sscmwHiFbRX63Wg?= =?us-ascii?Q?oUAzQGLOzJTTTS0Yg3UwhQC7FO3CQwbLoh3dRCZDpq0wQ/4IjPvaPpXqTJLn?= =?us-ascii?Q?pwexOdT63n4haNmB6oWsx96KJ2nV/TLhqyJsrY1QsZlab807qF3s7WbhnHLD?= =?us-ascii?Q?Ptl8kzgBcCwN1m2WXOrpjgRRsHo2zRLRk+dj8O5e8/jCMeXLovCwCfN9ru+l?= =?us-ascii?Q?AL8A8pCMGdRfaGJDwckUnVjqPG5409Xvhvqw0ykZ/p3xh7efp3z5/qfspCO8?= =?us-ascii?Q?EXdGiVhXo7KmIuYaFyodsQ0g9WeD2wr3u4tXTT2b3VACwdQ/jjQwhT9flXvB?= =?us-ascii?Q?Z/oR0qSJZrO8eUPrbRg+yGmHB/Mv5SyScTmS9W7xpl3j8JuzMbJ0UnfVbbcT?= =?us-ascii?Q?2KKWBbdiVwI5VnFgHlaJrgjcAHxkSyFxe3xoWpC37tyml85jf/a5oKc2hbQ0?= =?us-ascii?Q?0sdQ5vsehja6NwbsYjUEmeegR5vHLl1qShQSvgrrTLCdlLmac/3+GsIFa9Kc?= =?us-ascii?Q?vJIpio2rd2Z6fbZ3zPER40lhyAg6mz1ie41K1P5pkkXlWuLxlbFEMgGR0hR6?= =?us-ascii?Q?cMPKteJ9Ob32E5ZYUQdpa6hVAK/vTKnDImSY6AVsXAT2rQCas/yMtJ+96ANb?= =?us-ascii?Q?ZIqjnWjYFG1EPBdNAMTahcqkg3aeWx01UEI/EbHhjm+ycct0kcKwq1XCDxMl?= =?us-ascii?Q?05wHXb32ikye0YrhCs+pc3WkEti32if+eeJVfsnpQm/UNw/RZGYNNtLb09OQ?= =?us-ascii?Q?LTTpQvna1wKANG7kPNFkULLr6CrOg1Nc9V+zpRP0SKPojB6lc4Aqf+XNfDD8?= =?us-ascii?Q?EPly6+oYK6AuabwesKChCbG1?= X-OriginatorOrg: yahoo-corp.jp X-MS-Exchange-CrossTenant-Network-Message-Id: d5e876b7-e19d-4c93-93e3-08d97342d9a0 X-MS-Exchange-CrossTenant-AuthSource: TY2PR01MB2010.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2021 03:35:20.7790 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a208d369-cd4e-4f87-b119-98eaf31df2c3 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 85i3ZVSFPdfl5rfadYQyctNPEcHs6qZ0pB5TUkbnQzatc0wAwFtUSkqJxtX23BO5eC6TnL3C6GtkUJsYFKMwyA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYAPR01MB2752 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: libvir-list@redhat.com Cc: aoiwa@yahoo-corp.jp, Hiroki Narukawa X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-ZM-MESSAGEID: 1631158558787100001 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" virtio-blk num-queue is visible to guest OS, so this must be kept while liv= e migration. Signed-off-by: Hiroki Narukawa Reviewed-by: Peter Krempa --- src/conf/domain_conf.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index dbefc98ee8..6cc1f78ec2 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -20766,6 +20766,13 @@ virDomainDiskDefCheckABIStability(virDomainDiskDef= *src, return false; } =20 + if (src->queues !=3D dst->queues) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("Target disk queue count %u does not match source= %u"), + dst->queues, src->queues); + return false; + } + if (!virDomainVirtioOptionsCheckABIStability(src->virtio, dst->virtio)) return false; =20 --=20 2.17.1