From nobody Fri May 3 03:15:52 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1630407871; cv=none; d=zohomail.com; s=zohoarc; b=ECFhSIOPrrv6NJM2L2v8B6cAJ75R6vsR3NM89Zc+WUd2CzVYkPRFevbj4HTJb7yKKbxSYnyU8+MRAmi+AE9kdg4P3Byb9OO2lGUf2xlKwphqxLKgRaNRUqmKRqvYQPQUINRN4sLVOx7J0+1K2/0GfA46qcHfZOaR0Y/hTrxG/3s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1630407871; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=qMKxi0uEoTyXZsy42PYqWNdq3DaGD4caIHN5LLUQNo4=; b=apxvtqU5zB1MlnFjphPrVECpDpYHOqQRLJ/l1XcjXbxedH8u+OBSbML2i8DEx6l38EYvv5M1byLt3u1s0wABEyl6PJGw6qTD3zvTxLzRLIPGnFHDd1jw5LyyVAGtYUhsFWL0ATBT+J/5PXIkNgzk8KetySwy+eijFINKovVJFvE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1630407871817713.2434441455856; Tue, 31 Aug 2021 04:04:31 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-207-Ap5W-5cpOXeia0WMR1bpxA-1; Tue, 31 Aug 2021 07:04:28 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C0E91106B393; Tue, 31 Aug 2021 11:04:23 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A3E9D60C9F; Tue, 31 Aug 2021 11:04:23 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 352F7181A3F1; Tue, 31 Aug 2021 11:04:23 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 17VB4LgN023804 for ; Tue, 31 Aug 2021 07:04:21 -0400 Received: by smtp.corp.redhat.com (Postfix) id 72D6E17B5B; Tue, 31 Aug 2021 11:04:21 +0000 (UTC) Received: from localhost.localdomain.com (unknown [10.39.195.79]) by smtp.corp.redhat.com (Postfix) with ESMTP id 603745DF26; Tue, 31 Aug 2021 11:04:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1630407870; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=qMKxi0uEoTyXZsy42PYqWNdq3DaGD4caIHN5LLUQNo4=; b=hNClgEgmSOm/j5KNYb5AR+6pR2ezRRChw0NqSwCoClkn4bw10cdsR/+33Bnfk9zp2Nrr0e 5ocd1tmDGvzlj72xSiww5pb9wi3/GXmhH6tHj8k9w4d7LCz3qcjq/QMFMGI3i3i57t0/6Y t2PU0Qi25j5pv7NpfjQpPnNHadIkZZg= X-MC-Unique: Ap5W-5cpOXeia0WMR1bpxA-1 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: libvir-list@redhat.com Subject: [libvirt PATCH] qemu, xen: add missing deps on virtlockd/virtlogd sockets Date: Tue, 31 Aug 2021 12:04:14 +0100 Message-Id: <20210831110414.117335-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1630407873541100001 The QEMU driver uses both virtlogd and virtlockd, while the Xen driver uses virtlockd. The libvirtd.service unit contains deps on the socket units for these services, but these deps were missed in the modular daemons. As a result the virtlockd/virtlogd sockets are not started when the virtqemud/virtxend daemons are started. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Jiri Denemark --- src/libxl/virtxend.service.in | 2 ++ src/qemu/virtqemud.service.in | 4 ++++ 2 files changed, 6 insertions(+) diff --git a/src/libxl/virtxend.service.in b/src/libxl/virtxend.service.in index a863917467..19b19ce3e6 100644 --- a/src/libxl/virtxend.service.in +++ b/src/libxl/virtxend.service.in @@ -1,6 +1,7 @@ [Unit] Description=3DVirtualization xen daemon Conflicts=3Dlibvirtd.service +Requires=3Dvirtlockd.socket Requires=3Dvirtxend.socket Requires=3Dvirtxend-ro.socket Requires=3Dvirtxend-admin.socket @@ -25,6 +26,7 @@ KillMode=3Dprocess =20 [Install] WantedBy=3Dmulti-user.target +Also=3Dvirtlockd.socket Also=3Dvirtxend.socket Also=3Dvirtxend-ro.socket Also=3Dvirtxend-admin.socket diff --git a/src/qemu/virtqemud.service.in b/src/qemu/virtqemud.service.in index 8abc9d3a7f..20e1b43a6e 100644 --- a/src/qemu/virtqemud.service.in +++ b/src/qemu/virtqemud.service.in @@ -1,6 +1,8 @@ [Unit] Description=3DVirtualization qemu daemon Conflicts=3Dlibvirtd.service +Requires=3Dvirtlogd.socket +Requires=3Dvirtlockd.socket Requires=3Dvirtqemud.socket Requires=3Dvirtqemud-ro.socket Requires=3Dvirtqemud-admin.socket @@ -42,6 +44,8 @@ LimitMEMLOCK=3D64M =20 [Install] WantedBy=3Dmulti-user.target +Also=3Dvirtlogd.socket +Also=3Dvirtlockd.socket Also=3Dvirtqemud.socket Also=3Dvirtqemud-ro.socket Also=3Dvirtqemud-admin.socket --=20 2.31.1