From nobody Tue Feb 10 03:45:34 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1629895516; cv=none; d=zohomail.com; s=zohoarc; b=P8a3x+6sCRtPahqDux+TZzF7AzE0rnF2+4oMpyRkX6K0rJnsHSynxzi38QTYRlPN9TbG3A78RleM2BdY2AZFvJPejFGDXCyNnJ23cIEqvIhKxX0ERAGqazt+KEojMXtzU689ITYV7+t5Y7Y0LoWy7w65foiU/ZJZrHFnjk3WTMU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1629895516; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=EX21yDvDdisVXa29Wuh2+RR4O3wKOlPb/Q91Zyip1cY=; b=DZq+4Q58jNzdHAZaYmDaMurO7YmBdKu7d92Nn/l3peGBRsrxV2EvTK1XGOFJvWJdUlxuLR4EdLdUr6X1lceqoprnBYHGQpq1xYN4cNoycDS2VTHNQ9U9obYdDAI02tWailm21yR6ivvDXY2qJYHU0vNQyk3eod4jNTi/Gvuq4Y8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1629895516343110.53688102518538; Wed, 25 Aug 2021 05:45:16 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-374-hSw5RVEANKCf0MyknTqIyQ-1; Wed, 25 Aug 2021 08:44:06 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 57594108292F; Wed, 25 Aug 2021 12:44:01 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3634E1036D15; Wed, 25 Aug 2021 12:44:01 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id E56731821896; Wed, 25 Aug 2021 12:44:00 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 17PChwoG013678 for ; Wed, 25 Aug 2021 08:43:58 -0400 Received: by smtp.corp.redhat.com (Postfix) id 916D25D741; Wed, 25 Aug 2021 12:43:58 +0000 (UTC) Received: from work.redhat.com (unknown [10.39.192.26]) by smtp.corp.redhat.com (Postfix) with ESMTP id 87D6869320; Wed, 25 Aug 2021 12:43:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1629895515; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=EX21yDvDdisVXa29Wuh2+RR4O3wKOlPb/Q91Zyip1cY=; b=CX6/1UAaxZvNCQD/4u9KOQRmRWx3jYl4aXjbW2M/aj5DTtjjK8v7WHTb/BaAObGklqudGH uK7eopruqAByELORhr+hqLDj31irIPjCOUMM0THlrsrrxNI0+fNBMd36mZr1dKabEyoQtV D4iiDGHtrDN4F9IDIt2BqPh7ElXX1Es= X-MC-Unique: hSw5RVEANKCf0MyknTqIyQ-1 From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH 08/11] virChrdevFree: Use virLockGuard Date: Wed, 25 Aug 2021 14:43:27 +0200 Message-Id: <20210825124330.84282-9-twiederh@redhat.com> In-Reply-To: <20210825124330.84282-1-twiederh@redhat.com> References: <20210825124330.84282-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Cc: Tim Wiederhake X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1629895518448100001 Content-Type: text/plain; charset="utf-8" Signed-off-by: Tim Wiederhake --- src/conf/virchrdev.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/conf/virchrdev.c b/src/conf/virchrdev.c index 8ca1c1062c..a95b8976ac 100644 --- a/src/conf/virchrdev.c +++ b/src/conf/virchrdev.c @@ -291,10 +291,10 @@ void virChrdevFree(virChrdevs *devs) if (!devs) return; =20 - virMutexLock(&devs->lock); - virHashForEachSafe(devs->hash, virChrdevFreeClearCallbacks, NULL); - virHashFree(devs->hash); - virMutexUnlock(&devs->lock); + WITH_VIR_MUTEX_LOCK_GUARD(&devs->lock) { + virHashForEachSafe(devs->hash, virChrdevFreeClearCallbacks, NULL); + virHashFree(devs->hash); + } virMutexDestroy(&devs->lock); =20 g_free(devs); --=20 2.31.1