From nobody Fri May 3 21:40:04 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=nutanix.com Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1629448846969221.5566953213912; Fri, 20 Aug 2021 01:40:46 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-263-znS0t4QBOg-eJquOrIIh7g-1; Fri, 20 Aug 2021 04:40:41 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C3A7E8799E0; Fri, 20 Aug 2021 08:40:36 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A9AE0369A; Fri, 20 Aug 2021 08:40:36 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 76DA34A7C9; Fri, 20 Aug 2021 08:40:36 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 17K8eYan023751 for ; Fri, 20 Aug 2021 04:40:35 -0400 Received: by smtp.corp.redhat.com (Postfix) id D99A510FAD5; Fri, 20 Aug 2021 08:40:34 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast06.extmail.prod.ext.rdu2.redhat.com [10.11.55.22]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D33E1103CD9 for ; Fri, 20 Aug 2021 08:40:26 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BDC05185A794 for ; Fri, 20 Aug 2021 08:40:26 +0000 (UTC) Received: from mx0a-002c1b01.pphosted.com (mx0a-002c1b01.pphosted.com [148.163.151.68]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-176-Zfb79Dh1PEaGfZHPRnIGgw-1; Fri, 20 Aug 2021 04:40:24 -0400 Received: from pps.filterd (m0127838.ppops.net [127.0.0.1]) by mx0a-002c1b01.pphosted.com (8.16.1.2/8.16.0.43) with SMTP id 17K8RTEA011304 for ; Fri, 20 Aug 2021 01:40:23 -0700 Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2172.outbound.protection.outlook.com [104.47.59.172]) by mx0a-002c1b01.pphosted.com with ESMTP id 3ahtbybvam-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 20 Aug 2021 01:40:22 -0700 Received: from BN8PR02MB6433.namprd02.prod.outlook.com (2603:10b6:408:ad::10) by BN6PR02MB3186.namprd02.prod.outlook.com (2603:10b6:405:67::39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.22; Fri, 20 Aug 2021 08:40:21 +0000 Received: from BN8PR02MB6433.namprd02.prod.outlook.com ([fe80::bdb2:16e:e432:a7b0]) by BN8PR02MB6433.namprd02.prod.outlook.com ([fe80::bdb2:16e:e432:a7b0%5]) with mapi id 15.20.4415.024; Fri, 20 Aug 2021 08:40:21 +0000 Received: from simon-rowe.ubvm.nutanix.com (192.146.154.247) by SJ0PR03CA0290.namprd03.prod.outlook.com (2603:10b6:a03:39e::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4436.19 via Frontend Transport; Fri, 20 Aug 2021 08:40:20 +0000 X-MC-Unique: znS0t4QBOg-eJquOrIIh7g-1 X-MC-Unique: Zfb79Dh1PEaGfZHPRnIGgw-1 From: Simon Rowe To: libvir-list@redhat.com Subject: [PATCH 1/2] iohelper: skip lseek() and ftruncate() on block devices Date: Fri, 20 Aug 2021 08:39:55 +0000 Message-Id: <20210820083956.40395-2-simon.rowe@nutanix.com> In-Reply-To: <20210820083956.40395-1-simon.rowe@nutanix.com> References: <20210820083956.40395-1-simon.rowe@nutanix.com> X-ClientProxiedBy: SJ0PR03CA0290.namprd03.prod.outlook.com (2603:10b6:a03:39e::25) To BN8PR02MB6433.namprd02.prod.outlook.com (2603:10b6:408:ad::10) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6e4c9c55-f668-4efb-047a-08d963b62563 X-MS-TrafficTypeDiagnostic: BN6PR02MB3186: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: x-proofpoint-crosstenant: true X-MS-Oob-TLC-OOBClassifiers: OLM:655 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0 X-Microsoft-Antispam-Message-Info: /WNtcb2kq9/CKtiwdzyR5PyvLLiX5pDDnFf13kDloNlzKEY6XJHLnyLn7WAMu4mYc6iTldziM9SRYGk257Y1diQEdY7KLkL8bmcRy0y5R0PukRwx1lnoTcxEACRWZVAosdtuIulE1zjm09mB6WgNyCLRtTOz5QwaQNM5w6aKYZrxL/SHDisfl7+7dywmsYYynNQRrBKvheFhTPW2/34Ga0C59XexArO8OCbCcVMx+D6zOwMSiKTxqDt2eJ6KH3atGuJ7I7OdyW5BcYKc511cxyoK/fXAA/qn0PzDtmcFJ4tiB67PQbL+fhoqCthQojuAbp2DhKYJWYAHjOctWQXnF1QyzkFR8N+zQmYl6AD3cOue/v42eSwuxoVTwl9F3ssfp7KNPIQNHpEh//ZkaQRyURC/GY6uipHpRPFoQDv/VZ2qrqcO00+n0p3eJq6fzFp5lktlOv3CswU0+MEExXgQGrIrSTToBTW5sPGcZEQWwqJUOW2aIHOAXXMw0gFfApf4VK9OoX3DETfgdH+9ffS/NgeaV86i1bt5ohecpYTafqYaBg7+VW/cafCFQwmmE5031ie4Q+dQ1n+RAUgZhsAswkrosVYJK3CPTlkM5Y08i5E8L0FO7vNobb0sOiJwRCk7dGzSz3iociWed9xO/FuEeYwqofXLtxmxUMbngAjNBNciAVIu0EMy+0PHksSzlZ8OxmiG59FiMxCo0fwvkRfFDA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN8PR02MB6433.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(66946007)(44832011)(2616005)(6916009)(1076003)(66476007)(26005)(86362001)(38350700002)(107886003)(956004)(38100700002)(186003)(508600001)(5660300002)(4326008)(66556008)(6486002)(316002)(6666004)(36756003)(8936002)(7696005)(83380400001)(8676002)(52116002)(2906002); DIR:OUT; SFP:1102 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?J96PxJ7vxSOa4rJ9y8NDxAMmQ+1LXKFHKILT37ENZ6KIxf3aVYQ3YNTYGhyD?= =?us-ascii?Q?6V2LfBRR7mCjc0vu3r1m8PkErd2X+CyqnHhJB1zpy9EDjkY1TLEpqCxF+/e0?= =?us-ascii?Q?ui3apaA6TGKa3TT4+Ttl110z2DTvvv7rTwoHnwpXvpnq3knG0zAARch3NVaM?= =?us-ascii?Q?/e2hvdwoAzT/VQzFnX57AP3PoeEt4kNA/x43ZhvJDqe4GJAKwN2B6Deu8cPh?= =?us-ascii?Q?e61hIJE6Z03QHoOiwHRJGAZINHOXjZHM0Mlmou6xieyHD5eErzQf3SOLQTJ4?= =?us-ascii?Q?fmZClSdzaHET2z9QCT5BAO0ZZeRGw63hwskRombIVG7v80jjwbOKjCN0Z1pw?= =?us-ascii?Q?sa7p9VFX1XEr/9bnD7/NXXIjfLlU1/X0TvXfTgEuOsWaOlfX1JiNnD8KVjQC?= =?us-ascii?Q?x0MStwe6bA13aMHxbP3iqjcemrVXUMFDm64KIA5iGStnaNE4kBWnmnXw8BUv?= =?us-ascii?Q?cMWjb0x/unvFDxn2gGJXe8gRNRUExU+dbjwYCBlUvFUeKXntI7FExoohspIw?= =?us-ascii?Q?wFpKSxrN3TB7fAyg1osKPkf0zk8tDTQ5td2ci35ERigy3h93EdYPBExGTkyv?= =?us-ascii?Q?V5FfXF4E7B4+Fa/OG0UIs2nnMDMwQsn9FbJHqrLaJWVZ1NvCxCSMOWcJzpLw?= =?us-ascii?Q?8gCFM+j2NXjUXOiOMLGW5GxVii2zLurNoLEWQL49GoZYikl6IYYRYo/D2eDp?= =?us-ascii?Q?q654Wxda9RtySyon/oogy1LKKB2teYwvs3Avbe0qUyk6CfldRwc1/+J/p/+P?= =?us-ascii?Q?6q3pG25XpIw7Q+EL1t4SXw5yXnBzx1qoRFOncJsjgd9zP6IzPbtOVeO6TRRR?= =?us-ascii?Q?HZAyFll1QsanL+tuQ7+IUshiFE0uXlji68r4PK6Fzje1zUM0/GkXUYhhLPA1?= =?us-ascii?Q?Ry2eB4FeMjM/DS3Ypycm+wQAH02i1lB4G4M9QqRdyeOpWHpdKARFXq2JQ3fp?= =?us-ascii?Q?WpEeZi3dMdehF6zRALvJo/RU0WymD6FzzYi2Pt+VqrooTqrOjZJd0tCrcIap?= =?us-ascii?Q?x10CRzAzphk0GFbuXuFlHLsdLNsWc1YcDKO4SyPCu5+UqHHZciNYnrWIy/Ph?= =?us-ascii?Q?riJE8xqWOKEm3St6zWPAfwPGpOKREZSrXo6G+hYVkjtjOybRfzJOPJQrVTUh?= =?us-ascii?Q?2LaoSYADY2rev/1QqPFaocopY34vmm8DIswMJWYgXDtEwDSiEjlXqQmxHSNe?= =?us-ascii?Q?NKjreCJZ8Fjv99N/kz5gArEeiULQIoGOm4VcVrYBjLWDPQ5/qzQ7a3NECIz2?= =?us-ascii?Q?lpXxCWun98lFxZGUOv6M71j4q9Xd/d4q1Nl8J6qaeeNGaCiRVJQAV/m+ZmyX?= =?us-ascii?Q?gGeKZZqGbZs2QAiJ4JFO8cXc?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6e4c9c55-f668-4efb-047a-08d963b62563 X-MS-Exchange-CrossTenant-AuthSource: BN8PR02MB6433.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Aug 2021 08:40:21.3099 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: O3px+xPE6o7hM0RnZ3z76LerBbINwajcw6m3BjIDlWF9IQLtmy0k1tkpOXAf2f2EUyMJzDlYXNpWYuPmKIilGw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR02MB3186 X-Proofpoint-ORIG-GUID: zwkBiee3ehXAtnlNwoWoIo_1YY9RPous X-Proofpoint-GUID: zwkBiee3ehXAtnlNwoWoIo_1YY9RPous X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1, Aquarius:18.0.790, Hydra:6.0.391, FMLib:17.0.607.475 definitions=2021-08-20_02,2021-08-20_03,2020-04-07_01 X-Proofpoint-Spam-Reason: safe X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-loop: libvir-list@redhat.com Cc: Simon Rowe X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1629448848034100003 Content-Type: text/plain; charset="utf-8" Signed-off-by: Simon Rowe --- src/util/iohelper.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/util/iohelper.c b/src/util/iohelper.c index b8810d16d3..e6eb178fde 100644 --- a/src/util/iohelper.c +++ b/src/util/iohelper.c @@ -28,6 +28,8 @@ #include #include #include +#include +#include =20 #include "virthread.h" #include "virfile.h" @@ -56,6 +58,8 @@ runIO(const char *path, int fd, int oflags) unsigned long long total =3D 0; bool direct =3D O_DIRECT && ((oflags & O_DIRECT) !=3D 0); off_t end =3D 0; + struct stat sb; + bool isBlockDev =3D false; =20 #if WITH_POSIX_MEMALIGN if (posix_memalign(&base, alignMask + 1, buflen)) @@ -86,9 +90,11 @@ runIO(const char *path, int fd, int oflags) fdinname =3D "stdin"; fdout =3D fd; fdoutname =3D path; + if (fstat(fd, &sb) =3D=3D 0) + isBlockDev =3D S_ISBLK(sb.st_mode); /* To make the implementation simpler, we give up on any * attempt to use O_DIRECT in a non-trivial manner. */ - if (direct && (end =3D lseek(fd, 0, SEEK_END)) !=3D 0) { + if (!isBlockDev && direct && (end =3D lseek(fd, 0, SEEK_END)) !=3D= 0) { virReportSystemError(end < 0 ? errno : EINVAL, "%s", _("O_DIRECT write needs empty seekable fi= le")); goto cleanup; @@ -140,7 +146,7 @@ runIO(const char *path, int fd, int oflags) goto cleanup; } =20 - if (ftruncate(fd, total) < 0) { + if (!isBlockDev && ftruncate(fd, total) < 0) { virReportSystemError(errno, _("Unable to truncate %s"), fd= outname); goto cleanup; } --=20 2.22.3 From nobody Fri May 3 21:40:04 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=nutanix.com Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1629448845093674.4176983153135; Fri, 20 Aug 2021 01:40:45 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-115-D4h5TAX3Pk-FtOkyXNKx3A-1; Fri, 20 Aug 2021 04:40:41 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 38E601934107; Fri, 20 Aug 2021 08:40:36 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EC99AE2D5; Fri, 20 Aug 2021 08:40:35 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id C60C84BB7C; Fri, 20 Aug 2021 08:40:34 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 17K8eX05023740 for ; Fri, 20 Aug 2021 04:40:33 -0400 Received: by smtp.corp.redhat.com (Postfix) id 1CA6510FADA; Fri, 20 Aug 2021 08:40:33 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast06.extmail.prod.ext.rdu2.redhat.com [10.11.55.22]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 167CC103CD9 for ; Fri, 20 Aug 2021 08:40:33 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id F357818A01AC for ; Fri, 20 Aug 2021 08:40:32 +0000 (UTC) Received: from mx0b-002c1b01.pphosted.com (mx0b-002c1b01.pphosted.com [148.163.155.12]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-419-NlLMS7m7NjqRsm7Tw2rHfA-1; Fri, 20 Aug 2021 04:40:30 -0400 Received: from pps.filterd (m0127842.ppops.net [127.0.0.1]) by mx0b-002c1b01.pphosted.com (8.16.1.2/8.16.0.43) with SMTP id 17K8eMwf029978 for ; Fri, 20 Aug 2021 01:40:30 -0700 Received: from nam02-sn1-obe.outbound.protection.outlook.com (mail-sn1anam02lp2047.outbound.protection.outlook.com [104.47.57.47]) by mx0b-002c1b01.pphosted.com with ESMTP id 3aj7rhrb9g-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 20 Aug 2021 01:40:29 -0700 Received: from BN8PR02MB6433.namprd02.prod.outlook.com (2603:10b6:408:ad::10) by BN6PR02MB3186.namprd02.prod.outlook.com (2603:10b6:405:67::39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.22; Fri, 20 Aug 2021 08:40:27 +0000 Received: from BN8PR02MB6433.namprd02.prod.outlook.com ([fe80::bdb2:16e:e432:a7b0]) by BN8PR02MB6433.namprd02.prod.outlook.com ([fe80::bdb2:16e:e432:a7b0%5]) with mapi id 15.20.4415.024; Fri, 20 Aug 2021 08:40:27 +0000 Received: from simon-rowe.ubvm.nutanix.com (192.146.154.247) by SJ0PR03CA0290.namprd03.prod.outlook.com (2603:10b6:a03:39e::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4436.19 via Frontend Transport; Fri, 20 Aug 2021 08:40:26 +0000 X-MC-Unique: D4h5TAX3Pk-FtOkyXNKx3A-1 X-MC-Unique: NlLMS7m7NjqRsm7Tw2rHfA-1 From: Simon Rowe To: libvir-list@redhat.com Subject: [PATCH 2/2] qemu: never unlink() the core dump output file Date: Fri, 20 Aug 2021 08:39:56 +0000 Message-Id: <20210820083956.40395-3-simon.rowe@nutanix.com> In-Reply-To: <20210820083956.40395-1-simon.rowe@nutanix.com> References: <20210820083956.40395-1-simon.rowe@nutanix.com> X-ClientProxiedBy: SJ0PR03CA0290.namprd03.prod.outlook.com (2603:10b6:a03:39e::25) To BN8PR02MB6433.namprd02.prod.outlook.com (2603:10b6:408:ad::10) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4bdbc12e-4944-4bed-295d-08d963b628b2 X-MS-TrafficTypeDiagnostic: BN6PR02MB3186: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: x-proofpoint-crosstenant: true X-MS-Oob-TLC-OOBClassifiers: OLM:612 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0 X-Microsoft-Antispam-Message-Info: yxACmdb8qCctDii0Fzxf16REybCf4rPaqpAXdlAGPXrKCHw3augx8cUYO2OE+M0EVwRy/GkPY/ZH6cX+3p1wkhTwtM1/YMsY5f5+bYzas7sDgOcW7NiFJAbKa5TenvK/zmmRc61iPdLvw2MO7xpR45LBPC5OJrJY1hg8EMm0LJ9/Qv56IsyRaagFp5KEN6MdBkdartvkl1ngE4Yh/yWvvVolvgwgHIPmOsXo8vg6OkLTbPFCb/nt3ysCFZVMvbQyeNjm46qlUYuo6bA0lUtWl5hgHzKTuFuusj9t5LkLF+ext/f3Pukuld5w6AzpVzi45dgtmTWCENfRTOcPX7WhKGVs7oG0NwpK202io8oJ3/SAbLj0ro+EQx/B/e4QhmUtI5Y37wxhAWBDfOSDVCOqDiI8O8I0pl/W9P4d/7ohXejIM8/pWwtvjp/k7HVkaCkOST0wtOt/bem3umM7l5smTfhpJRaq79cXw03vQJrJ7Wv+ae1s5Pe7OMZsEEE/9EyWoJzlu2tx7pdYmFGlIomJcXnY8Cfb1X76cJgdGSYm5j/EdAeE49vfDzcRXy31ju5H8wUuyhJUDB5KTS5IvNHpsVnRdylJdzl3oufaXNVoR6RWAavyfmKBzaNNl/IhxEBBFBlArpMpbpBFFRSbJDgRO5FkE5TOgQ4fSPC25lhi3zJt6sYS5PqNJnTzvZPhxhihB8LGLEotAt4wZ2CmPvhRjw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN8PR02MB6433.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(66946007)(44832011)(2616005)(6916009)(1076003)(66476007)(26005)(86362001)(38350700002)(107886003)(956004)(38100700002)(4744005)(186003)(508600001)(5660300002)(4326008)(66556008)(6486002)(316002)(6666004)(36756003)(8936002)(7696005)(83380400001)(8676002)(52116002)(2906002); DIR:OUT; SFP:1102 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?C7Oy3zjwtJcPzKCaTYnvDtTwflZDGgCIu9dyuQfsQithTq5rdmYnnqxUNvyf?= =?us-ascii?Q?ASapbCz/kWs8qXDLSQFR7mUyupRsAhVxtl3hsDj5lDnFu2FkQxCEo4XaAB8E?= =?us-ascii?Q?MPDBc12Xq540f30rBLFM6K9zKGCIw0GwhKjlP/d9UP3dtUTIs1LUMuq6K8Sm?= =?us-ascii?Q?/AOCztdIjby4ZzuaCS1tEefMm8DI2yoTMHb67FaLRLtnPYw8zlO011R8aTtI?= =?us-ascii?Q?rUijMWRHJ/61J/H0xb67BP/8xlKK88r6aGgb1rsjHNG+atfQAB931EGrHXkg?= =?us-ascii?Q?6XY/g4YP1Spk+JZxeDTVxEFDiWKa+0m24SP3PRXKDjOgR9W6JiQFClHWZJF7?= =?us-ascii?Q?NwA/fvZhyoAkvSesWDB3bfYPWLUwNEHM0gdanmtlFfkp0M215b8TXOhji+3F?= =?us-ascii?Q?G+oC++i9QHG2Alv2Ujt8YGPLCYmlJtCpZXyacFTPgLz1O4ufLnDlef+WvVn8?= =?us-ascii?Q?3Ek753t5Dj/xWq0STi70tXm15aCCVp5TBTNmYVqr3DA/CaG4sRiO3dcS04il?= =?us-ascii?Q?n0KQkzJ2xAtO0by3+m+/65SdNZFi8ejnVu0F1guBTlVDU8PW315Ig4wEIluO?= =?us-ascii?Q?a/3YHUEGDF1vpgOBKIrKEL+fanN3vgkN4XrfkaGDh8HSFFeeqSrDyUHNw/Fy?= =?us-ascii?Q?vDPT8jOphEBSBKPFT/U/ORw1XXwf1zl8OmILGka+KQmrZ5SzM8fu+j2OLaI7?= =?us-ascii?Q?m+EjDCuwbtnfKRFY+Ij9B0Mp0z+81hqGbnEhPtdikgMzcUU2YEtwnU0ZWVNK?= =?us-ascii?Q?ZZR7L0tlGREmheCXcvpIQZETSAIUYj8Cew5Gh+ymrtc54ZIeAJAx6n4tGu2h?= =?us-ascii?Q?GGuLZnDCJEDDb5Ba5nG3gO1vUdreHNVVkO+7TRn+1Od8LqMoZcAnVwmfqpTc?= =?us-ascii?Q?FqWXT+MDEhHEcSi7vmIw0TjBiHuDJ4/0catSIEu0ThFqnr53i7PRq23ZelyS?= =?us-ascii?Q?5HQtcLdGuDkPfVbV+zcGB2Gy+7SGJNoMuCmFUBYwjPfQE7p31KQK0fIxSD5z?= =?us-ascii?Q?ZLDquonMHYvBKiHaKC09fOR9RX5qEUpYze9FYlXCQICxmlKcwWZbSP+Hthr1?= =?us-ascii?Q?XxevTu+ZVZKm+Np/TpvVl8W967BGCIZe1UipaUh4KAzmXcRsODlkxaWPeThG?= =?us-ascii?Q?GbHRGkl81cFCApyMN1iz1kWilvcCC38BWhb9UTMNLlt8PPAdeZk0NSnL281P?= =?us-ascii?Q?1Cua8WgqOrtUPOD/Bx265DKerJEJRR26lWXdnU5vZ5t3GPU2OIt30UW/BPFQ?= =?us-ascii?Q?ekRAhMkXRHgcKhAavTXyKAmcvBmUZArmhGGcmkSrjUyUSEREnq+8WNYLJxpw?= =?us-ascii?Q?oWtmsnrwwQVag5PtA6XhSAVX?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4bdbc12e-4944-4bed-295d-08d963b628b2 X-MS-Exchange-CrossTenant-AuthSource: BN8PR02MB6433.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Aug 2021 08:40:26.9517 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AS1+eyGiENgG1Z9vqNFN1VgYJA3cK+LsqyIPOxbz2PJs188Ye+GzpCMOrXEGQcgCyvZvFjd8GSbyxZPUMGpXXg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR02MB3186 X-Proofpoint-GUID: IKFz3WA8vtdxCm3DFuC_gdL6FBrYAnnn X-Proofpoint-ORIG-GUID: IKFz3WA8vtdxCm3DFuC_gdL6FBrYAnnn X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1, Aquarius:18.0.790, Hydra:6.0.391, FMLib:17.0.607.475 definitions=2021-08-20_02,2021-08-20_03,2020-04-07_01 X-Proofpoint-Spam-Reason: safe X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-loop: libvir-list@redhat.com Cc: Simon Rowe X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1629448845974100001 Content-Type: text/plain; charset="utf-8" The comment above virQEMUFileOpenAs() implies any result should be left intact. Signed-off-by: Simon Rowe --- src/qemu/qemu_driver.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index f31e13889e..b1ac1cb73b 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -3282,8 +3282,6 @@ doCoreDump(virQEMUDriver *driver, if (qemuDomainFileWrapperFDClose(vm, wrapperFd) < 0) ret =3D -1; virFileWrapperFdFree(wrapperFd); - if (ret !=3D 0) - unlink(path); return ret; } =20 --=20 2.22.3