[PATCH v2] domain_conf: Fix memory leak when free'ing virDomainObj

Luke Yue posted 1 patch 2 years, 7 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20210810134721.106715-1-lukedyue@gmail.com
src/conf/domain_conf.c | 11 +++++++++++
1 file changed, 11 insertions(+)
[PATCH v2] domain_conf: Fix memory leak when free'ing virDomainObj
Posted by Luke Yue 2 years, 7 months ago
Free dom->deprecations when free'ing virDomainObj

Signed-off-by: Luke Yue <lukedyue@gmail.com>
---
 src/conf/domain_conf.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 09da4ab952..7e1d30bdb2 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -3730,6 +3730,16 @@ void virDomainDefFree(virDomainDef *def)
     g_free(def);
 }
 
+static void
+virDomainObjDeprecationFree(virDomainObj *dom)
+{
+    size_t i = 0;
+    for (i = 0; i < dom->ndeprecations; i++) {
+        g_free(dom->deprecations[i]);
+    }
+    g_free(dom->deprecations);
+}
+
 static void virDomainObjDispose(void *obj)
 {
     virDomainObj *dom = obj;
@@ -3742,6 +3752,7 @@ static void virDomainObjDispose(void *obj)
     if (dom->privateDataFreeFunc)
         (dom->privateDataFreeFunc)(dom->privateData);
 
+    virDomainObjDeprecationFree(dom);
     virDomainSnapshotObjListFree(dom->snapshots);
     virDomainCheckpointObjListFree(dom->checkpoints);
 }
-- 
2.32.0

Re: [PATCH v2] domain_conf: Fix memory leak when free'ing virDomainObj
Posted by Pavel Hrdina 2 years, 7 months ago
On Tue, Aug 10, 2021 at 09:47:21PM +0800, Luke Yue wrote:
> Free dom->deprecations when free'ing virDomainObj
> 
> Signed-off-by: Luke Yue <lukedyue@gmail.com>
> ---
>  src/conf/domain_conf.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)

Reviewed-by: Pavel Hrdina <phrdina@redhat.com>