[PATCH] rpm: fix mingw obsoletes lines

Daniel P. Berrangé posted 1 patch 2 years, 7 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20210802105324.3273084-1-berrange@redhat.com
mingw-libvirt.spec.in | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[PATCH] rpm: fix mingw obsoletes lines
Posted by Daniel P. Berrangé 2 years, 7 months ago
The package is mistakenly obsoleting itself, when it should be
obsoleting the -static packages we dropped.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 mingw-libvirt.spec.in | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/mingw-libvirt.spec.in b/mingw-libvirt.spec.in
index bcc2bd93e3..dbcb6d4b8f 100644
--- a/mingw-libvirt.spec.in
+++ b/mingw-libvirt.spec.in
@@ -69,7 +69,7 @@ MinGW Windows libvirt virtualization library.
 # Mingw32
 %package -n mingw32-libvirt
 Summary: %{summary}
-Obsoletes: mingw32-libvirt < 7.0.0
+Obsoletes: mingw32-libvirt-static < 7.0.0
 
 %description -n mingw32-libvirt
 MinGW Windows libvirt virtualization library.
@@ -77,7 +77,7 @@ MinGW Windows libvirt virtualization library.
 # Mingw64
 %package -n mingw64-libvirt
 Summary: %{summary}
-Obsoletes: mingw64-libvirt < 7.0.0
+Obsoletes: mingw64-libvirt-static < 7.0.0
 
 %description -n mingw64-libvirt
 MinGW Windows libvirt virtualization library.
-- 
2.31.1

Re: [PATCH] rpm: fix mingw obsoletes lines
Posted by Michal Prívozník 2 years, 7 months ago
On 8/2/21 12:53 PM, Daniel P. Berrangé wrote:
> The package is mistakenly obsoleting itself, when it should be
> obsoleting the -static packages we dropped.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>  mingw-libvirt.spec.in | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/mingw-libvirt.spec.in b/mingw-libvirt.spec.in
> index bcc2bd93e3..dbcb6d4b8f 100644
> --- a/mingw-libvirt.spec.in
> +++ b/mingw-libvirt.spec.in
> @@ -69,7 +69,7 @@ MinGW Windows libvirt virtualization library.
>  # Mingw32
>  %package -n mingw32-libvirt
>  Summary: %{summary}
> -Obsoletes: mingw32-libvirt < 7.0.0
> +Obsoletes: mingw32-libvirt-static < 7.0.0
>  
>  %description -n mingw32-libvirt
>  MinGW Windows libvirt virtualization library.
> @@ -77,7 +77,7 @@ MinGW Windows libvirt virtualization library.
>  # Mingw64
>  %package -n mingw64-libvirt
>  Summary: %{summary}
> -Obsoletes: mingw64-libvirt < 7.0.0
> +Obsoletes: mingw64-libvirt-static < 7.0.0
>  
>  %description -n mingw64-libvirt
>  MinGW Windows libvirt virtualization library.
> 

LOL

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal