From nobody Sat Feb 7 06:20:31 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1627056384; cv=none; d=zohomail.com; s=zohoarc; b=hALUaOFUZgVbCTolb6RmyS3dCm3aTJZ86rGtOFnqh9P53TF+SqjDxb1LREti8+qtlKuK9qXmQD6bZUtpn9PkVtq5kBS/+4X4+01LciOK0vZjrH5gE7DLQ8jxHVaGD4JoeUnIroRIRFfvlGy/7NeuKOg/4jvZpEBOjXdrokiOahE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1627056384; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=bBm6AzdFC6HKWqJZBYdI3Yqk0/lNPkWl9JOOirepRH8=; b=eW6hx4/Z+fYIhvo79JpGcOZJd71sGWnJz9b/3Lhm5cOCTXUEdULiNdAUXL5Oi3h5BPCD+47Z5DaXWKg49f8pahA8f99fQqZKupR0ocNA9Hhy6FqRb5wtlYa0LGFBvUTLzGILiaePLDFZ4uP0kHDT8+37SriU+kb5GH0Kqwk6ytY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1627056384684923.1213917680838; Fri, 23 Jul 2021 09:06:24 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-413-ouaNNlWpPuGxNicVfXlgEA-1; Fri, 23 Jul 2021 12:06:21 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B555E1005D54; Fri, 23 Jul 2021 16:06:15 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8CE3760939; Fri, 23 Jul 2021 16:06:15 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id CEB2F4BB7C; Fri, 23 Jul 2021 16:06:14 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 16NG4F6r030846 for ; Fri, 23 Jul 2021 12:04:15 -0400 Received: by smtp.corp.redhat.com (Postfix) id DFD98100238C; Fri, 23 Jul 2021 16:04:15 +0000 (UTC) Received: from harajuku.usersys.redhat.com (unknown [10.40.192.37]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4F3B310016F8 for ; Fri, 23 Jul 2021 16:04:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1627056383; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=bBm6AzdFC6HKWqJZBYdI3Yqk0/lNPkWl9JOOirepRH8=; b=KLz41iPRc9TsGD2aVyVSClqjaA3GItoN86n+VoV5B9YL22T1vryNFTyZ5leCmkq8jGLiVB RmLEFysYIskCdTMkcJgz4UzCxGvtI4uZIvrHsSKWBJT+EkW5QHI4nAVfAPHpGyjYPhc+92 hpFzsIPIdQs+3HDMQyB4HhAMAICNYFc= X-MC-Unique: ouaNNlWpPuGxNicVfXlgEA-1 From: Andrea Bolognani To: libvir-list@redhat.com Subject: [libvirt PATCH 2/3] qemu: Allow pcie-expander-bus for aarch64/virt guests Date: Fri, 23 Jul 2021 18:04:03 +0200 Message-Id: <20210723160404.240841-3-abologna@redhat.com> In-Reply-To: <20210723160404.240841-1-abologna@redhat.com> References: <20210723160404.240841-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1627056385578100001 Content-Type: text/plain; charset="utf-8" Starting with QEMU 6.0, this controller is enabled by default on aarch64. https://bugzilla.redhat.com/show_bug.cgi?id=3D1967187 Signed-off-by: Andrea Bolognani --- src/qemu/qemu_domain.c | 6 +++--- tests/qemuxml2argvdata/pcie-expander-bus-bad-machine.err | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index b919da6eab..4ebd633088 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -5225,10 +5225,10 @@ qemuDomainControllerDefPostParse(virDomainControlle= rDef *cont, return -1; } if (cont->model =3D=3D VIR_DOMAIN_CONTROLLER_MODEL_PCIE_EXPANDER_B= US && - !qemuDomainIsQ35(def)) { + !(qemuDomainIsQ35(def) || qemuDomainIsARMVirt(def))) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("pcie-expander-bus controllers are only suppo= rted " - "on q35-based machinetypes")); + _("pcie-expander-bus controllers are not suppor= ted " + "with this machine type")); return -1; } =20 diff --git a/tests/qemuxml2argvdata/pcie-expander-bus-bad-machine.err b/tes= ts/qemuxml2argvdata/pcie-expander-bus-bad-machine.err index 9b58aaddd6..06967dbbcd 100644 --- a/tests/qemuxml2argvdata/pcie-expander-bus-bad-machine.err +++ b/tests/qemuxml2argvdata/pcie-expander-bus-bad-machine.err @@ -1 +1 @@ -unsupported configuration: pcie-expander-bus controllers are only supporte= d on q35-based machinetypes +unsupported configuration: pcie-expander-bus controllers are not supported= with this machine type --=20 2.31.1