From nobody Tue Feb 10 21:19:10 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1626940320; cv=none; d=zohomail.com; s=zohoarc; b=jo5z004hjUywZbKbHEFbgM/oHyJefK/p/qBrMKeL2YvG8l+6tqdCfvcxBZY8w18q/VqinG8waQ+U9lP0mu1Q2iA/glcGtxmD3W9IzPryYmV/4WJoViLzfPBiKC9IfqEtHczA1CtU/0NrlqQYVuo1PmfRYGxcCtyWIn3MFLYydNA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1626940320; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=J4eweeeCPw+FFtbVokKCmJslbuTnPhZJ1fbod0MvJsU=; b=TrKWYRMZwgl/iRWz3NPZ8r1+YBXSi0Ap9+c8/VpBysKqLc7xZflIDcxa0j0fgrbKEDS2Y0MWphGedGehMh0fExQzXbQrnDWqk9u/pAfQD+pDXkxYXDXXlZBvdh/q0ss8knPr3MR3KzZBrbnOtlRYKgOjlNZloQfJiCz1PlyGk7Y= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1626940320181672.5479770862219; Thu, 22 Jul 2021 00:52:00 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-572-QJepAMbSPrCX_sPAI5BuFA-1; Thu, 22 Jul 2021 03:51:57 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1720C804144; Thu, 22 Jul 2021 07:51:52 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E9E1418969; Thu, 22 Jul 2021 07:51:51 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id B89595004B; Thu, 22 Jul 2021 07:51:51 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 16M7plv1010404 for ; Thu, 22 Jul 2021 03:51:47 -0400 Received: by smtp.corp.redhat.com (Postfix) id E4C2F5DEFB; Thu, 22 Jul 2021 07:51:47 +0000 (UTC) Received: from work.redhat.com (ovpn-112-127.ams2.redhat.com [10.36.112.127]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3668F5DEFA; Thu, 22 Jul 2021 07:51:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626940319; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=J4eweeeCPw+FFtbVokKCmJslbuTnPhZJ1fbod0MvJsU=; b=jMATSvlgAfL5zWZqwrWUHWKwRt+Y/DTzG5I54SpiAGikeqegg6r6f8pwiDzPm9VNpERrZc EnyIVWgQjsOrOoS1DblWbqplY2h/2u7XQcW+Ixxhdjh3OZbHdDHGS9bgqW+kPpuiFCYlWq ktOQSJ110R95AUF+Q0dpEC1G/Min910= X-MC-Unique: QJepAMbSPrCX_sPAI5BuFA-1 From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH 37/38] virStoragePoolObjListNew: `virHashNew` cannot return NULL Date: Thu, 22 Jul 2021 09:50:29 +0200 Message-Id: <20210722075030.25495-38-twiederh@redhat.com> In-Reply-To: <20210722075030.25495-1-twiederh@redhat.com> References: <20210722075030.25495-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: libvir-list@redhat.com Cc: Tim Wiederhake X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1626940322140100004 Content-Type: text/plain; charset="utf-8" Signed-off-by: Tim Wiederhake --- src/conf/virstorageobj.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/conf/virstorageobj.c b/src/conf/virstorageobj.c index 24957d6012..6c8a06e8bc 100644 --- a/src/conf/virstorageobj.c +++ b/src/conf/virstorageobj.c @@ -401,12 +401,8 @@ virStoragePoolObjListNew(void) if (!(pools =3D virObjectRWLockableNew(virStoragePoolObjListClass))) return NULL; =20 - if (!(pools->objs =3D virHashNew(virObjectFreeHashData)) || - !(pools->objsName =3D virHashNew(virObjectFreeHashData))) { - virObjectUnref(pools); - return NULL; - } - + pools->objs =3D virHashNew(virObjectFreeHashData); + pools->objsName =3D virHashNew(virObjectFreeHashData); return pools; } =20 --=20 2.31.1