From nobody Tue Feb 10 21:19:09 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1626940288; cv=none; d=zohomail.com; s=zohoarc; b=Wd6FBQeh/cBM5Th8k+l2Mspu7cVGPjDOo7LTDn0tKurvR9LNyDdEj51Yb6THhEerFCt6lTSI8Ih6o5VqF4A+XHkGq34O1jhp/IyW9e8viDX6fUJZS+H/Uo5ZTV/o+Fw4lA0zbSZsjLWQlkIHyOqZrj10JvxSoEZ7iLfMBqtYKVw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1626940288; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=4wEeTQk7JrIINKpESsPpoLUv368w9qaX/CKBfoYMVxY=; b=R1APyp50zvJQ/+r+TEr9o6ee3m3yWuhmhdcmJ9WiM6GMjk+kx7pEjkcUruwvbikBe3K/0KCBZY8pYK8MohO6jy5014nUDidtJF709c4l5M4UQAb41qEDEo12h8C/bjsV+E4gXZLbS4sPDRlN49/LTQola5tpZrpA+J2ViwnfVHQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1626940288505471.5361963765846; Thu, 22 Jul 2021 00:51:28 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-190-DxHFVutOPImJXaf5apRbqg-1; Thu, 22 Jul 2021 03:51:25 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 492451084F57; Thu, 22 Jul 2021 07:51:20 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 197EA18432; Thu, 22 Jul 2021 07:51:20 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id DC5164A71D; Thu, 22 Jul 2021 07:51:19 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 16M7pGa1010025 for ; Thu, 22 Jul 2021 03:51:16 -0400 Received: by smtp.corp.redhat.com (Postfix) id 86B3117CF0; Thu, 22 Jul 2021 07:51:16 +0000 (UTC) Received: from work.redhat.com (ovpn-112-127.ams2.redhat.com [10.36.112.127]) by smtp.corp.redhat.com (Postfix) with ESMTP id D06E018A6A; Thu, 22 Jul 2021 07:51:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626940287; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=4wEeTQk7JrIINKpESsPpoLUv368w9qaX/CKBfoYMVxY=; b=K67AqqlWvYbbeQdNjGz0w1J2Eh3O4w/GqFkorSlJ+zyzZVC+mzc56s5PE6zy/pRl/kIrEB P2vbdCD5nE2AXyf69tpyehCGV8ZHBVCN24gGMEU/SVBdQb+pKtPCLaMkU2ccBeEP/XZ4/6 bmC7fmANmN4Mvm+ATrnBKbQQc7QQUd0= X-MC-Unique: DxHFVutOPImJXaf5apRbqg-1 From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH 23/38] virFileCacheNew: `virHashNew` cannot return NULL Date: Thu, 22 Jul 2021 09:50:15 +0200 Message-Id: <20210722075030.25495-24-twiederh@redhat.com> In-Reply-To: <20210722075030.25495-1-twiederh@redhat.com> References: <20210722075030.25495-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: libvir-list@redhat.com Cc: Tim Wiederhake X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1626940289420100001 Content-Type: text/plain; charset="utf-8" Signed-off-by: Tim Wiederhake --- src/util/virfilecache.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/src/util/virfilecache.c b/src/util/virfilecache.c index 2f55deefb6..64348dc1e6 100644 --- a/src/util/virfilecache.c +++ b/src/util/virfilecache.c @@ -242,8 +242,7 @@ virFileCacheNew(const char *dir, if (!(cache =3D virObjectNew(virFileCacheClass))) return NULL; =20 - if (!(cache->table =3D virHashNew(virObjectFreeHashData))) - goto cleanup; + cache->table =3D virHashNew(virObjectFreeHashData); =20 cache->dir =3D g_strdup(dir); =20 @@ -252,10 +251,6 @@ virFileCacheNew(const char *dir, cache->handlers =3D *handlers; =20 return cache; - - cleanup: - virObjectUnref(cache); - return NULL; } =20 =20 --=20 2.31.1