From nobody Tue Feb 10 23:00:55 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1626940460; cv=none; d=zohomail.com; s=zohoarc; b=GqU/sLcW9/PuWGHnFlNL6jI8HHB9OVBKqXbTymwqrqPGOx/9ZFHF5NEtjVPzP/tq2PHA3j+fZm3v33iAcxN8zpU0Nr8SQ0RUcZI5hZaZO//o6czCubGHu/KAfErPlmYUO0Ku9cQr+q5sf0UjnNhecyHWysEVGaPfrVCiZJ1yZMY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1626940460; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=knXRk0pklpec6UIEbHzVTTDLGnnnu/AKkyyEE/pKslE=; b=Mb9zZI9X2ViZY6BUse5GxsHsb/D94rCkgQbXWNDkTWICMyQFuRh+vRtZ8ODitFxAiHFvCS4dKuLROtZgoIpPnfRvCp4/1OCZXZIxL/6C43oYeHYePeehDMMCh2I02JQdX5AMxhDXz/ti4o8wxknIhPkg0mMRzbutJw5IUwgVm7g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1626940460950616.8763135119202; Thu, 22 Jul 2021 00:54:20 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-104-whCUZP6GN7qeIOsZM3s_RQ-1; Thu, 22 Jul 2021 03:51:21 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D20C1804148; Thu, 22 Jul 2021 07:51:16 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B756217C5F; Thu, 22 Jul 2021 07:51:16 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 8594C181A3ED; Thu, 22 Jul 2021 07:51:16 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 16M7p97i009851 for ; Thu, 22 Jul 2021 03:51:09 -0400 Received: by smtp.corp.redhat.com (Postfix) id 784795DD86; Thu, 22 Jul 2021 07:51:09 +0000 (UTC) Received: from work.redhat.com (ovpn-112-127.ams2.redhat.com [10.36.112.127]) by smtp.corp.redhat.com (Postfix) with ESMTP id C0BE05DD68; Thu, 22 Jul 2021 07:51:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626940460; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=knXRk0pklpec6UIEbHzVTTDLGnnnu/AKkyyEE/pKslE=; b=MM70SzE2N7BuBdcq6yf+5oH8mrjRlE39OgGBViJRlvCs2IRNpqFSz/fMZ1nPYHAsfGNSdD 53oyjsXUNyXAS6v/gjQx4UjGLYeomejMTvHybbRrHySNzXojCZJA/FyBm77LwwZFD3yetJ W7M2AlVxG7Y5ug0E9rpygOwtuV8oPcA= X-MC-Unique: whCUZP6GN7qeIOsZM3s_RQ-1 From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH 20/38] virDomainDefValidateAliases: `virHashNew` cannot return NULL Date: Thu, 22 Jul 2021 09:50:12 +0200 Message-Id: <20210722075030.25495-21-twiederh@redhat.com> In-Reply-To: <20210722075030.25495-1-twiederh@redhat.com> References: <20210722075030.25495-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: libvir-list@redhat.com Cc: Tim Wiederhake X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1626940461653100001 Content-Type: text/plain; charset="utf-8" Signed-off-by: Tim Wiederhake --- src/conf/domain_validate.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/conf/domain_validate.c b/src/conf/domain_validate.c index df2ab47361..aab377fbbd 100644 --- a/src/conf/domain_validate.c +++ b/src/conf/domain_validate.c @@ -1261,8 +1261,7 @@ virDomainDefValidateAliases(const virDomainDef *def, int ret =3D -1; =20 /* We are not storing copies of aliases. Don't free them. */ - if (!(data.aliases =3D virHashNew(NULL))) - goto cleanup; + data.aliases =3D virHashNew(NULL); =20 if (virDomainDeviceInfoIterateFlags((virDomainDef *) def, virDomainDeviceDefValidateAliasesI= terator, --=20 2.31.1