[libvirt PATCH 00/38] virHashNew refactorings - part VII

Tim Wiederhake posted 38 patches 2 years, 8 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20210722075030.25495-1-twiederh@redhat.com
src/conf/domain_addr.c                    |  7 +------
src/conf/domain_conf.c                    |  5 +----
src/conf/domain_validate.c                |  3 +--
src/conf/virchrdev.c                      |  6 +-----
src/conf/virdomainmomentobjlist.c         |  4 ----
src/conf/virdomainobjlist.c               |  8 ++------
src/conf/virinterfaceobj.c                |  5 +----
src/conf/virnetworkobj.c                  |  8 ++------
src/conf/virnodedeviceobj.c               |  5 +----
src/conf/virstorageobj.c                  | 17 +++++------------
src/hyperv/hyperv_wmi.c                   |  6 +-----
src/hypervisor/virclosecallbacks.c        |  4 ----
src/libxl/libxl_logger.c                  |  4 +---
src/locking/lock_daemon.c                 |  6 ++----
src/nwfilter/nwfilter_ebiptables_driver.c |  3 ---
src/nwfilter/nwfilter_gentech_driver.c    | 18 ++++++------------
src/qemu/qemu_block.c                     | 15 +++------------
src/qemu/qemu_capabilities.c              |  3 +--
src/qemu/qemu_domain.c                    |  3 +--
src/qemu/qemu_interop_config.c            |  5 +----
src/rpc/virnetdaemon.c                    |  3 +--
src/security/security_selinux.c           |  6 ++----
src/util/virfilecache.c                   |  7 +------
src/util/virhash.c                        |  5 +----
src/util/virlockspace.c                   |  6 ++----
src/util/virsystemd.c                     | 16 +++++-----------
tests/qemusecuritymock.c                  | 17 +++--------------
27 files changed, 46 insertions(+), 149 deletions(-)
[libvirt PATCH 00/38] virHashNew refactorings - part VII
Posted by Tim Wiederhake 2 years, 8 months ago
"virHashNew" cannot return NULL, yet we check for NULL in various places.

See https://listman.redhat.com/archives/libvir-list/2021-July/msg00074.html.

Not split up further as per
https://listman.redhat.com/archives/libvir-list/2021-July/msg00575.html

Tim Wiederhake (38):
  virSystemdActivationNew: `virHashNew` cannot return NULL
  virSystemdActivationNew: Use automatic memory management
  virSystemdActivationNew: Remove superfluous `goto`s
  virNWFilterCreateVarsFrom: `virHashNew` cannot return NULL
  virNWFilterCreateVarsFrom: Use automatic memory management
  virNWFilterCreateVarsFrom: Remove superfluous `goto`s
  virNWFilterRuleDefToRuleInst: `virHashNew` cannot return NULL
  ebiptablesApplyNewRules: `virHashNew` cannot return NULL
  hypervCreateEmbeddedParam: `virHashNew` cannot return NULL
  qemusecuritymock: init_hash: `virHashNew` cannot return NULL
  libxlLoggerNew: `virHashNew` cannot return NULL
  qemuBlockNodeNamesDetect: `virHashNew` cannot return NULL
  qemuBlockNodeNameGetBackingChain: `virHashNew` cannot return NULL
  qemuDomainObjPrivateAlloc: `virHashNew` cannot return NULL
  qemuInteropFetchConfigs: `virHashNew` cannot return NULL
  virChrdevAlloc: `virHashNew` cannot return NULL
  virCloseCallbacksNew: `virHashNew` cannot return NULL
  virDomainCCWAddressSetCreate: `virHashNew` cannot return NULL
  virDomainDefBootOrderPostParse: `virHashNew` cannot return NULL
  virDomainDefValidateAliases: `virHashNew` cannot return NULL
  virDomainMomentObjListNew: `virHashNew` cannot return NULL
  virDomainObjListNew: `virHashNew` cannot return NULL
  virFileCacheNew: `virHashNew` cannot return NULL
  virHashAtomicNew: `virHashNew` cannot return NULL
  virInterfaceObjListNew: `virHashNew` cannot return NULL
  virLockDaemonNew: `virHashNew` cannot return NULL
  virLockDaemonNewPostExecRestart: `virHashNew` cannot return NULL
  virLockSpaceNew: `virHashNew` cannot return NULL
  virLockSpaceNewPostExecRestart: `virHashNew` cannot return NULL
  virNetDaemonNew: `virHashNew` cannot return NULL
  virNetworkObjListNew: `virHashNew` cannot return NULL
  virNetworkObjNew: `virHashNew` cannot return NULL
  virNodeDeviceObjListNew: `virHashNew` cannot return NULL
  virQEMUCapsProbeQMPHostCPU: `virHashNew` cannot return NULL
  virSecuritySELinuxLXCInitialize: `virHashNew` cannot return NULL
  virSecuritySELinuxQEMUInitialize: `virHashNew` cannot return NULL
  virStoragePoolObjListNew: `virHashNew` cannot return NULL
  virStorageVolObjListNew: `virHashNew` cannot return NULL

 src/conf/domain_addr.c                    |  7 +------
 src/conf/domain_conf.c                    |  5 +----
 src/conf/domain_validate.c                |  3 +--
 src/conf/virchrdev.c                      |  6 +-----
 src/conf/virdomainmomentobjlist.c         |  4 ----
 src/conf/virdomainobjlist.c               |  8 ++------
 src/conf/virinterfaceobj.c                |  5 +----
 src/conf/virnetworkobj.c                  |  8 ++------
 src/conf/virnodedeviceobj.c               |  5 +----
 src/conf/virstorageobj.c                  | 17 +++++------------
 src/hyperv/hyperv_wmi.c                   |  6 +-----
 src/hypervisor/virclosecallbacks.c        |  4 ----
 src/libxl/libxl_logger.c                  |  4 +---
 src/locking/lock_daemon.c                 |  6 ++----
 src/nwfilter/nwfilter_ebiptables_driver.c |  3 ---
 src/nwfilter/nwfilter_gentech_driver.c    | 18 ++++++------------
 src/qemu/qemu_block.c                     | 15 +++------------
 src/qemu/qemu_capabilities.c              |  3 +--
 src/qemu/qemu_domain.c                    |  3 +--
 src/qemu/qemu_interop_config.c            |  5 +----
 src/rpc/virnetdaemon.c                    |  3 +--
 src/security/security_selinux.c           |  6 ++----
 src/util/virfilecache.c                   |  7 +------
 src/util/virhash.c                        |  5 +----
 src/util/virlockspace.c                   |  6 ++----
 src/util/virsystemd.c                     | 16 +++++-----------
 tests/qemusecuritymock.c                  | 17 +++--------------
 27 files changed, 46 insertions(+), 149 deletions(-)

-- 
2.31.1


Re: [libvirt PATCH 00/38] virHashNew refactorings - part VII
Posted by Peter Krempa 2 years, 8 months ago
On Thu, Jul 22, 2021 at 09:49:52 +0200, Tim Wiederhake wrote:
> "virHashNew" cannot return NULL, yet we check for NULL in various places.
> 
> See https://listman.redhat.com/archives/libvir-list/2021-July/msg00074.html.
> 
> Not split up further as per
> https://listman.redhat.com/archives/libvir-list/2021-July/msg00575.html

After you fix the two small issues pointed out in specific patches:

Series:

Reviewed-by: Peter Krempa <pkrempa@redhat.com>

I've also identified a few cleanups irrelevant to your series:

https://listman.redhat.com/archives/libvir-list/2021-July/msg00725.html