From nobody Sat Feb 7 09:29:35 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1626255974; cv=none; d=zohomail.com; s=zohoarc; b=JCK08mSmrTPnWIZtZYwLJ5GfG7+r7CJU5Tiefef7OXxGm7j2e8x18err2oRqo6X7DTyOXaJCnvlE/Be2ooRajDCjZ52i/BRh9nDhBinkMuOe+QIefxFO9/KxYVdzdiaDO/AzACWC3SBCRP+TccH3I0FQC4SNS9SOAxfT9NS2+pY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1626255974; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=eudBPY+/cMtCBGjJkF605EUFEzAYuHsV9KnWW7lc0x4=; b=D1rcV2pcom05qoWQgNu5iy3IlWRr12ZZeJUsKNhzCE7weegOW6rt73asthuTyPZgzakOryvuXthiM5ShFkV5Urm4qXEcgz1Syh0EzuoI0KUhjfs/u3on+6rRRBY7cs4szBKKF5M2s+/D5Kzx52JFtZ3G4gTKNBRtc9Fkb2U6G5E= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1626255974495611.2818088663896; Wed, 14 Jul 2021 02:46:14 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-438-ZH7PRMvLMJy8LNyDYJPS-w-1; Wed, 14 Jul 2021 05:46:12 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 39AA3A40D6; Wed, 14 Jul 2021 09:46:07 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1E18660871; Wed, 14 Jul 2021 09:46:07 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id DFB214EA42; Wed, 14 Jul 2021 09:46:06 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 16E9k6sk001943 for ; Wed, 14 Jul 2021 05:46:06 -0400 Received: by smtp.corp.redhat.com (Postfix) id 01BD25D705; Wed, 14 Jul 2021 09:46:06 +0000 (UTC) Received: from work.redhat.com (ovpn-113-156.ams2.redhat.com [10.36.113.156]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4946C5D6D1; Wed, 14 Jul 2021 09:46:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626255973; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=eudBPY+/cMtCBGjJkF605EUFEzAYuHsV9KnWW7lc0x4=; b=MMpDfoIIuhiG1lx/mYwg4vrVg76CHFwsKwsfSsTYnALy6I40ELg2pLrGf1WJzpEhdo12Fx PoyyuoublhYbT4ptZTL8eSNu11Ft+G2sAGpCQoG0YbZMEQG4G/VD9B9ab+dxFVroS8a+2h boJGh63gUPjt5nfYBdwrSIKwYyb9GUA= X-MC-Unique: ZH7PRMvLMJy8LNyDYJPS-w-1 From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH 08/10] virNWFilterDoInstantiate: `virHashNew` cannot return NULL Date: Wed, 14 Jul 2021 11:44:55 +0200 Message-Id: <20210714094457.61612-9-twiederh@redhat.com> In-Reply-To: <20210714094457.61612-1-twiederh@redhat.com> References: <20210714094457.61612-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Cc: Tim Wiederhake X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1626255976395100001 Content-Type: text/plain; charset="utf-8" Signed-off-by: Tim Wiederhake --- src/nwfilter/nwfilter_gentech_driver.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/nwfilter/nwfilter_gentech_driver.c b/src/nwfilter/nwfilter= _gentech_driver.c index 8aa1db23d3..114c1cef4f 100644 --- a/src/nwfilter/nwfilter_gentech_driver.c +++ b/src/nwfilter/nwfilter_gentech_driver.c @@ -519,11 +519,6 @@ virNWFilterDoInstantiate(virNWFilterTechDriver *techdr= iver, =20 memset(&inst, 0, sizeof(inst)); =20 - if (!missing_vars) { - rc =3D -1; - goto error; - } - rc =3D virNWFilterDetermineMissingVarsRec(filter, binding->filterparams, missing_vars, --=20 2.31.1