From nobody Mon Feb 9 23:39:06 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1626189162; cv=none; d=zohomail.com; s=zohoarc; b=BqONE+tK0xUtjgbHBE0LDLMp6HXmhffRpRzpVrIUv1OBYesf2m7W349Nk3jI8O+YSpDwXjTfXn+8hD57C7ULLaO+dXdKzrGoSzeH228QbVbWhTlE9asfvJBiTTJgXCk9uSLtfToIqqTT7s+ZB43k4Wy1iTRv7j0sKZbLRYvlobs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1626189162; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=coZLb57f67Yzts/fgvkc7LjdSqjP9yzMiP39J0+NvuU=; b=Kj0Es8A+0v3Q+Dfonx2CTfk1IoKZgzNkCl2f6XSiY7XQo+IvrK9UO8Qb57ohmyIid9gA5Ha+jFEqlu9srn3cGrM9Im5p2neAYbIO8Q3gbtKXXGbZotDNwm9I0Ml7ExKVlKYYMBjH02fV1IMs8gyUyGpBMQ4SQXSpzQCFhbXTWko= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1626189162011878.6434689113087; Tue, 13 Jul 2021 08:12:42 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-225-QGZljj6GMAquGKhp9beltA-1; Tue, 13 Jul 2021 11:12:39 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 671C18015C6; Tue, 13 Jul 2021 15:12:33 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3BA101009962; Tue, 13 Jul 2021 15:12:33 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id DE4A64EA29; Tue, 13 Jul 2021 15:12:32 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 16DFCPkd003658 for ; Tue, 13 Jul 2021 11:12:25 -0400 Received: by smtp.corp.redhat.com (Postfix) id 0FBBB5C232; Tue, 13 Jul 2021 15:12:25 +0000 (UTC) Received: from work.redhat.com (ovpn-113-139.ams2.redhat.com [10.36.113.139]) by smtp.corp.redhat.com (Postfix) with ESMTP id 313C65C22A; Tue, 13 Jul 2021 15:12:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626189161; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=coZLb57f67Yzts/fgvkc7LjdSqjP9yzMiP39J0+NvuU=; b=G9At0JMRXg32nDuB7xElMz6AS1a15lUm47EKNqbp7SW1V9UMj9E6BecOmuQBetYyyvMOCZ 8M2WpaUyuXq8zO2giMdbT0UAw8UsjPnANFakeZAFSupmaolCTCIWkbnOLN+7tSOLMhFzD9 Xo3tPmJOQGir+Ee65FTgsUCbfMC4KyA= X-MC-Unique: QGZljj6GMAquGKhp9beltA-1 From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH v2 06/10] iptablesPrivateChainCreate: Use automatic memory management Date: Tue, 13 Jul 2021 17:12:08 +0200 Message-Id: <20210713151212.62582-7-twiederh@redhat.com> In-Reply-To: <20210713151212.62582-1-twiederh@redhat.com> References: <20210713151212.62582-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com Cc: Peter Krempa , Tim Wiederhake X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1626189162815100002 Content-Type: text/plain; charset="utf-8" Signed-off-by: Tim Wiederhake Reviewed-by: Peter Krempa --- src/util/viriptables.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/util/viriptables.c b/src/util/viriptables.c index 198ece3d71..847af9b9d7 100644 --- a/src/util/viriptables.c +++ b/src/util/viriptables.c @@ -70,8 +70,8 @@ iptablesPrivateChainCreate(virFirewall *fw, void *opaque) { iptablesGlobalChainData *data =3D opaque; - GHashTable *chains =3D virHashNew(NULL); - GHashTable *links =3D virHashNew(NULL); + g_autoptr(GHashTable) chains =3D virHashNew(NULL); + g_autoptr(GHashTable) links =3D virHashNew(NULL); const char *const *tmp; int ret =3D -1; size_t i; @@ -114,8 +114,6 @@ iptablesPrivateChainCreate(virFirewall *fw, =20 ret =3D 0; cleanup: - virHashFree(chains); - virHashFree(links); return ret; } =20 --=20 2.31.1