From nobody Mon Feb 9 17:58:10 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1626189153; cv=none; d=zohomail.com; s=zohoarc; b=dBrrjQmEOHAqT2lIIGXlCFklR1JZPDhehy4ajTPVpThzQvh/WJ5WCuXgkeBMKGKEl2+495E9lm7oHRXNfEji45j1VEDqQmpqZVB5laRBxWWTjLj8kjBXslPKnt3/eMNaQ2gzO96SFkhG834fGOEqQQJeCPW25UjuM02UXgUxkjM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1626189153; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=nw0CizcJkzj/cGee3g1DFBxTtGqmp1WnKf9D5I4Ex+o=; b=jRYVJpmtMVpclOsN/3i1sk1vEjQ94S79HXFVMbTTGQwKIcc04sxigdc2JvjXQRACf60U5CSKtYp8EdQitf1r2o72gxsT19T6A/4hqW0M7NInduxLSI/lgL4rE0XslkpX5YFsrI84Df7uyHNZD6UXnFPaeqyDhrmwTn/fcPzW4tc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 162618915313582.52545447451416; Tue, 13 Jul 2021 08:12:33 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-452-YuoVDSKCOa6AnSjhYeM7Ug-1; Tue, 13 Jul 2021 11:12:29 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B81BE800050; Tue, 13 Jul 2021 15:12:24 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 46FE860BD8; Tue, 13 Jul 2021 15:12:24 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id C1ABC1826D29; Tue, 13 Jul 2021 15:12:23 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 16DFCMVt003637 for ; Tue, 13 Jul 2021 11:12:22 -0400 Received: by smtp.corp.redhat.com (Postfix) id A35755C22A; Tue, 13 Jul 2021 15:12:22 +0000 (UTC) Received: from work.redhat.com (ovpn-113-139.ams2.redhat.com [10.36.113.139]) by smtp.corp.redhat.com (Postfix) with ESMTP id C51AB5C1C5; Tue, 13 Jul 2021 15:12:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626189151; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=nw0CizcJkzj/cGee3g1DFBxTtGqmp1WnKf9D5I4Ex+o=; b=PMGWWJ+GQOHec32/Sw9S9+xjbdSkhBtZCIeKlQ6Als4myvMLOyeDWeEoCclvr5IWJmZiZs p6D08Rx78XmAxQHPBRQZGs3C7/0JHh5O8A6O0Id3puhxVfMCKPjrk/8713uOlnMgCcULOl KHIhjSCIxf7mKlhQB/sOmPJyifYovm8= X-MC-Unique: YuoVDSKCOa6AnSjhYeM7Ug-1 From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH v2 04/10] virNWFilterRuleDefToRuleInst: `virHashNew` cannot return NULL Date: Tue, 13 Jul 2021 17:12:06 +0200 Message-Id: <20210713151212.62582-5-twiederh@redhat.com> In-Reply-To: <20210713151212.62582-1-twiederh@redhat.com> References: <20210713151212.62582-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com Cc: Peter Krempa , Tim Wiederhake X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1626189154976100001 Content-Type: text/plain; charset="utf-8" Signed-off-by: Tim Wiederhake Reviewed-by: Peter Krempa --- tests/nwfilterxml2firewalltest.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/nwfilterxml2firewalltest.c b/tests/nwfilterxml2firewallt= est.c index bdfe858185..75a70e9972 100644 --- a/tests/nwfilterxml2firewalltest.c +++ b/tests/nwfilterxml2firewalltest.c @@ -208,8 +208,8 @@ virNWFilterRuleDefToRuleInst(virNWFilterDef *def, ruleinst->chainPriority =3D def->chainPriority; ruleinst->def =3D rule; ruleinst->priority =3D rule->priority; - if (!(ruleinst->vars =3D virHashNew(virNWFilterVarValueHashFree))) - goto cleanup; + ruleinst->vars =3D virHashNew(virNWFilterVarValueHashFree); + if (virNWFilterHashTablePutAll(vars, ruleinst->vars) < 0) goto cleanup; =20 --=20 2.31.1