From nobody Mon Feb 9 23:39:04 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1626189159; cv=none; d=zohomail.com; s=zohoarc; b=cePMln+xf5S9N4Rg3UXJsUhJrCw47oJmT51EqdefNMfPmO/Twk4FYt3pZT597mnwVeaJmQF6QmzYVQGjYcbwQTT9+jLwkOVEUpmZMZk7D8b/dB9Pdw1+AFKQtDLtIKfQinzQtc385KdZmhdykyxZW3+OXKX76q9wDcTq4M0rdV4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1626189159; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=TGgFlWCTNQvBwFw+GvP2cajUe4pYGxV6xhUXHqlTBHE=; b=E/4gkzG2cg8NZMF1zBHb8jefBJ44AYRmnX6q5o5wHlEupu9yt9gnXmhIsUABJp/jm5/kH0SmFlgevIz61coLObS+qdMfd5vUWCbe2busp5qfAQaVOBSkSJh10MTFRnX+gjzIXf4WpcdbdkSuOPa/Dd+0wT3/HWUr7E+QgZMrkTk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1626189159175815.4780238144997; Tue, 13 Jul 2021 08:12:39 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-480-MS2VEB7CPHueqEzCDomt8Q-1; Tue, 13 Jul 2021 11:12:36 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E9DAA100C609; Tue, 13 Jul 2021 15:12:30 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C6FC160C05; Tue, 13 Jul 2021 15:12:30 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 7CCF24A712; Tue, 13 Jul 2021 15:12:30 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 16DFCKwi003615 for ; Tue, 13 Jul 2021 11:12:20 -0400 Received: by smtp.corp.redhat.com (Postfix) id 421F25C22A; Tue, 13 Jul 2021 15:12:20 +0000 (UTC) Received: from work.redhat.com (ovpn-113-139.ams2.redhat.com [10.36.113.139]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6328F5C1C5; Tue, 13 Jul 2021 15:12:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626189158; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=TGgFlWCTNQvBwFw+GvP2cajUe4pYGxV6xhUXHqlTBHE=; b=BwLbFiAG0k4QPtL2+bxF3x9y5bP3OuKBOGaqpa01Eg6HYVh6lz5yfk2Rz8TKDnajUR9K8k ETokfv1Wp/afQCC/2jIG7d5yqQxXGgES6tkEtceS9Zkv3EY65a/aT/buFPh1uNM2BB1Gne /rd9a27rT/7FOmJWoXA7jNqKscTqlqc= X-MC-Unique: MS2VEB7CPHueqEzCDomt8Q-1 From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH v2 02/10] virNWFilterCreateVarsFrom: Use automatic memory management Date: Tue, 13 Jul 2021 17:12:04 +0200 Message-Id: <20210713151212.62582-3-twiederh@redhat.com> In-Reply-To: <20210713151212.62582-1-twiederh@redhat.com> References: <20210713151212.62582-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com Cc: Peter Krempa , Tim Wiederhake X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1626189160425100003 Content-Type: text/plain; charset="utf-8" Signed-off-by: Tim Wiederhake Reviewed-by: Peter Krempa --- tests/nwfilterxml2firewalltest.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tests/nwfilterxml2firewalltest.c b/tests/nwfilterxml2firewallt= est.c index 3b7190b5cd..26d4a936ad 100644 --- a/tests/nwfilterxml2firewalltest.c +++ b/tests/nwfilterxml2firewalltest.c @@ -148,7 +148,7 @@ static GHashTable * virNWFilterCreateVarsFrom(GHashTable *vars1, GHashTable *vars2) { - GHashTable *res =3D virHashNew(virNWFilterVarValueHashFree); + g_autoptr(GHashTable) res =3D virHashNew(virNWFilterVarValueHashFree); =20 if (virNWFilterHashTablePutAll(vars1, res) < 0) goto err_exit; @@ -156,10 +156,9 @@ virNWFilterCreateVarsFrom(GHashTable *vars1, if (virNWFilterHashTablePutAll(vars2, res) < 0) goto err_exit; =20 - return res; + return g_steal_pointer(&res); =20 err_exit: - virHashFree(res); return NULL; } =20 --=20 2.31.1