From nobody Tue Feb 10 01:14:46 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1626189195; cv=none; d=zohomail.com; s=zohoarc; b=UD+1ZkS1gY7kQMQrSHpRcjvQiIjh8WcVwxMdA41Z1HzxINHdlBd9MEfWLPOeAuaYnXQKIsczYeiGYr+UjYvwQDLi4y25fvEfghCtChGT+RiWrpSYHrH4saOOktm0BvsJyVd/EROLrBODeywwsDqYtDxnlmzMy/Eh+0vEVbYfXnk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1626189195; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=eWE38zRxJWT78V7C63LyHVeEgGUMHmEoae5Zep8Lork=; b=fwh+LYDFaP1FR4NgHf+PafidYQdD3GcHojVT/ryRPw/i0bwK4KCp25yJefasf7H0iWBZn3c7/JXeeDSg7KErVbomQOWt7y2I/gS9VU74olhFopvnCipBPeyW6/jpfbzqOdzHsMqOmAXYXuEBavf+eEdfH9dL2w820eYeNW2p29o= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 162618919537999.92743030072745; Tue, 13 Jul 2021 08:13:15 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-502-qr6y11FgPG2kDh2KZVz6eA-1; Tue, 13 Jul 2021 11:12:44 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 80B2080430F; Tue, 13 Jul 2021 15:12:39 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 378075C22A; Tue, 13 Jul 2021 15:12:39 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 03C624EA29; Tue, 13 Jul 2021 15:12:39 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 16DFCTWp003698 for ; Tue, 13 Jul 2021 11:12:29 -0400 Received: by smtp.corp.redhat.com (Postfix) id 7E8195C22A; Tue, 13 Jul 2021 15:12:29 +0000 (UTC) Received: from work.redhat.com (ovpn-113-139.ams2.redhat.com [10.36.113.139]) by smtp.corp.redhat.com (Postfix) with ESMTP id A03CE5C22B; Tue, 13 Jul 2021 15:12:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626189194; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=eWE38zRxJWT78V7C63LyHVeEgGUMHmEoae5Zep8Lork=; b=K8GqbHLsjVb1YTjZDAGfBmQeey1duDjXpb0GjMb8d6SqXmJgWAjy6ejsXe2dL3t+HujOkE EdpCLxmHbNRkkkLjluYn1JikJK0D1osOgpSJbT/F8DeLe76MVd9/YNbFZOFP9xti7T9C19 yemuEaXhv3O4MPZvCiFZT3OOG5zLqAw= X-MC-Unique: qr6y11FgPG2kDh2KZVz6eA-1 From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH v2 10/10] qemuMonitorGetMemoryDeviceInfo: `virHashNew` cannot return NULL Date: Tue, 13 Jul 2021 17:12:12 +0200 Message-Id: <20210713151212.62582-11-twiederh@redhat.com> In-Reply-To: <20210713151212.62582-1-twiederh@redhat.com> References: <20210713151212.62582-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com Cc: Peter Krempa , Tim Wiederhake X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1626189196169100001 Content-Type: text/plain; charset="utf-8" Signed-off-by: Tim Wiederhake Reviewed-by: Peter Krempa --- src/qemu/qemu_monitor.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index 0b5da8b71f..f66a3457c1 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c @@ -4214,7 +4214,7 @@ int qemuMonitorGetMemoryDeviceInfo(qemuMonitor *mon, GHashTable **info) { - g_autoptr(GHashTable) hash =3D NULL; + g_autoptr(GHashTable) hash =3D virHashNew(g_free); int ret; =20 VIR_DEBUG("info=3D%p", info); @@ -4223,9 +4223,6 @@ qemuMonitorGetMemoryDeviceInfo(qemuMonitor *mon, =20 QEMU_CHECK_MONITOR(mon); =20 - if (!(hash =3D virHashNew(g_free))) - return -1; - if ((ret =3D qemuMonitorJSONGetMemoryDeviceInfo(mon, hash)) >=3D 0) *info =3D g_steal_pointer(&hash); =20 --=20 2.31.1