From nobody Tue Feb 10 04:13:52 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1626187526; cv=none; d=zohomail.com; s=zohoarc; b=UNmqA/WR8VTn8ScqLSwltrrlynzV1UNtQ/1Qqs645AMO2/2pJ1A8re0lvTqHIjzspfIisu49nyVCaxzO600AS0HdVyuBrUBWqHNJfX3n48dsXDFl1utqlNRR5G92SLesOg+G+fApsc0lSFfVQegBxaqnrwOgCFc2XpE/uK+akZI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1626187526; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=uRBI5ZAT2KbGSHn/uporEcdOOdlYBfEwWRCJ/FrLlN4=; b=kGgYBar5bTIUY+U/CpKjqUWWWmsbFivE9ig9MOTMAQurCMh3lKwlkK7CymNpc2WCPc0xQJC52H5S5xl77R616djzTaSD8r7P4Tx2EeckBmqTHsot3ouk88lxuIzshTWwTYNb8pT7zMTgxZ8cjM9Lf9INdtKT11uKpFJRvH6Cobs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1626187526755574.9894136657906; Tue, 13 Jul 2021 07:45:26 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-287-bxcyoKN1PD2nHJRcTn27TQ-1; Tue, 13 Jul 2021 10:45:24 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4C4D58BDEA4; Tue, 13 Jul 2021 14:45:18 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0E2AA60BD8; Tue, 13 Jul 2021 14:45:18 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id C51DB4EA3D; Tue, 13 Jul 2021 14:45:17 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 16DEivSV032042 for ; Tue, 13 Jul 2021 10:44:57 -0400 Received: by smtp.corp.redhat.com (Postfix) id 084891042A50; Tue, 13 Jul 2021 14:44:57 +0000 (UTC) Received: from work.redhat.com (ovpn-113-139.ams2.redhat.com [10.36.113.139]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5209A1009962; Tue, 13 Jul 2021 14:44:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626187525; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=uRBI5ZAT2KbGSHn/uporEcdOOdlYBfEwWRCJ/FrLlN4=; b=SwJ6OdjzenCp5n0GSBLReeC1ZXJJiOLlyvV0HdPhFUs/03qVZN4OtvJNTNsWLmTAtYYR3i UEMnP7tovA67tZ14gNstozBEZUs+AzvRck38ES9Ry9bzW+6PjU4UMFeXHqWGk87QUWpga4 WCRlDiA4DG05i5IPt3xd7sa5xZhSe9E= X-MC-Unique: bxcyoKN1PD2nHJRcTn27TQ-1 From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH 10/10] virNWFilterDHCPSnoopInit: `virHashNew` cannot return NULL Date: Tue, 13 Jul 2021 16:44:41 +0200 Message-Id: <20210713144441.60635-11-twiederh@redhat.com> In-Reply-To: <20210713144441.60635-1-twiederh@redhat.com> References: <20210713144441.60635-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: libvir-list@redhat.com Cc: Tim Wiederhake X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1626187529052100003 Content-Type: text/plain; charset="utf-8" Signed-off-by: Tim Wiederhake --- src/nwfilter/nwfilter_dhcpsnoop.c | 17 ----------------- 1 file changed, 17 deletions(-) diff --git a/src/nwfilter/nwfilter_dhcpsnoop.c b/src/nwfilter/nwfilter_dhcp= snoop.c index 2481ea5371..4b62a7b661 100644 --- a/src/nwfilter/nwfilter_dhcpsnoop.c +++ b/src/nwfilter/nwfilter_dhcpsnoop.c @@ -1998,27 +1998,10 @@ virNWFilterDHCPSnoopInit(void) virNWFilterSnoopState.snoopReqs =3D virHashNew(virNWFilterSnoopReqRelease); =20 - if (!virNWFilterSnoopState.ifnameToKey || - !virNWFilterSnoopState.snoopReqs || - !virNWFilterSnoopState.active) - goto error; - virNWFilterSnoopLeaseFileLoad(); virNWFilterSnoopLeaseFileOpen(); =20 return 0; - - error: - virHashFree(virNWFilterSnoopState.ifnameToKey); - virNWFilterSnoopState.ifnameToKey =3D NULL; - - virHashFree(virNWFilterSnoopState.snoopReqs); - virNWFilterSnoopState.snoopReqs =3D NULL; - - virHashFree(virNWFilterSnoopState.active); - virNWFilterSnoopState.active =3D NULL; - - return -1; } =20 /** --=20 2.31.1