From nobody Sun Apr 28 07:50:02 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1626163478; cv=none; d=zohomail.com; s=zohoarc; b=NJl4BpMFmOVsXQkI5fNJjrCWgZnKD9rUBK1BfPGhwV8s6cQQ6x9ZpXxbsBh2e7zrIF1wMPa4RRilMJ7jRTqbMfNesolPuQrdV5uAWLY8oQchiNdUKzVy4sXi6+ZCfE8kcTelXYuSnc9FtCRD8MwI0Dv8xv1Ey7XFogkDsARjecs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1626163478; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=mAfETV/6DrcrXtyIa1q8uBPL7bCrexJVMvtNSeDqOAQ=; b=LLT/XA1J++RpbqtxQTYC+q93K+kUC8gEIv0TnMJHxLGJVdTklFcF2IXk7DpfAELfxEJctY+EFSeZrICKxQuO1DI3Y5GBXsq6ZE8C1KuJ6vUfW3ggTNUV6LLtJxL6q5lRjpH15AW0HJrQnmC06/UDJdUtqP2QYEbDxZNrs+0Xv7g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1626163478666457.4799730031922; Tue, 13 Jul 2021 01:04:38 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-547-9YT_SBtDPKyDZEhUE9adVg-1; Tue, 13 Jul 2021 04:04:35 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E33CC8015F5; Tue, 13 Jul 2021 08:04:29 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 40BEC60583; Tue, 13 Jul 2021 08:04:28 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 6498A4EA2A; Tue, 13 Jul 2021 08:04:23 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 16D84LEx026227 for ; Tue, 13 Jul 2021 04:04:21 -0400 Received: by smtp.corp.redhat.com (Postfix) id E878960CA1; Tue, 13 Jul 2021 08:04:21 +0000 (UTC) Received: from localhost.localdomain.com (ovpn-12-120.pek2.redhat.com [10.72.12.120]) by smtp.corp.redhat.com (Postfix) with ESMTP id A93A460C05; Tue, 13 Jul 2021 08:04:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626163477; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=mAfETV/6DrcrXtyIa1q8uBPL7bCrexJVMvtNSeDqOAQ=; b=JT1D67qbiZ6DQsuNmrK1Am5iYrrxC22RD5mMTqXthQFfRodN3Bsb2+bIz+XdcFEuyhh7I+ 1ZPujUhCVkeFlHboMrZcsXhaM9JvWnAuVgPrUK5b2NSESjjoEiOofxZhGhV09op9RV/3JP sSJALEGsvgSgHDZJ6E95AzaK4Ryfet8= X-MC-Unique: 9YT_SBtDPKyDZEhUE9adVg-1 From: Han Han To: libvir-list@redhat.com Subject: [PATCH] virsh: Fix the order of format arguments in doDump Date: Tue, 13 Jul 2021 16:04:12 +0800 Message-Id: <20210713080412.941665-1-hhan@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: libvir-list@redhat.com Cc: Han Han X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1626163480229100001 Content-Type: text/plain; charset="utf-8" According to definition of virDomainCoreDumpFormat, the "elf" should be the first argument in VIR_ENUM_*. Fixes: 84cc4543be Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=3D1981625 Signed-off-by: Han Han Reviewed-by: Peter Krempa --- tools/virsh-domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index f2a5fb03a4..29748b0257 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -5412,10 +5412,10 @@ static const vshCmdOptDef opts_dump[] =3D { =20 VIR_ENUM_IMPL(virDomainCoreDumpFormat, VIR_DOMAIN_CORE_DUMP_FORMAT_LAST, + "elf", "kdump-zlib", "kdump-lzo", "kdump-snappy", - "elf", "win-dmp"); =20 static void --=20 2.31.1