From nobody Tue Feb 10 13:16:47 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1625819334; cv=none; d=zohomail.com; s=zohoarc; b=W+bboIl8/APox6xDqkN9MpcS8w6e150S2ceUZpLn4FLITFw1fjy6ofL6LTp6gJuXaC/2ABSJdAiIzTBWQ1wscKRDXjjqryIEtI49sjRhuMemF8+F/C84UWoittCgrlGQfF1KGiAJPHSi/26hB8W8dmLmbMEgA+CeZmdNcvwa33M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1625819334; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=EGrT5PBlsifxCteUM4ks3i1iKfQkPZXmL1r8jYVvI4k=; b=AItxiXoIRe9XehTm3ZkH1Tie0jKrZFIVv6j143pqLHdfEb4RvBGoLrE6uhO/3KtXVNGi6UqppG+qhdw6NcFxbrGr+QMmonwBEDC9+EVASfFSQ6QxbSH5KZUw9fkH5lIJI7454mmnl9I/Aez5MIIJg769SmNQTsW68bbVkgh/w4M= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1625819334499118.82320912519378; Fri, 9 Jul 2021 01:28:54 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-566-5Nrz96jnM8SwtkYbuGOEZQ-1; Fri, 09 Jul 2021 04:28:51 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 04410804307; Fri, 9 Jul 2021 08:28:47 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DC8DF421F; Fri, 9 Jul 2021 08:28:46 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id A72BA1809CB3; Fri, 9 Jul 2021 08:28:46 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1698S4Nj005786 for ; Fri, 9 Jul 2021 04:28:04 -0400 Received: by smtp.corp.redhat.com (Postfix) id AEF1A60861; Fri, 9 Jul 2021 08:28:04 +0000 (UTC) Received: from work.redhat.com (ovpn-113-189.ams2.redhat.com [10.36.113.189]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0947E60843; Fri, 9 Jul 2021 08:28:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625819333; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=EGrT5PBlsifxCteUM4ks3i1iKfQkPZXmL1r8jYVvI4k=; b=K9lDCR/XLXcSyMR5xaRI1lHJeUHDhnMlTaUEdo1P/O/aSGF6YZkXjf8MmNhL9c32Ultgod x0wZEAfE1dFeWNaw2mUOp/WrRe2EEK3PV+7LjMRh7NcT0Wpz1kussJK2Zf2c0ZKegEUSk2 qrkApzASbbzoJEyKtxVfET/vHF6Ff9g= X-MC-Unique: 5Nrz96jnM8SwtkYbuGOEZQ-1 From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH 05/10] iptablesPrivateChainCreate: `virHashNew` cannot return NULL Date: Fri, 9 Jul 2021 10:27:34 +0200 Message-Id: <20210709082739.29043-6-twiederh@redhat.com> In-Reply-To: <20210709082739.29043-1-twiederh@redhat.com> References: <20210709082739.29043-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Cc: Tim Wiederhake X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1625819336425100001 Content-Type: text/plain; charset="utf-8" Signed-off-by: Tim Wiederhake --- src/util/viriptables.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/src/util/viriptables.c b/src/util/viriptables.c index 4189578245..198ece3d71 100644 --- a/src/util/viriptables.c +++ b/src/util/viriptables.c @@ -70,17 +70,12 @@ iptablesPrivateChainCreate(virFirewall *fw, void *opaque) { iptablesGlobalChainData *data =3D opaque; - GHashTable *chains =3D NULL; - GHashTable *links =3D NULL; + GHashTable *chains =3D virHashNew(NULL); + GHashTable *links =3D virHashNew(NULL); const char *const *tmp; int ret =3D -1; size_t i; =20 - if (!(chains =3D virHashNew(NULL))) - goto cleanup; - if (!(links =3D virHashNew(NULL))) - goto cleanup; - tmp =3D lines; while (tmp && *tmp) { if (STRPREFIX(*tmp, "-N ")) { /* eg "-N LIBVIRT_INP" */ --=20 2.31.1