From nobody Tue Feb 10 08:27:42 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1625819334; cv=none; d=zohomail.com; s=zohoarc; b=GFX/J0PV9O++CCyOQJmISZ/s5xQCf2RSiH2P7esg3HWE3Yji9YDYiJrYjq+d+sWkX9JIDKGP/dcAZWYFlnGu0fc5V5o9UsVKeGBilRJ1h8pRg/WMZQeztLl+IYv59Jc+kRXslsYs6Wxgp/uyBTFNm9LZPlMlFIxfMk45FhunjZI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1625819334; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=L79vE08Ct+/jhsjN9bB0gK5/cfHkkrWhryJJVwdNHvA=; b=lc3x7Uu6YcD1uSQAnuGEvwLIaqjPWDigIguOm5np2/hIlQ5Nw+AOQWuoC9SZQ3XSXX5tA9mhYqDYWwojmkTgKlNBcZrN8n/iB9U4RhgluwTsJk3XbXdrS9IF7IYsD8yE1QpRjZbaZbeuPzeZYtgNBSq7JRcGkUew2hQMJN8T8FM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1625819334574212.47498681089792; Fri, 9 Jul 2021 01:28:54 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-551-i8Ie5E-WP3Wa-jZJVQ-h1A-1; Fri, 09 Jul 2021 04:28:52 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id F280519200CA; Fri, 9 Jul 2021 08:28:46 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D41895D9C6; Fri, 9 Jul 2021 08:28:46 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 9EC551809CAC; Fri, 9 Jul 2021 08:28:46 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1698S2HP005781 for ; Fri, 9 Jul 2021 04:28:02 -0400 Received: by smtp.corp.redhat.com (Postfix) id AC3DA60861; Fri, 9 Jul 2021 08:28:02 +0000 (UTC) Received: from work.redhat.com (ovpn-113-189.ams2.redhat.com [10.36.113.189]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3DFDF60843; Fri, 9 Jul 2021 08:28:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625819333; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=L79vE08Ct+/jhsjN9bB0gK5/cfHkkrWhryJJVwdNHvA=; b=Ud5Ou5AkJjF7iWTQZEpVaFtCCcSN3Z0dc9F7Q+LMehp/pok3K8L8mp8J9J90+FTJ1HT6U7 BLwvwonh0ebdVfPUhSlom5KyCJVwGrA76hxpzyg5y24holc58fN8m06kXmDExbEgnOhbpd Kgfs0TzvTWKVm0MXz2V8CAONGQuT6BU= X-MC-Unique: i8Ie5E-WP3Wa-jZJVQ-h1A-1 From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH 04/10] virNWFilterRuleDefToRuleInst: `virHashNew` cannot return NULL Date: Fri, 9 Jul 2021 10:27:33 +0200 Message-Id: <20210709082739.29043-5-twiederh@redhat.com> In-Reply-To: <20210709082739.29043-1-twiederh@redhat.com> References: <20210709082739.29043-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Cc: Tim Wiederhake X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1625819336681100005 Content-Type: text/plain; charset="utf-8" Signed-off-by: Tim Wiederhake --- tests/nwfilterxml2firewalltest.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/nwfilterxml2firewalltest.c b/tests/nwfilterxml2firewallt= est.c index bdfe858185..75a70e9972 100644 --- a/tests/nwfilterxml2firewalltest.c +++ b/tests/nwfilterxml2firewalltest.c @@ -208,8 +208,8 @@ virNWFilterRuleDefToRuleInst(virNWFilterDef *def, ruleinst->chainPriority =3D def->chainPriority; ruleinst->def =3D rule; ruleinst->priority =3D rule->priority; - if (!(ruleinst->vars =3D virHashNew(virNWFilterVarValueHashFree))) - goto cleanup; + ruleinst->vars =3D virHashNew(virNWFilterVarValueHashFree); + if (virNWFilterHashTablePutAll(vars, ruleinst->vars) < 0) goto cleanup; =20 --=20 2.31.1