From nobody Tue Feb 10 08:27:44 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1625819328; cv=none; d=zohomail.com; s=zohoarc; b=j6FUFiDugcSXCqBF8xPwdJdjGD9EyRUS4S9lnBB7h2qt997sVOxTnXxff1x7bWX+xPx4AeI8L0vUMfA3+pyHcnj/6nX18ViJAsxcRpLyPd5xEXqgfKHXmRcc4S2HGKEXmd0XC7MNuNrPlFLHGdhVekFvGXxuNgAOxlNXygAIFi0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1625819328; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=lGnyakfoVTOy+hcNvGYLZlapcvfLDhZvvB+jnGrehPw=; b=iPzvd8blmVna8RkcNOgz8nX5M83LnHKwfevXenKhfir26TK27l9eZ6oVsQk1NmNhyuZMFZsj8E8n2pryK1XcvVBs7wvZuOFZih6PDT//QQmfmkWcItMkZ1K/ILRI0CzFkT/Qxyy1OKXlKfeAjUasDBcchceD+i8fv1JjNcn+7k8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1625819328921427.46966243131715; Fri, 9 Jul 2021 01:28:48 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-508-b4k4sybxM9S2KYRDIwz3bw-1; Fri, 09 Jul 2021 04:28:44 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8F85D5074F; Fri, 9 Jul 2021 08:28:39 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 40077100EBAD; Fri, 9 Jul 2021 08:28:39 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 456204EA2F; Fri, 9 Jul 2021 08:28:38 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1698Rxxi005775 for ; Fri, 9 Jul 2021 04:27:59 -0400 Received: by smtp.corp.redhat.com (Postfix) id E1E9860861; Fri, 9 Jul 2021 08:27:59 +0000 (UTC) Received: from work.redhat.com (ovpn-113-189.ams2.redhat.com [10.36.113.189]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3BA9A60843; Fri, 9 Jul 2021 08:27:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625819327; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=lGnyakfoVTOy+hcNvGYLZlapcvfLDhZvvB+jnGrehPw=; b=baZEIaajvhvlVXR5NmxOev3+qVKc3IpBeGqnXTvwy8xSD3O5HQ6fLeVPwMRK5ATQsEMGZY hsCXVMziba2puxTw0tnTdsews/oiAAeMca35ftilb2rkVW+77GXwr6sq2degUwbjE0beQZ DTuVjVvOZW86e2KOHR8wq5M7/YWvpSU= X-MC-Unique: b4k4sybxM9S2KYRDIwz3bw-1 From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH 03/10] virNWFilterCreateVarsFrom: Remove superfluous `goto`s Date: Fri, 9 Jul 2021 10:27:32 +0200 Message-Id: <20210709082739.29043-4-twiederh@redhat.com> In-Reply-To: <20210709082739.29043-1-twiederh@redhat.com> References: <20210709082739.29043-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Cc: Tim Wiederhake X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1625819330320100004 Content-Type: text/plain; charset="utf-8" Signed-off-by: Tim Wiederhake --- tests/nwfilterxml2firewalltest.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/tests/nwfilterxml2firewalltest.c b/tests/nwfilterxml2firewallt= est.c index 26d4a936ad..bdfe858185 100644 --- a/tests/nwfilterxml2firewalltest.c +++ b/tests/nwfilterxml2firewalltest.c @@ -151,15 +151,12 @@ virNWFilterCreateVarsFrom(GHashTable *vars1, g_autoptr(GHashTable) res =3D virHashNew(virNWFilterVarValueHashFree); =20 if (virNWFilterHashTablePutAll(vars1, res) < 0) - goto err_exit; + return NULL; =20 if (virNWFilterHashTablePutAll(vars2, res) < 0) - goto err_exit; + return NULL; =20 return g_steal_pointer(&res); - - err_exit: - return NULL; } =20 =20 --=20 2.31.1