From nobody Tue Feb 10 13:16:41 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1625819343; cv=none; d=zohomail.com; s=zohoarc; b=f7UBFnr2qahMT1JWKkYhSY3293VBR33QKkgZqQqNN9/1nm2zrGj8bnp6Zq/WEpTnmk5areM78IJZaXhcfTB0PqTv2QZwYL5TH9y+UbQZ6nv6tYrVtYCQjAcA0FePjqEnSAhfHTAIMqsNXB+jdLH5/cDKR1peQMgqXFgH5dxWVQQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1625819343; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=aRdgXMtqTYDJXcKLQIVQ4Ezl/LLG8jScaxXTsD0Ex6Q=; b=j3T9mMm2mZ3tJYMIIUfT0APlZOx0el6Ej0hw+CuOTcO6YAa9Z6miKxsHV167kLdF1CXYhGY+9tD3H8tQR4Bw4RgdeQqXlxIElHZPdp0hpEeqsSsnadHtj1F6FnO3Y9kvLhC98+NUvX00PEbTwgdcxc9IT9UUB1fbUX8eZnFByNU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 162581934349892.74056006673868; Fri, 9 Jul 2021 01:29:03 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-323-CVstp-42PuiXKCxN0KaADw-1; Fri, 09 Jul 2021 04:29:00 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5405C5075B; Fri, 9 Jul 2021 08:28:55 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3902E369A; Fri, 9 Jul 2021 08:28:55 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 0701C1801257; Fri, 9 Jul 2021 08:28:55 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1698SGVs005821 for ; Fri, 9 Jul 2021 04:28:16 -0400 Received: by smtp.corp.redhat.com (Postfix) id 8C6A760861; Fri, 9 Jul 2021 08:28:16 +0000 (UTC) Received: from work.redhat.com (ovpn-113-189.ams2.redhat.com [10.36.113.189]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3BA4160843; Fri, 9 Jul 2021 08:28:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625819342; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=aRdgXMtqTYDJXcKLQIVQ4Ezl/LLG8jScaxXTsD0Ex6Q=; b=O56/1p33AqLi6H1N0tkexk61OWxK6D3kLGRCvStOsf1cY0h/ZNZn3eyQ01fNAU1ti4CFWl 6lx/7gf5ExdT+CWyM1qADQuKugNspSG+rkl4+YYHDoATJL7QSEEz1eAexMKaXL4wb2VGTn Fazt0MAho9XKxQhCl49dj3DSHEuOFm8= X-MC-Unique: CVstp-42PuiXKCxN0KaADw-1 From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH 10/10] qemuMonitorGetMemoryDeviceInfo: `virHashNew` cannot return NULL Date: Fri, 9 Jul 2021 10:27:39 +0200 Message-Id: <20210709082739.29043-11-twiederh@redhat.com> In-Reply-To: <20210709082739.29043-1-twiederh@redhat.com> References: <20210709082739.29043-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Cc: Tim Wiederhake X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1625819345030100001 Content-Type: text/plain; charset="utf-8" Signed-off-by: Tim Wiederhake --- src/qemu/qemu_monitor.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index 3a56ed8ef9..4506f962d1 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c @@ -4238,7 +4238,7 @@ int qemuMonitorGetMemoryDeviceInfo(qemuMonitor *mon, GHashTable **info) { - g_autoptr(GHashTable) hash =3D NULL; + g_autoptr(GHashTable) hash =3D virHashNew(g_free); int ret; =20 VIR_DEBUG("info=3D%p", info); @@ -4247,9 +4247,6 @@ qemuMonitorGetMemoryDeviceInfo(qemuMonitor *mon, =20 QEMU_CHECK_MONITOR(mon); =20 - if (!(hash =3D virHashNew(g_free))) - return -1; - if ((ret =3D qemuMonitorJSONGetMemoryDeviceInfo(mon, hash)) >=3D 0) { *info =3D g_steal_pointer(&hash); } --=20 2.31.1